You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/09/02 11:14:14 UTC

Re: Review Request 51331: Test cases for scheduler api

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51331/#review147647
-----------------------------------------------------------




lens-server/src/test/java/org/apache/lens/server/scheduler/ScheduleResourceTest.java (line 66)
<https://reviews.apache.org/r/51331/#comment214866>

    super.setup() and super.teardown() should be called from @BeforeTest @AfterTest annotations, as done in other tests.



lens-server/src/test/java/org/apache/lens/server/scheduler/ScheduleResourceTest.java (lines 68 - 69)
<https://reviews.apache.org/r/51331/#comment214867>

    Shouldnt be required as LensJerseyTest should already start the services.


- Amareshwari Sriramadasu


On Aug. 23, 2016, 1:53 p.m., Lavkesh Lahngir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51331/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 1:53 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1285
>     https://issues.apache.org/jira/browse/LENS-1285
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> End to end test cases for Scheduler
> 
> 
> Diffs
> -----
> 
>   lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 57786e6 
>   lens-server/src/test/java/org/apache/lens/server/scheduler/ScheduleResourceTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>