You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/07/20 16:58:32 UTC
Review Request 61001: Windows: Fixed `CreateProcess` error message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61001/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
The buffer conversion of the argument string was being printed instead
of the argument string itself, leading to an error message with a bunch
of bytes.
Diffs
-----
3rdparty/stout/include/stout/os/windows/shell.hpp 0d8d45b8808df978d6a7c00a622e47384de74369
Diff: https://reviews.apache.org/r/61001/diff/1/
Testing
-------
Built and ran `stout-tests` on Windows.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61001: Windows: Fixed `CreateProcess` error
message.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61001/#review181072
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On July 20, 2017, 10:05 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61001/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 10:05 a.m.)
>
>
> Review request for mesos, Joseph Wu and Li Li.
>
>
> Bugs: MESOS-7817
> https://issues.apache.org/jira/browse/MESOS-7817
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The buffer conversion of the argument string was being printed instead
> of the argument string itself, leading to an error message with a bunch
> of bytes.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/shell.hpp 0d8d45b8808df978d6a7c00a622e47384de74369
>
>
> Diff: https://reviews.apache.org/r/61001/diff/1/
>
>
> Testing
> -------
>
> Built and ran `stout-tests` on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61001: Windows: Fixed `CreateProcess` error
message.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61001/
-----------------------------------------------------------
(Updated July 20, 2017, 10:05 a.m.)
Review request for mesos, Joseph Wu and Li Li.
Bugs: MESOS-7817
https://issues.apache.org/jira/browse/MESOS-7817
Repository: mesos
Description
-------
The buffer conversion of the argument string was being printed instead
of the argument string itself, leading to an error message with a bunch
of bytes.
Diffs
-----
3rdparty/stout/include/stout/os/windows/shell.hpp 0d8d45b8808df978d6a7c00a622e47384de74369
Diff: https://reviews.apache.org/r/61001/diff/1/
Testing
-------
Built and ran `stout-tests` on Windows.
Thanks,
Andrew Schwartzmeyer