[GitHub] [pinot] walterddr commented on a diff in pull request #11112: V2 allocation optimizations

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #11112:
URL: https://github.com/apache/pinot/pull/11112#discussion_r1263915511


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionOnlyOperator.java:
##########
@@ -75,6 +75,8 @@ public SelectionOnlyOperator(IndexSegment indexSegment, QueryContext queryContex
     _dataSchema = new DataSchema(columnNames, columnDataTypes);
 
     _numRowsToKeep = queryContext.getLimit();
+    // TODO(gortiz): I think this is incorrect. The SelectionOperatorUtils.MAX_ROW_HOLDER_INITIAL_CAPACITY limit
+    //  is not enforced later in getNextBlock

Review Comment:
   this hint is only used during leaf initialization. i don't think there's any plan to create another default on intermediate select/project. but we can see if that helps 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org