You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/21 08:33:00 UTC
[GitHub] [druid] maytasm3 opened a new pull request #9552: Imply 2479
maytasm3 opened a new pull request #9552: Imply 2479
URL: https://github.com/apache/druid/pull/9552
S3 ingestion spec should not uses the default credentials provider chain when environment value password provider is misconfigured.
### Description
This PR fixes the bug that S3 ingestion spec uses the default credentials provider chain when environment value password provider is misconfigured. The new and correct behavior is that If environment value password provider is misconfigured or any other cases that resulted in the s3 access key and/or s3 secret key from the PasswordProvider being null, the ingestion will failed. The task logs will then surface error message "IllegalArgumentException: Access key cannot be null" to let the user that Access key or secret key was null. Note that ingestion will also fail if only one PasswordProvider is configured (PasswordProvider given for Access key but not Secret key OR PasswordProvider given for Secret key but not Access key).
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [x] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9552: S3 ingestion spec
should not uses the default credentials provider chain when environment
value password provider is misconfigured.
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9552: S3 ingestion spec should not uses the default credentials provider chain when environment value password provider is misconfigured.
URL: https://github.com/apache/druid/pull/9552
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9552: S3 ingestion spec
should not uses the default credentials provider chain when environment
value password provider is misconfigured.
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9552: S3 ingestion spec should not uses the default credentials provider chain when environment value password provider is misconfigured.
URL: https://github.com/apache/druid/pull/9552#issuecomment-603393282
Please fix the checkstyle error.
```
[ERROR] /home/travis/build/apache/druid/integration-tests/src/test/java/org/apache/druid/tests/indexer/ITS3OverrideCredentialsIndexTest.java:36: Using a static member import should be avoided - org.apache.directory.api.util.IOUtils.closeQuietly. [AvoidStaticImport]
[ERROR] /home/travis/build/apache/druid/integration-tests/src/test/java/org/apache/druid/tests/indexer/ITS3OverrideCredentialsIndexTest.java:194:5: '}' at column 5 should be alone on a line. [RightCurly]
[ERROR] /home/travis/build/apache/druid/integration-tests/src/test/java/org/apache/druid/tests/indexer/ITS3OverrideCredentialsIndexTest.java:271:5: '}' at column 5 should be alone on a line. [RightCurly]
[ERROR] /home/travis/build/apache/druid/integration-tests/src/test/java/org/apache/druid/tests/indexer/ITS3OverrideCredentialsIndexTest.java:277:50: '{' at column 50 should be on a new line. [LeftCurly]
[ERROR] /home/travis/build/apache/druid/integration-tests/src/test/java/org/apache/druid/tests/indexer/ITS3OverrideCredentialsIndexTest.java:282:5: '}' at column 5 should be alone on a line. [RightCurly]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9552: S3 ingestion spec
should not uses the default credentials provider chain when environment
value password provider is misconfigured.
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9552: S3 ingestion spec should not uses the default credentials provider chain when environment value password provider is misconfigured.
URL: https://github.com/apache/druid/pull/9552#issuecomment-603530636
The latest travis build has passed: https://travis-ci.org/github/apache/druid/builds/666481903. Merging this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm3 commented on issue #9552: S3 ingestion spec should
not uses the default credentials provider chain when environment value
password provider is misconfigured.
Posted by GitBox <gi...@apache.org>.
maytasm3 commented on issue #9552: S3 ingestion spec should not uses the default credentials provider chain when environment value password provider is misconfigured.
URL: https://github.com/apache/druid/pull/9552#issuecomment-603444116
@clintropolis @jihoonson Fixed CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org