You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/06/28 15:22:40 UTC
[GitHub] [arrow] rtpsw opened a new pull request, #36356: GH-36311: [C++][CI] Sporadic errors in
rtpsw opened a new pull request, #36356:
URL: https://github.com/apache/arrow/pull/36356
### Rationale for this change
Skipping a flaky test until a robust way for it is found.
### What changes are included in this PR?
The `AsofJoinTest.BackpressureWithBatchesGen` test is skipped.
### Are these changes tested?
N/A
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36356: GH-36331: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1612536195
I see. I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36356: GH-36311: [C++][CI] Sporadic errors in
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1611643016
:warning: GitHub issue #36311 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36356: GH-36331: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1618211075
Conbench analyzed the 5 benchmark runs on commit `5cc6aa35`.
There were 8 benchmark results indicating a performance regression:
- Commit Run on `arm64-m6g-linux-compute` at [2023-06-29 08:58:30Z](http://conbench.ursa.dev/compare/runs/92ba446c783649bdb423fc6dc23fa9ad...42c11ba445b7464daed98eb96f4776b3/)
- [params=1048576/1, source=cpp-micro, suite=arrow-acero-aggregate-benchmark](http://conbench.ursa.dev/compare/benchmarks/0649d19e69967738800021d8b7d266fe...0649d481066d7fed8000771371882fa4)
- [params=1048576/10000, source=cpp-micro, suite=arrow-acero-aggregate-benchmark](http://conbench.ursa.dev/compare/benchmarks/0649d19e6ecb7228800062bdaf481a57...0649d4810af37da48000cfd51d930a1b)
- and 6 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14738529168) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on pull request #36356: GH-36311: [C++][CI] Sporadic errors in
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1611643637
cc @icexelloss, @pitrou, @bkietz, @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36356: GH-36331: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1612105672
Are the followings correct?
* We disable the test and close #36331 as a workaround for now.
* We will add a real fix and close #36248 later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36356: GH-36311: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1611648980
:warning: GitHub issue #36311 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36356: GH-36331: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1611652559
:warning: GitHub issue #36331 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36356: GH-36311: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1611648964
@rtpsw Looks like you mentioned the wrong issue number in the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on pull request #36356: GH-36331: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on PR #36356:
URL: https://github.com/apache/arrow/pull/36356#issuecomment-1612534461
Yes, this is my understanding of [this post](https://github.com/apache/arrow/issues/36331#issuecomment-1609823654).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36356: GH-36331: [C++][CI] Sporadic errors in AsofJoinTest
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36356:
URL: https://github.com/apache/arrow/pull/36356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org