[GitHub] [netbeans] DevCharly commented on a change in pull request #2051: [NETBEANS-3428] FlatLaf: hover in multi-tabs

[GitBox <gi...@apache.org>]

DevCharly commented on a change in pull request #2051: [NETBEANS-3428] FlatLaf: hover in multi-tabs
URL: https://github.com/apache/netbeans/pull/2051#discussion_r400473543
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java
 ##########
 @@ -58,6 +58,7 @@
     private static final Color underlineColor = UIManager.getColor("nb.multitabs.underlineColor"); // NOI18N
     private static final Color inactiveUnderlineColor = UIManager.getColor("nb.multitabs.inactiveUnderlineColor"); // NOI18N
     private static final Color activeBackground = UIManager.getColor("nb.multitabs.activeBackground"); // NOI18N
+    private static final Color hoverBackground = UIManager.getColor("nb.multitabs.hoverBackground"); // NOI18N
 
 Review comment:
   > Other LAFs, e.g. Windows, have a hover color as well.
   
   There are two implementation for editor tabs in NB:
   - "Tab Control" (package org.netbeans.swing.tabcontrol)
   - "Multi-tabs" (package org.netbeans.core.multitabs)
   
   Tab-control is used by default and has hover colors in all Lafs (I think).
   Multi-tabs is used e.g. if tab placement is left/right/bottom (see #1865 for more options to enable multi-tabs). Multi-tabs did not support hover in the past. This PR adds hover to multi-tabs.
   
   > If the new property is needed, should the other LAFs be updated to use it as well?
   
   Yes, this a good idea. Can be done in another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists