You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Malcolm Rowe <ma...@farside.org.uk> on 2005/10/05 18:58:34 UTC
[PATCH] Quiet warning in libsvn_diff/diff.c
All,
r16476 introduced a new warning to my OS X build:
subversion/libsvn_client/diff.c:2370: warning: function declaration isn't a prototype
The attached trivial patch fixes that.
[[[
* subversion/libsvn_client/diff.c
(unsupported_diff_summarize): Fix warning 'function declaration isn't
a prototype'.
]]]
Regards,
Malcolm
Re: [PATCH] Quiet more warnings from r16476
Posted by Daniel Rall <dl...@finemaltcoding.com>.
On Thu, 06 Oct 2005, Malcolm Rowe wrote:
> On Wed, Oct 05, 2005 at 10:02:20PM +0200, Peter N. Lundblad wrote:
> > Committed in r16493. Thanks for doing my dogwork!
>
> More dogwork, more warnings, I'm afraid. Two of the functions in
> repos_diff_summarize.c are internal, but not static, so they get exported,
> and I get a "no previous prototype for 'function'" warning.
Thanks Malcolm, I noticed these myself, mentioned them on IRC, and found
your patch the next time I looked at my mail. Committed in r16558.
- Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Quiet more warnings from r16476
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Wed, Oct 05, 2005 at 10:02:20PM +0200, Peter N. Lundblad wrote:
> Committed in r16493. Thanks for doing my dogwork!
More dogwork, more warnings, I'm afraid. Two of the functions in
repos_diff_summarize.c are internal, but not static, so they get exported,
and I get a "no previous prototype for 'function'" warning.
[[[
* subversion/libsvn_client/repos_diff_summarize.c
(create_item_baton, ensure_summarize): Add 'static' qualifier, unexporting
these private functions and quieting two warnings.
]]]
Regards,
Malcolm
Re: [PATCH] Quiet warning in libsvn_diff/diff.c
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Wed, 5 Oct 2005, Malcolm Rowe wrote:
> r16476 introduced a new warning to my OS X build:
>
> subversion/libsvn_client/diff.c:2370: warning: function declaration isn't a prototype
>
> The attached trivial patch fixes that.
>
Committed in r16493. Thanks for doing my dogwork!
Best,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org