You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yulei-Yang (via GitHub)" <gi...@apache.org> on 2023/12/01 06:26:25 UTC
[PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Yulei-Yang opened a new pull request, #27868:
URL: https://github.com/apache/doris/pull/27868
## Proposed changes
Currently, inserting into a jdbc table work well only when columns in insert stmt are same order with columns in table definition.
If orders are different, bug occurs, like below:
Issue Number: close #27695
fix another case:
<img width="745" alt="image" src="https://github.com/apache/doris/assets/28004179/4c991a2f-4ec4-4da7-aa5b-1395b27b86c9">
insert into jdbc_mysql.db1.test(pname,aid) values('p1',1);
(172.17.0.2)[INTERNAL_ERROR]UdfRuntimeException: JDBC executor sql has error:
CAUSED BY: BatchUpdateException: Incorrect integer value: 'p1' for column 'aid' at row 1
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on PR #27868:
URL: https://github.com/apache/doris/pull/27868#issuecomment-1835584139
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on PR #27868:
URL: https://github.com/apache/doris/pull/27868#issuecomment-1835543376
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman closed pull request #27868: [fix](jdbc_catalog) fix disorder of columns in insert values stmt
URL: https://github.com/apache/doris/pull/27868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27868:
URL: https://github.com/apache/doris/pull/27868#issuecomment-1835687690
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.46 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17163732645 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on PR #27868:
URL: https://github.com/apache/doris/pull/27868#issuecomment-1835703319
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27868:
URL: https://github.com/apache/doris/pull/27868#issuecomment-1835681444
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 824327ac52b31c39843e0839701b427c2f536864, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4870 4705 4697 4697
q2 354 159 158 158
q3 1528 1320 1326 1320
q4 1149 961 965 961
q5 3245 3221 3230 3221
q6 251 130 132 130
q7 1013 524 567 524
q8 2201 2227 2211 2211
q9 6993 6982 7054 6982
q10 3322 3372 3341 3341
q11 341 217 203 203
q12 356 218 225 218
q13 4628 4208 4164 4164
q14 245 219 227 219
q15 608 534 537 534
q16 432 402 404 402
q17 1044 618 578 578
q18 7820 7858 8007 7858
q19 1559 1570 1529 1529
q20 529 306 312 306
q21 3390 2899 3008 2899
q22 370 306 305 305
Total cold run time: 46248 ms
Total hot run time: 42760 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4618 4646 4582 4582
q2 323 182 211 182
q3 3714 3716 3702 3702
q4 2500 2481 2489 2481
q5 6073 6091 6054 6054
q6 246 121 124 121
q7 2679 2016 1980 1980
q8 3685 3699 3681 3681
q9 9418 9389 9421 9389
q10 4031 4105 4120 4105
q11 638 507 496 496
q12 796 623 669 623
q13 4383 3643 3586 3586
q14 288 247 255 247
q15 605 532 535 532
q16 510 480 526 480
q17 2146 2032 2044 2032
q18 9361 9075 8885 8885
q19 1800 1790 1776 1776
q20 2290 1984 1961 1961
q21 7274 6803 6858 6803
q22 638 572 585 572
Total cold run time: 68016 ms
Total hot run time: 64270 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on PR #27868:
URL: https://github.com/apache/doris/pull/27868#issuecomment-1835739790
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix disorder of columns in insert values stmt [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27868:
URL: https://github.com/apache/doris/pull/27868#issuecomment-1836064195
Hi @Yulei-Yang
this issue has been fixed in https://github.com/apache/doris/pull/27855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org