You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/02/15 09:08:08 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #24176: Refactor `ShowDefaultShardingStrategyExecutor`
Qianyi951015 opened a new pull request, #24176:
URL: https://github.com/apache/shardingsphere/pull/24176
Changes proposed in this pull request:
- Refactor `ShowDefaultShardingStrategyExecutor`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24176: Refactor `ShowDefaultShardingStrategyExecutor`
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24176:
URL: https://github.com/apache/shardingsphere/pull/24176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24176: Refactor `ShowDefaultShardingStrategyExecutor`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24176:
URL: https://github.com/apache/shardingsphere/pull/24176#issuecomment-1431065809
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24176?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24176](https://codecov.io/gh/apache/shardingsphere/pull/24176?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c18fb9d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/eabed449129207828d822753fb41ba35908794e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eabed44) will **decrease** coverage by `0.01%`.
> The diff coverage is `90.00%`.
> :exclamation: Current head c18fb9d differs from pull request most recent head 7e64e53. Consider uploading reports for the commit 7e64e53 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24176 +/- ##
============================================
- Coverage 50.13% 50.12% -0.01%
Complexity 1579 1579
============================================
Files 3258 3258
Lines 53513 53503 -10
Branches 9856 9854 -2
============================================
- Hits 26829 26821 -8
+ Misses 24325 24324 -1
+ Partials 2359 2358 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ler/query/ShowDefaultShardingStrategyExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvcXVlcnkvU2hvd0RlZmF1bHRTaGFyZGluZ1N0cmF0ZWd5RXhlY3V0b3IuamF2YQ==) | `85.00% <90.00%> (+1.66%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org