You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/14 03:30:32 UTC
[GitHub] [apisix] shuaijinchao opened a new issue #6604: chore: add semicolon check in meke lint
shuaijinchao opened a new issue #6604:
URL: https://github.com/apache/apisix/issues/6604
### Issue description
Check for `;` at the end of lua code and add the check to make lint.
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6604: chore: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1066560568
> ### Issue description
> Check for `;` at the end of lua code and add the check to make lint.
@shuaijinchao I think more details can be supplemented so that it can be a good first issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6604: request help: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
kwanhur commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1073449516
I'm not sure, but hope some ideas could inspire by [lualint](https://github.com/philips/lualint/blob/master/lualint).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #6604: chore: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1066718526
> > ### Issue description
> > Check for `;` at the end of lua code and add the check to make lint.
>
> @shuaijinchao I think more details can be supplemented so that it can be a good first issue.
Yes, I am also investigating the details of the solution. There is currently a solution using grep command + regular expression, but this solution is not completely correct for current automatic filtering, so it cannot be applied to CI. I will sync to the issues when new solutions are available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #6604: request help: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1071924457
> We need a better way, `grep --include="*.lua" -R -Ev '^$|^[--]*.*[^;]$' apisix` is not suitable for us.
>
Yes, this way is not suitable to put into CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #6604: request help: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1070645773
We need a better way, `grep --include="*.lua" -R -Ev '^$|^[--]*.*[^;]$' apisix` is not suitable for us.
<img width="1607" alt="image" src="https://user-images.githubusercontent.com/6814606/158780783-67d58ce9-bf87-4f4b-962f-7af7d7bd0ccd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #6604: request help: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1071924457
> We need a better way, `grep --include="*.lua" -R -Ev '^$|^[--]*.*[^;]$' apisix` is not suitable for us.
>
Yes, this way is not suitable to put into CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #6604: chore: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1068038563
> I think @shuaijinchao can write your solution first, although he may not be perfect. But it is also useful for others.
Updated to topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #6604: chore: add semicolon check in `make lint`
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1067462453
I think @shuaijinchao can write your solution first, although he may not be perfect. But it is also useful for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org