You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/20 07:35:22 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #19296: [improve][ci] Improve code coverage reporting

lhotari opened a new pull request, #19296:
URL: https://github.com/apache/pulsar/pull/19296

   ### Motivation
   
   After reviewing the latest changes made in #19264 for collecting code coverage in a new way, there are a few details that need to be adjusted. 
   The Codecov results can be seen for the PR commit at 
   https://app.codecov.io/github/apache/pulsar/commit/62060c814bf90de9b8f7cd520e2dc5459b394cbe/tree
   The build workflow run contained Jacoco html reports at https://github.com/apache/pulsar/actions/runs/3961486478 .
   
   ### Modifications
   
   - use test scope classpath to collect correct dependencies
     - exclude test projects so that coverage doesn't get reported for them
   - show link to Codecov commit level report
   - notify as soon as 4 uploads are completed for the commit
     -  ignore the CI status since that is often wrong in Codecov and the notification doesn't appear at all.
     - It's sufficient to wait for 4 uploads to happen now that it happens consistently after #19264 changes
   - exclude shaded classes from Jacoco instrumentation to lower Jacoco's overhead
   - excluded protobuf generated classes from Jacoco instrumentation
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #19296: [improve][ci] Improve code coverage reporting

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19296:
URL: https://github.com/apache/pulsar/pull/19296#issuecomment-1398308556

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19296](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (602f60f) into [master](https://codecov.io/gh/apache/pulsar/commit/29c244a74b5464eb6e40e3c3662effb9fa0a76a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29c244a) will **increase** coverage by `10.04%`.
   > The diff coverage is `87.93%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/19296/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #19296       +/-   ##
   =============================================
   + Coverage     52.84%   62.89%   +10.04%     
   - Complexity    22367    26118     +3751     
   =============================================
     Files          1824     1895       +71     
     Lines        136749   137475      +726     
     Branches      15047    15091       +44     
   =============================================
   + Hits          72264    86460    +14196     
   + Misses        56968    43085    -13883     
   - Partials       7517     7930      +413     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `23.99% <56.89%> (+1.63%)` | :arrow_up: |
   | systests | `25.59% <53.44%> (+0.58%)` | :arrow_up: |
   | unittests | `60.72% <86.20%> (+13.69%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/pulsar/websocket/WebSocketService.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9XZWJTb2NrZXRTZXJ2aWNlLmphdmE=) | `72.02% <ø> (+5.82%)` | :arrow_up: |
   | [...che/pulsar/websocket/AbstractWebSocketHandler.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9BYnN0cmFjdFdlYlNvY2tldEhhbmRsZXIuamF2YQ==) | `42.02% <37.50%> (+1.31%)` | :arrow_up: |
   | [...pulsar/metadata/impl/MetadataStoreFactoryImpl.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9NZXRhZGF0YVN0b3JlRmFjdG9yeUltcGwuamF2YQ==) | `80.00% <92.85%> (+30.00%)` | :arrow_up: |
   | [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `78.83% <100.00%> (+4.82%)` | :arrow_up: |
   | [...org/apache/pulsar/broker/ServiceConfiguration.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvU2VydmljZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `98.70% <100.00%> (+0.43%)` | :arrow_up: |
   | [...apache/pulsar/metadata/impl/EtcdMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9FdGNkTWV0YWRhdGFTdG9yZS5qYXZh) | `81.43% <100.00%> (-1.48%)` | :arrow_down: |
   | [...pulsar/metadata/impl/LocalMemoryMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9Mb2NhbE1lbW9yeU1ldGFkYXRhU3RvcmUuamF2YQ==) | `87.85% <100.00%> (+0.35%)` | :arrow_up: |
   | [...che/pulsar/metadata/impl/RocksdbMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9Sb2Nrc2RiTWV0YWRhdGFTdG9yZS5qYXZh) | `72.94% <100.00%> (+0.28%)` | :arrow_up: |
   | [...g/apache/pulsar/metadata/impl/ZKMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9aS01ldGFkYXRhU3RvcmUuamF2YQ==) | `77.09% <100.00%> (+7.58%)` | :arrow_up: |
   | [...ta/impl/batching/AbstractBatchedMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9iYXRjaGluZy9BYnN0cmFjdEJhdGNoZWRNZXRhZGF0YVN0b3JlLmphdmE=) | `84.21% <100.00%> (ø)` | |
   | ... and [718 more](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari merged pull request #19296: [improve][ci] Improve code coverage reporting

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #19296:
URL: https://github.com/apache/pulsar/pull/19296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org