You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2010/10/27 11:47:21 UTC
[jira] Created: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
--------------------------------------------------------------------------------------------------
Key: WICKET-3135
URL: https://issues.apache.org/jira/browse/WICKET-3135
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.13
Reporter: Martijn Dashorst
For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985471#action_12985471 ]
Hudson commented on WICKET-3135:
--------------------------------
Integrated in Apache Wicket 1.4.x #398 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/398/])
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Igor Vaynberg
> Fix For: 1.4.16
>
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926800#action_12926800 ]
Hudson commented on WICKET-3135:
--------------------------------
Integrated in Apache Wicket 1.5.x #476 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/476/])
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3135:
---------------------------------------
Assignee: Martin Grigorov
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3135.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
1.4.14
Fixed with r1029437 in 1.4.x and r1029441 in 1.5.x
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Sverre Boschman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927204#action_12927204 ]
Sverre Boschman edited comment on WICKET-3135 at 11/1/10 6:56 PM:
------------------------------------------------------------------
Added a patch with an override of toString() like getLocale() and lastModifiedTime() for both Compressed and Filtering streams.
was (Author: sverre_boschman):
Override of toString() like getLocale() and lastModifiedTime().
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-3135:
-------------------------------------
Fix Version/s: (was: 1.5-M4)
(was: 1.4.14)
removing fix versions since this was reopened, which must mean that it's not fixed in these versions
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst reopened WICKET-3135:
--------------------------------------
Patch provided by developer
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Sverre Boschman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sverre Boschman updated WICKET-3135:
------------------------------------
Attachment: test-WICKET-3135.patch
Actually it is not the toString() from JavascriptPackageResource that is causing the problem for the requestlogger. It is the toString() from the underlying resourcestream.
Two output examples of the requestlogger:
[ResourceStreamRequestTarget[resourceStream=org.apache.wicket.markup.html.JavascriptPackageResource$2@3796a671,fileName=null]
[ResourceStreamRequestTarget[resourceStream=jar:file://wickext/resources/auto/ui.autocomplete.css,fileName=null]
Both resources are served by a ResourceStreamRequestTarget, which does a resourceStream.toString() to generate the requestlog output in its own toString() method. The FilteringResourceStream and CompressingResourceStream used for the javascript resources do not implement a toString() and are responsible for the stream hashcode in the requestlogger.
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
> Attachments: test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Sverre Boschman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927199#action_12927199 ]
Sverre Boschman edited comment on WICKET-3135 at 11/1/10 6:55 PM:
------------------------------------------------------------------
Actually it is not the toString() from JavascriptPackageResource that is causing the problem for the requestlogger. It is the toString() from the underlying resourcestream.
Two output examples of the requestlogger:
[ResourceStreamRequestTarget[resourceStream=org.apache.wicket.markup.html.JavascriptPackageResource$2@3796a671,fileName=null]
[ResourceStreamRequestTarget[resourceStream=jar:file://wickext/resources/auto/ui.autocomplete.css,fileName=null]
Both resources are served by a ResourceStreamRequestTarget, which does a resourceStream.toString() to generate the requestlog output in its own toString() method. The FilteringResourceStream and CompressingResourceStream used for the javascript resources do not implement a toString() and are responsible for the stream hashcode in the requestlogger.
Added unittest example.
was (Author: sverre_boschman):
Actually it is not the toString() from JavascriptPackageResource that is causing the problem for the requestlogger. It is the toString() from the underlying resourcestream.
Two output examples of the requestlogger:
[ResourceStreamRequestTarget[resourceStream=org.apache.wicket.markup.html.JavascriptPackageResource$2@3796a671,fileName=null]
[ResourceStreamRequestTarget[resourceStream=jar:file://wickext/resources/auto/ui.autocomplete.css,fileName=null]
Both resources are served by a ResourceStreamRequestTarget, which does a resourceStream.toString() to generate the requestlog output in its own toString() method. The FilteringResourceStream and CompressingResourceStream used for the javascript resources do not implement a toString() and are responsible for the stream hashcode in the requestlogger.
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3135:
---------------------------------------
Assignee: (was: Martin Grigorov)
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Sverre Boschman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sverre Boschman updated WICKET-3135:
------------------------------------
Attachment: fix-WICKET-3135.patch
Override of toString() like getLocale() and lastModifiedTime().
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926797#action_12926797 ]
Hudson commented on WICKET-3135:
--------------------------------
Integrated in Apache Wicket 1.4.x #242 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/242/])
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.4.14, 1.5-M4
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3135) Improve
JavaScriptPackageResource#toString() to show filename instead of default
Object#toString()
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3135.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.16
Assignee: Igor Vaynberg
> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-3135
> URL: https://issues.apache.org/jira/browse/WICKET-3135
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Martijn Dashorst
> Assignee: Igor Vaynberg
> Fix For: 1.4.16
>
> Attachments: fix-WICKET-3135.patch, test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.