You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/12/13 22:22:23 UTC

[GitHub] [hadoop] li-leyang commented on pull request #5160: HDFS-16852 Register the shutdown hook only when not in shutdown for KeyProviderCache constructor

li-leyang commented on PR #5160:
URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1349892544

   I think the original intention was to explicitly invalidate KeyProviderCache at each DFSClient close. We need to explicit close this singleton cache at DFSClient close hence this was added in JVM ShutdownHook. 
   For some cases that KeyProviderCache is not used, I agree that we can swallow the exception and not add shutdownhook.   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org