[GitHub] [hbase] pankaj72981 commented on a change in pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling

[GitBox <gi...@apache.org>]

pankaj72981 commented on a change in pull request #3544:
URL: https://github.com/apache/hbase/pull/3544#discussion_r679642255



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
##########
@@ -116,6 +122,12 @@ public void exception(Throwable throwable) {
         source.multiActionTooLargeException();
       } else if (throwable instanceof CallQueueTooBigException) {
         source.callQueueTooBigException();
+      } else if (throwable instanceof QuotaExceededException) {
+        source.quotaExceededException();
+      } else if (throwable instanceof RpcThrottlingException) {
+        source.rpcThrottlingException();
+      } else if (LOG.isDebugEnabled()) {
+        LOG.debug("Unknown exception type: " + throwable.getClass().getSimpleName());

Review comment:
       Log the exception instead of class name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org