You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/09/07 07:13:59 UTC
[PR] Improve check translation completeness script: [airflow]
potiuk opened a new pull request, #55342:
URL: https://github.com/apache/airflow/pull/55342
* the file check at the beginning has languages sorted and only displays those languages in case of differences that have differences (and only shows the differences)
* at the end of the check summary is printed for all language (sorted) showing the overall status of all languages.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve check translation completeness script: [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #55342:
URL: https://github.com/apache/airflow/pull/55342#discussion_r2328550417
##########
dev/i18n/check_translations_completeness.py:
##########
@@ -478,16 +489,31 @@ def cli(language: str | None = None, add_missing: bool = False):
else:
lang_diff = print_language_summary(locale_files, summary, console)
found_difference = found_difference or lang_diff
- has_todos = print_translation_progress(
+ has_todos, coverage_per_language = print_translation_progress(
console,
[lf for lf in locale_files if language is None or lf.locale == language],
missing_counts,
summary,
)
if not found_difference and not has_todos:
- console.print("\n[green]All translations are complete and consistent![/green]\n\n")
+ console.print("\n[green]All translations are complete![/green]\n\n")
else:
- console.print("\n[red]Some translations are neither complete nor consistent![/red]\n\n")
+ console.print("\n[red]Some translations are not complete![/red]\n\n")
+ # Print summary of total coverage per language
+ if coverage_per_language:
+ summary_table = Table(show_header=True, header_style="bold magenta")
+ summary_table.title = "Total Coverage per Language"
+ summary_table.add_column("Language", style="cyan")
+ summary_table.add_column("Coverage", style="green")
+ for lang, coverage in sorted(coverage_per_language.items()):
+ if coverage >= 95:
Review Comment:
Not sure if those are good thresholds @shahar1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve check translation completeness script: [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #55342:
URL: https://github.com/apache/airflow/pull/55342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve check translation completeness script: [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #55342:
URL: https://github.com/apache/airflow/pull/55342#issuecomment-3263550802
<img width="356" height="391" alt="Screenshot 2025-09-07 at 09 15 13" src="https://github.com/user-attachments/assets/e0aba01e-c326-4adc-9c48-bf1663af6757" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve check translation completeness script: [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #55342:
URL: https://github.com/apache/airflow/pull/55342#issuecomment-3263616446
Merge for now - we can always change thresholds later :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org