You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by echarles <gi...@git.apache.org> on 2016/02/07 07:13:05 UTC
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
GitHub user echarles opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/702
R and SparkR Support [WIP]
### What is this PR for?
Implement R and SpakR Intepreter as part of the Spark Interpreter Group. It also implements R and Scala binding (in both directions).
### What type of PR is it?
[Feature]
### Todos
* [ ] - Documentation
* [ ] - Unit test (if relevant, as we depend on R being available on the host)
* [ ] - Assess licensing (a priori ok as we don't delive anything out of ASL2, but we should corectly phrase the NOTICE as we depend on non-ASL2 comptabile licenses (R) to run the interpreter).
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-156 SparkR support
### How should this be tested?
You need R available on the host running the notebook.
For Centos: yum install R R-devel
For Ubuntu: apt-get install r-base r-cran-rserve
Install additional R packages:
```
curl https://cran.r-project.org/src/contrib/Archive/rscala/rscala_1.0.6.tar.gz -o /tmp/rscala_1.0.6.tar.gz
R CMD INSTALL /tmp/rscala_1.0.6.tar.gz
R -e "install.packages('ggplot2', repos = 'http://cran.us.r-project.org')"
R -e install.packages('knitr', repos = 'http://cran.us.r-project.org')
```
- Build + launch Zeppelin and test the R note.
!!! you need rscala_1.0.6 (if not, you need to build with -Drscala.version=...)
### Screenshots (if appropriate)
#### Simple R
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/simple-r.png)
#### Plot
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/plot.png)
#### Scala R Binding
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/scala-r.png)
#### R Scala Binding
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/r-scala.png)
#### SparkR
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/sparkr.png)
### Questions:
* Does the licenses files need update? to be checked... (cfr R needs to be available to make this interpreter operational).
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/datalayer/zeppelin-R rscala-z
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #702
----
commit 363b2446fb01accee5e61e672e49cf152267b904
Author: Eric Charles <er...@datalayer.io>
Date: 2015-11-20T13:01:47Z
Add SparRInterpreter implementation
commit 9312a0ce109a8c73061ecef60cf7b3e1320368a2
Author: Eric Charles <er...@datalayer.io>
Date: 2016-02-07T05:44:30Z
Make rscala configurable in the spark-dependencies module
commit aa6a7a1ff9db48c999ef7c21465dd9a3d1c4d79a
Author: Eric Charles <er...@datalayer.io>
Date: 2016-02-07T05:58:23Z
Remove png files and restore README.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-198452586
@echarles
looks like this is ok now. returns an error as expected
```
%r
thisIsAnError
```
Still wondering why this shows "ERROR" in the paragraph result (the built in zeppelin error message in upper left of paragraph near play button)
```
%r
foo <- 1
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182632704
Ohh my god, those charts are very sexy!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by btiernay <gi...@git.apache.org>.
Github user btiernay commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-185176664
Also, it would be nice to support standard `%html`, `%table`, `%img` support as described here:
http://zeppelin-project.org/docs/display.html
Currently this is not possible because:
```R
print('%html hi!')
```
produces:
```
[1] “%html hi!”
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181199091
@echarles Looks like this PR was trying to just add support for SparkR package.
AFAIK this can be addressed #208 PR, can't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203227621
Huge thx @Leemoonsoo for digging into the interpreter list. I should have made it by myself, but running out of time atm... I have merged and travis shows now a green status.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by smartinsightsfromdata <gi...@git.apache.org>.
Github user smartinsightsfromdata commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181561671
@echarles @justsomeone1001 could you kindly clarify if **native visualization** refers to **Zeppelin visualisations** or R?
Visualisation is most relevant around data exploration and analytics results sharing (where notebooks make most sense). I think for R and Python users it would be good to know which visualisation will work out-of-the-box. It could help to decide which tool / interpreter / language to use:
1. Zeppelin native?
2. language native (e.g. R core graphics `plot` etc.)?
3. dedicated libraries (Python: matplotlib [w or w/o `%matplotlib inline` like jupyter?]; bokeh; R: ggplot2 etc.)
4. interactive visualization (R: htmlwidgets; relevant visualisations in Bokeh)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202757005
@jeffsteinmetz Thx for the review and inputs.
- I have pushed a fix that shows `Success`(upper right of the paragraph) when the returned output is just empty.
Regarding the list of interpreters in the setting page, I have investigated but not yet found a solution (just wonder if the issue is coming from this PR). Here are my findings which tend to show that registration of %r is correctly done:
SparkRInterpreter is correctly registered in the logs
REST call to the api correctly returns `spark.r`
However, the list in the interpreter page is not populated with %r...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-194109402
Right, `%r print("<h1>title</h1")` does not work at the time being. I didn't debug but I see what's going on and at first sight, it is not straightforward to make it work. I will try to apply some html encoding... and if it does not work, I will fallback to the `%text` magic keyword which btw is not supported atm.
One more good catch for the rscala jar in the shell script. The fix will be to add the folder to the classpath instead of the file.
2 actions points on my plate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202582736
I tested the build and distribution as follows:
`mvn clean package -Pspark-1.6 -Ppyspark -Phadoop-2.4 -Psparkr -DskipTests -Pbuild-distr`
The R samples are working.
I also tested setting SPARK_HOME to a spark distribution and it worked as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by justsomeone1001 <gi...@git.apache.org>.
Github user justsomeone1001 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182638534
@doanduyhai https://github.com/elbamos/Zeppelin-With-R
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-204759503
Looks like we are trying hit a moving target on master, specifcially with `.travis.yml`.
Is it possible for a committer to merge this soon after the branch conflicts are resolved (again) so that @echarles can take this off his plate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193870020
@jeffsteinmetz #lol is it really working for you? After the last merge with master, the r interpreter is no more taken in the settings... I am double checking this atm, but solution will wait tomorrow... but good to know it is ok at your side.
Good catch, `r-cran-rserve` is not needed at all - this is a copy paste from my initial implementation based on rserve which is now swapped to rscala (rserve license is not compatible with asl2). I will update the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181417475
@Leemoonsoo
- rscala is now downloaded at build time
- bin_license updated
- Unit test added
- spark-1.3, spark-1.2, spark-1.1 should now build with maven machinery
@justsomeone1001
- This PR support visualization.
- I have added a very first inistial documentation to help the setup.
@hsaputra
- Once you get SparR, you have R (just like PySpark, you get Python)
- I have opened this PR to take into acocunt with my comments on #208 PR (see [1] and [2])
[1] http://mail-archives.apache.org/mod_mbox/incubator-zeppelin-dev/201512.mbox/%3C5683E471.9010001%40apache.org%3E
[2] https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-170337289
Thx for your comments so far and looking what Travis will tell...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-204641032
Back to green after simple build retrigger.
LGTM for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193902973
Never tried `IRkernel/repr` nor `Base64enc`...
The process would be :
- Install them
- Try to generate a plot / image
- Report result (Curious to see the result and happy to develop a fix if they don't work fine).
For RChart and GoogleViz visualizations:
```
install.packages(c('devtools','mplot', 'googleVis')
```
and
```
require(devtools)
install_github('rCharts', 'ramnathv')
```
Oh, CI is green with (from https://s3.amazonaws.com/archive.travis-ci.org/jobs/114569249/log.txt)
```
Running org.apache.zeppelin.spark.SparkRInterpreterTest
...
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.406 sec - in org.apache.zeppelin.spark.SparkRInterpreterTest
```
I will take a picture of this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-205554908
@jeffsteinmetz thank you for kind notice! I think it has been reviewed by PPMC already but I'll be glad to make a final pass today and post back the results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202168397
@echarles Thanks for taking a look https://github.com/datalayer/zeppelin-datalayer/pull/7.
I have tested latest commit and it works well for me. Also i have verified RInterpreter working with binary package generated by -Pbuild-distr flag.
Wait for @jeffsteinmetz provides additional review.
Meanwhile, how about taking care of (b) and (c) in separate PR ?
While basic R interpreter functionality is working and tests are ready, i think we can merge it and improvements like (b), (c) as well as implementing getProgress(), and cancel() can be done in separate PR. So more people can get involved.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by elbamos <gi...@git.apache.org>.
Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202179412
Nothing in what you just said is truthful. If you think what you are attempting to do is anything but the opposite of what the community consensus was in that thread, you are very mistaken.
I have zero interest in debating this with you.
So, this is a simple yes or no question: Will you abandon this course of action, or do we have to take it back to *another* round on the developers' list?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by "Amos B. Elberg" <am...@gmail.com>.
Moon, your references to the "apache way" are laughable. As you yourself showed, what's broken is CI, not the PR. You've committed numerous PRs that broke CI. Dozens of them, if not hundreds.
The person who insisted on CI working is not you -- you said you would merge 208 without CI -- it was me! You even insisted on releasing 0.5.6 before CI was fixed, over my objection.
You committed in December to fix CI. After 10 weeks, you had established that I was right, but did nothing else.
@bzz looked at it also. He also established that I was right. After 6 weeks, he wrote part of a test script that copied some of the dependencies.
But then he stopped--when you declared that 702 had to be merged at the same time as 208, even though the community had rejected it.
So stop pointing to CI -- the fault here is yours and yours alone.
> On Mar 18, 2016, at 12:57 AM, moon soo Lee <mo...@apache.org> wrote:
>
> Community will is probably having R interpreter. That's why roadmap page
> have R interpreter from the beginning, right?
>
> Community will is also probably not merging code that breaks test, right?
> That's why we have CI facility and many community member put huge effort on
> it. And that's how we make high quality software, which is considered as
> one of philosophy of Apache way. [1]
>
> If you think 208 is ready for merge, even though it's breaking test, please
> describe technical reason that you think, not accusing someone.
>
> Thanks,
> moon
>
> [1] http://www.apache.org/foundation/how-it-works.html#philosophy
>
>
> On Thu, Mar 17, 2016 at 8:22 PM Amos B. Elberg <am...@gmail.com>
> wrote:
>
>> Moon - 208 has been ready for merge for six months.
>>
>> The reason it hasn't been merged is exclusively you--against the will of
>> the community.
>>
>>> On Mar 17, 2016, at 10:34 PM, moon soo Lee <mo...@apache.org> wrote:
>>>
>>> Amos,
>>>
>>> No one blocks you working on 208 and no one said we're not merging 208
>> when
>>> it's ready. So please stop accusing community member regarding progress
>> of
>>> 208.
>>>
>>> More important thing i think you need to care is "Collaboration".
>>> You don't need to worry about 702. Alternative implementation is not the
>>> one you need to compete, devaluate and win, but the one you need to
>>> collaborate, help and learn.
>>>
>>> You probably heard about "Community over code" [1]. and that exemplifies
>>> Apache project. if you can show your ability to collaborate in the
>>> community, that proves many more thing in addition to your code.
>>>
>>> Clearly accusing, devaluating someone else's work is not the way Apache
>>> works. Please take one step back and look around you. Are people coming
>> to
>>> help you or are people scare away from you? Please think carefully about
>>> what's the best way of spending your precious time.
>>>
>>> Thanks,
>>> moom
>>>
>>> [1] http://theapacheway.com/
>>>
>>>
>>> On Thu, Mar 17, 2016 at 2:09 PM Amos B. Elberg <am...@gmail.com>
>>> wrote:
>>>
>>>> Moon - No-one in the community supported your refusal to fix CI. No-one
>>>> supported your license theory, but you refused to abandon it until two
>>>> mentors told you you were wrong. No-one supported your demand that 208
>> not
>>>> be merged without 702.
>>>>
>>>> 208 has waiting action on your part or your employees -- with all tasks
>>>> that were my responsibility complete -- since September. So don't point
>> the
>>>> finger-this is your train wreck and yours alone.
>>>>
>>>> Your approach has been to create obstacles; when the community goes
>>>> against you, you promise to act; but then you do nothing; and when time
>>>> passes and I complain that nothing has happened, you create another
>>>> obstacle and complain that I said something mean to you.
>>>>
>>>> That is not the Apache way. It also not honest.
>>>>
>>>>> On Mar 17, 2016, at 4:51 PM, moon soo Lee <mo...@apache.org> wrote:
>>>>>
>>>>> Amos,
>>>>>
>>>>> You seems always end up with personal attack and accuse someone when
>> you
>>>>> don't have reasonable answer. Your strategy is recognized well enough.
>>>>>
>>>>> But, please understand that your strategy will never work in this
>>>>> community. Moreover your strategy is very much against the 'Apache
>> way'.
>>>>>
>>>>> So, how about you try 'Apache way' this time?
>>>>> That's the best way to get involved in this community and fastest way
>> to
>>>>> get what you want. Also it is more comfortable way which good for
>> health
>>>> of
>>>>> everyone subscribing this mailing list :-)
>>>>>
>>>>> Everyone in this community will support you if you decided to change
>> your
>>>>> strategy to 'Apache way'. Let me know if you need any help.
>>>>>
>>>>> Thanks,
>>>>> moon
>>>>>
>>>>> On Thu, Mar 17, 2016 at 12:42 PM Amos B. Elberg <amos.elberg@gmail.com
>>>
>>>>> wrote:
>>>>>
>>>>>> Moon, youve been impeding 208 since Felix asked you to. Your sudden
>>>>>> recent interest in 702 is just more of the same.
>>>>>>
>>>>>> Your conduct has been obstructive and dishonest, and you've been
>>>> thwarting
>>>>>> the will of the community for months.
>>>>>>
>>>>>>> On Mar 17, 2016, at 3:35 PM, moon soo Lee <mo...@apache.org> wrote:
>>>>>>>
>>>>>>> Amos,
>>>>>>>
>>>>>>> I had volunteered help fixing CI of 208. Hope you're able to
>>>> distinguish
>>>>>>> 'wiling to help' and 'committed to do something'.
>>>>>>>
>>>>>>> Please remember, everyone in this community are volunteers and no one
>>>>>>> paid/committed to work on 208.
>>>>>>>
>>>>>>> I think you have some misunderstanding of philosophy of Apache
>> project.
>>>>>>> Please read following links carefully before you trying to prevent
>>>>>>> community member involving 702 any further.
>>>>>>>
>>>>>>> http://www.apache.org/foundation/how-it-works.html#philosophy
>>>>>>> http://www.apache.org/foundation/policies/conduct.html
>>>>>>>
>>>>>>> Hope those links helps change your point of view to Apache project,
>>>>>>> especially for concept of collaborative, open and respectful.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> moon
>>>>>>>
>>>>>>> On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <
>> amos.elberg@gmail.com
>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Moon you committed in December to fix CI and merge 208. In February,
>>>>>>>> having broken your promise, you committed to stay out of it.
>>>>>>>>
>>>>>>>> PPMC review has been *complete* since Dexember.
>>>>>>>>
>>>>>>>> Your lack of integrity is truly astounding.
>>>>>>>>
>>>>>>>> If you will not honor your commitment to stay out voluntarily, then
>>>>>>>> perhaps we need to begin a community discussion about your level of
>>>>>>>> involvement.
>>>>>>>
>>>>>>>
>>>>>>>>> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
>>>>>>>>>
>>>>>>>>> Amos,
>>>>>>>>>
>>>>>>>>> There're no such commitment. I wanted to stay out because of it was
>>>> too
>>>>>>>>> noisy. but i can always be involved if i want.
>>>>>>>>>
>>>>>>>>> You're not trying to interrupt PPMC reviewing contribution, right?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> moon
>>>>>>>>>
>>>>>>>>> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <
>>>> amos.elberg@gmail.com
>>>>>>>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Moon - you committed to stay out of these issues. If you're going
>> to
>>>>>> be
>>>>>>>>>> involved at all, you should start by honoring the commitments you
>>>> made
>>>>>>>> in
>>>>>>>>>> the past.
>>>>>>>>>>
>>>>>>>>>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org>
>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Github user Leemoonsoo commented on the pull request:
>> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
>>>>>>>>>>>
>>>>>>>>>>> @echarles Can there be one integration test such as
>> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
>>>>>>>>>> ?
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> ---
>>>>>>>>>>> If your project is set up for it, you can reply to this email and
>>>>>> have
>>>>>>>>>> your
>>>>>>>>>>> reply appear on GitHub as well. If your project does not have
>> this
>>>>>>>>>> feature
>>>>>>>>>>> enabled and wishes so, or if the feature is enabled but not
>>>> working,
>>>>>>>>>> please
>>>>>>>>>>> contact infrastructure at infrastructure@apache.org or file a
>> JIRA
>>>>>>>>>> ticket
>>>>>>>>>>> with INFRA.
>>>>>>>>>>> ---
>>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by moon soo Lee <mo...@apache.org>.
Community will is probably having R interpreter. That's why roadmap page
have R interpreter from the beginning, right?
Community will is also probably not merging code that breaks test, right?
That's why we have CI facility and many community member put huge effort on
it. And that's how we make high quality software, which is considered as
one of philosophy of Apache way. [1]
If you think 208 is ready for merge, even though it's breaking test, please
describe technical reason that you think, not accusing someone.
Thanks,
moon
[1] http://www.apache.org/foundation/how-it-works.html#philosophy
On Thu, Mar 17, 2016 at 8:22 PM Amos B. Elberg <am...@gmail.com>
wrote:
> Moon - 208 has been ready for merge for six months.
>
> The reason it hasn't been merged is exclusively you--against the will of
> the community.
>
> > On Mar 17, 2016, at 10:34 PM, moon soo Lee <mo...@apache.org> wrote:
> >
> > Amos,
> >
> > No one blocks you working on 208 and no one said we're not merging 208
> when
> > it's ready. So please stop accusing community member regarding progress
> of
> > 208.
> >
> > More important thing i think you need to care is "Collaboration".
> > You don't need to worry about 702. Alternative implementation is not the
> > one you need to compete, devaluate and win, but the one you need to
> > collaborate, help and learn.
> >
> > You probably heard about "Community over code" [1]. and that exemplifies
> > Apache project. if you can show your ability to collaborate in the
> > community, that proves many more thing in addition to your code.
> >
> > Clearly accusing, devaluating someone else's work is not the way Apache
> > works. Please take one step back and look around you. Are people coming
> to
> > help you or are people scare away from you? Please think carefully about
> > what's the best way of spending your precious time.
> >
> > Thanks,
> > moom
> >
> > [1] http://theapacheway.com/
> >
> >
> > On Thu, Mar 17, 2016 at 2:09 PM Amos B. Elberg <am...@gmail.com>
> > wrote:
> >
> >> Moon - No-one in the community supported your refusal to fix CI. No-one
> >> supported your license theory, but you refused to abandon it until two
> >> mentors told you you were wrong. No-one supported your demand that 208
> not
> >> be merged without 702.
> >>
> >> 208 has waiting action on your part or your employees -- with all tasks
> >> that were my responsibility complete -- since September. So don't point
> the
> >> finger-this is your train wreck and yours alone.
> >>
> >> Your approach has been to create obstacles; when the community goes
> >> against you, you promise to act; but then you do nothing; and when time
> >> passes and I complain that nothing has happened, you create another
> >> obstacle and complain that I said something mean to you.
> >>
> >> That is not the Apache way. It also not honest.
> >>
> >>> On Mar 17, 2016, at 4:51 PM, moon soo Lee <mo...@apache.org> wrote:
> >>>
> >>> Amos,
> >>>
> >>> You seems always end up with personal attack and accuse someone when
> you
> >>> don't have reasonable answer. Your strategy is recognized well enough.
> >>>
> >>> But, please understand that your strategy will never work in this
> >>> community. Moreover your strategy is very much against the 'Apache
> way'.
> >>>
> >>> So, how about you try 'Apache way' this time?
> >>> That's the best way to get involved in this community and fastest way
> to
> >>> get what you want. Also it is more comfortable way which good for
> health
> >> of
> >>> everyone subscribing this mailing list :-)
> >>>
> >>> Everyone in this community will support you if you decided to change
> your
> >>> strategy to 'Apache way'. Let me know if you need any help.
> >>>
> >>> Thanks,
> >>> moon
> >>>
> >>> On Thu, Mar 17, 2016 at 12:42 PM Amos B. Elberg <amos.elberg@gmail.com
> >
> >>> wrote:
> >>>
> >>>> Moon, youve been impeding 208 since Felix asked you to. Your sudden
> >>>> recent interest in 702 is just more of the same.
> >>>>
> >>>> Your conduct has been obstructive and dishonest, and you've been
> >> thwarting
> >>>> the will of the community for months.
> >>>>
> >>>>> On Mar 17, 2016, at 3:35 PM, moon soo Lee <mo...@apache.org> wrote:
> >>>>>
> >>>>> Amos,
> >>>>>
> >>>>> I had volunteered help fixing CI of 208. Hope you're able to
> >> distinguish
> >>>>> 'wiling to help' and 'committed to do something'.
> >>>>>
> >>>>> Please remember, everyone in this community are volunteers and no one
> >>>>> paid/committed to work on 208.
> >>>>>
> >>>>> I think you have some misunderstanding of philosophy of Apache
> project.
> >>>>> Please read following links carefully before you trying to prevent
> >>>>> community member involving 702 any further.
> >>>>>
> >>>>> http://www.apache.org/foundation/how-it-works.html#philosophy
> >>>>> http://www.apache.org/foundation/policies/conduct.html
> >>>>>
> >>>>> Hope those links helps change your point of view to Apache project,
> >>>>> especially for concept of collaborative, open and respectful.
> >>>>>
> >>>>> Thanks,
> >>>>> moon
> >>>>>
> >>>>> On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <
> amos.elberg@gmail.com
> >>>
> >>>>> wrote:
> >>>>>
> >>>>>> Moon you committed in December to fix CI and merge 208. In February,
> >>>>>> having broken your promise, you committed to stay out of it.
> >>>>>>
> >>>>>> PPMC review has been *complete* since Dexember.
> >>>>>>
> >>>>>> Your lack of integrity is truly astounding.
> >>>>>>
> >>>>>> If you will not honor your commitment to stay out voluntarily, then
> >>>>>> perhaps we need to begin a community discussion about your level of
> >>>>>> involvement.
> >>>>>
> >>>>>
> >>>>>>> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
> >>>>>>>
> >>>>>>> Amos,
> >>>>>>>
> >>>>>>> There're no such commitment. I wanted to stay out because of it was
> >> too
> >>>>>>> noisy. but i can always be involved if i want.
> >>>>>>>
> >>>>>>> You're not trying to interrupt PPMC reviewing contribution, right?
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> moon
> >>>>>>>
> >>>>>>> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <
> >> amos.elberg@gmail.com
> >>>>>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> Moon - you committed to stay out of these issues. If you're going
> to
> >>>> be
> >>>>>>>> involved at all, you should start by honoring the commitments you
> >> made
> >>>>>> in
> >>>>>>>> the past.
> >>>>>>>>
> >>>>>>>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org>
> >> wrote:
> >>>>>>>>>
> >>>>>>>>> Github user Leemoonsoo commented on the pull request:
> >>>>
> >>
> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
> >>>>>>>>>
> >>>>>>>>> @echarles Can there be one integration test such as
> >>>>
> >>
> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
> >>>>>>>> ?
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> ---
> >>>>>>>>> If your project is set up for it, you can reply to this email and
> >>>> have
> >>>>>>>> your
> >>>>>>>>> reply appear on GitHub as well. If your project does not have
> this
> >>>>>>>> feature
> >>>>>>>>> enabled and wishes so, or if the feature is enabled but not
> >> working,
> >>>>>>>> please
> >>>>>>>>> contact infrastructure at infrastructure@apache.org or file a
> JIRA
> >>>>>>>> ticket
> >>>>>>>>> with INFRA.
> >>>>>>>>> ---
> >>>>
> >>
>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by "Amos B. Elberg" <am...@gmail.com>.
Moon - 208 has been ready for merge for six months.
The reason it hasn't been merged is exclusively you--against the will of the community.
> On Mar 17, 2016, at 10:34 PM, moon soo Lee <mo...@apache.org> wrote:
>
> Amos,
>
> No one blocks you working on 208 and no one said we're not merging 208 when
> it's ready. So please stop accusing community member regarding progress of
> 208.
>
> More important thing i think you need to care is "Collaboration".
> You don't need to worry about 702. Alternative implementation is not the
> one you need to compete, devaluate and win, but the one you need to
> collaborate, help and learn.
>
> You probably heard about "Community over code" [1]. and that exemplifies
> Apache project. if you can show your ability to collaborate in the
> community, that proves many more thing in addition to your code.
>
> Clearly accusing, devaluating someone else's work is not the way Apache
> works. Please take one step back and look around you. Are people coming to
> help you or are people scare away from you? Please think carefully about
> what's the best way of spending your precious time.
>
> Thanks,
> moom
>
> [1] http://theapacheway.com/
>
>
> On Thu, Mar 17, 2016 at 2:09 PM Amos B. Elberg <am...@gmail.com>
> wrote:
>
>> Moon - No-one in the community supported your refusal to fix CI. No-one
>> supported your license theory, but you refused to abandon it until two
>> mentors told you you were wrong. No-one supported your demand that 208 not
>> be merged without 702.
>>
>> 208 has waiting action on your part or your employees -- with all tasks
>> that were my responsibility complete -- since September. So don't point the
>> finger-this is your train wreck and yours alone.
>>
>> Your approach has been to create obstacles; when the community goes
>> against you, you promise to act; but then you do nothing; and when time
>> passes and I complain that nothing has happened, you create another
>> obstacle and complain that I said something mean to you.
>>
>> That is not the Apache way. It also not honest.
>>
>>> On Mar 17, 2016, at 4:51 PM, moon soo Lee <mo...@apache.org> wrote:
>>>
>>> Amos,
>>>
>>> You seems always end up with personal attack and accuse someone when you
>>> don't have reasonable answer. Your strategy is recognized well enough.
>>>
>>> But, please understand that your strategy will never work in this
>>> community. Moreover your strategy is very much against the 'Apache way'.
>>>
>>> So, how about you try 'Apache way' this time?
>>> That's the best way to get involved in this community and fastest way to
>>> get what you want. Also it is more comfortable way which good for health
>> of
>>> everyone subscribing this mailing list :-)
>>>
>>> Everyone in this community will support you if you decided to change your
>>> strategy to 'Apache way'. Let me know if you need any help.
>>>
>>> Thanks,
>>> moon
>>>
>>> On Thu, Mar 17, 2016 at 12:42 PM Amos B. Elberg <am...@gmail.com>
>>> wrote:
>>>
>>>> Moon, youve been impeding 208 since Felix asked you to. Your sudden
>>>> recent interest in 702 is just more of the same.
>>>>
>>>> Your conduct has been obstructive and dishonest, and you've been
>> thwarting
>>>> the will of the community for months.
>>>>
>>>>> On Mar 17, 2016, at 3:35 PM, moon soo Lee <mo...@apache.org> wrote:
>>>>>
>>>>> Amos,
>>>>>
>>>>> I had volunteered help fixing CI of 208. Hope you're able to
>> distinguish
>>>>> 'wiling to help' and 'committed to do something'.
>>>>>
>>>>> Please remember, everyone in this community are volunteers and no one
>>>>> paid/committed to work on 208.
>>>>>
>>>>> I think you have some misunderstanding of philosophy of Apache project.
>>>>> Please read following links carefully before you trying to prevent
>>>>> community member involving 702 any further.
>>>>>
>>>>> http://www.apache.org/foundation/how-it-works.html#philosophy
>>>>> http://www.apache.org/foundation/policies/conduct.html
>>>>>
>>>>> Hope those links helps change your point of view to Apache project,
>>>>> especially for concept of collaborative, open and respectful.
>>>>>
>>>>> Thanks,
>>>>> moon
>>>>>
>>>>> On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <amos.elberg@gmail.com
>>>
>>>>> wrote:
>>>>>
>>>>>> Moon you committed in December to fix CI and merge 208. In February,
>>>>>> having broken your promise, you committed to stay out of it.
>>>>>>
>>>>>> PPMC review has been *complete* since Dexember.
>>>>>>
>>>>>> Your lack of integrity is truly astounding.
>>>>>>
>>>>>> If you will not honor your commitment to stay out voluntarily, then
>>>>>> perhaps we need to begin a community discussion about your level of
>>>>>> involvement.
>>>>>
>>>>>
>>>>>>> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
>>>>>>>
>>>>>>> Amos,
>>>>>>>
>>>>>>> There're no such commitment. I wanted to stay out because of it was
>> too
>>>>>>> noisy. but i can always be involved if i want.
>>>>>>>
>>>>>>> You're not trying to interrupt PPMC reviewing contribution, right?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> moon
>>>>>>>
>>>>>>> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <
>> amos.elberg@gmail.com
>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Moon - you committed to stay out of these issues. If you're going to
>>>> be
>>>>>>>> involved at all, you should start by honoring the commitments you
>> made
>>>>>> in
>>>>>>>> the past.
>>>>>>>>
>>>>>>>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org>
>> wrote:
>>>>>>>>>
>>>>>>>>> Github user Leemoonsoo commented on the pull request:
>>>>
>> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
>>>>>>>>>
>>>>>>>>> @echarles Can there be one integration test such as
>>>>
>> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
>>>>>>>> ?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---
>>>>>>>>> If your project is set up for it, you can reply to this email and
>>>> have
>>>>>>>> your
>>>>>>>>> reply appear on GitHub as well. If your project does not have this
>>>>>>>> feature
>>>>>>>>> enabled and wishes so, or if the feature is enabled but not
>> working,
>>>>>>>> please
>>>>>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>>>>> ticket
>>>>>>>>> with INFRA.
>>>>>>>>> ---
>>>>
>>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by moon soo Lee <mo...@apache.org>.
Amos,
No one blocks you working on 208 and no one said we're not merging 208 when
it's ready. So please stop accusing community member regarding progress of
208.
More important thing i think you need to care is "Collaboration".
You don't need to worry about 702. Alternative implementation is not the
one you need to compete, devaluate and win, but the one you need to
collaborate, help and learn.
You probably heard about "Community over code" [1]. and that exemplifies
Apache project. if you can show your ability to collaborate in the
community, that proves many more thing in addition to your code.
Clearly accusing, devaluating someone else's work is not the way Apache
works. Please take one step back and look around you. Are people coming to
help you or are people scare away from you? Please think carefully about
what's the best way of spending your precious time.
Thanks,
moom
[1] http://theapacheway.com/
On Thu, Mar 17, 2016 at 2:09 PM Amos B. Elberg <am...@gmail.com>
wrote:
> Moon - No-one in the community supported your refusal to fix CI. No-one
> supported your license theory, but you refused to abandon it until two
> mentors told you you were wrong. No-one supported your demand that 208 not
> be merged without 702.
>
> 208 has waiting action on your part or your employees -- with all tasks
> that were my responsibility complete -- since September. So don't point the
> finger-this is your train wreck and yours alone.
>
> Your approach has been to create obstacles; when the community goes
> against you, you promise to act; but then you do nothing; and when time
> passes and I complain that nothing has happened, you create another
> obstacle and complain that I said something mean to you.
>
> That is not the Apache way. It also not honest.
>
> > On Mar 17, 2016, at 4:51 PM, moon soo Lee <mo...@apache.org> wrote:
> >
> > Amos,
> >
> > You seems always end up with personal attack and accuse someone when you
> > don't have reasonable answer. Your strategy is recognized well enough.
> >
> > But, please understand that your strategy will never work in this
> > community. Moreover your strategy is very much against the 'Apache way'.
> >
> > So, how about you try 'Apache way' this time?
> > That's the best way to get involved in this community and fastest way to
> > get what you want. Also it is more comfortable way which good for health
> of
> > everyone subscribing this mailing list :-)
> >
> > Everyone in this community will support you if you decided to change your
> > strategy to 'Apache way'. Let me know if you need any help.
> >
> > Thanks,
> > moon
> >
> > On Thu, Mar 17, 2016 at 12:42 PM Amos B. Elberg <am...@gmail.com>
> > wrote:
> >
> >> Moon, youve been impeding 208 since Felix asked you to. Your sudden
> >> recent interest in 702 is just more of the same.
> >>
> >> Your conduct has been obstructive and dishonest, and you've been
> thwarting
> >> the will of the community for months.
> >>
> >>> On Mar 17, 2016, at 3:35 PM, moon soo Lee <mo...@apache.org> wrote:
> >>>
> >>> Amos,
> >>>
> >>> I had volunteered help fixing CI of 208. Hope you're able to
> distinguish
> >>> 'wiling to help' and 'committed to do something'.
> >>>
> >>> Please remember, everyone in this community are volunteers and no one
> >>> paid/committed to work on 208.
> >>>
> >>> I think you have some misunderstanding of philosophy of Apache project.
> >>> Please read following links carefully before you trying to prevent
> >>> community member involving 702 any further.
> >>>
> >>> http://www.apache.org/foundation/how-it-works.html#philosophy
> >>> http://www.apache.org/foundation/policies/conduct.html
> >>>
> >>> Hope those links helps change your point of view to Apache project,
> >>> especially for concept of collaborative, open and respectful.
> >>>
> >>> Thanks,
> >>> moon
> >>>
> >>> On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <amos.elberg@gmail.com
> >
> >>> wrote:
> >>>
> >>>> Moon you committed in December to fix CI and merge 208. In February,
> >>>> having broken your promise, you committed to stay out of it.
> >>>>
> >>>> PPMC review has been *complete* since Dexember.
> >>>>
> >>>> Your lack of integrity is truly astounding.
> >>>>
> >>>> If you will not honor your commitment to stay out voluntarily, then
> >>>> perhaps we need to begin a community discussion about your level of
> >>>> involvement.
> >>>
> >>>
> >>>>> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
> >>>>>
> >>>>> Amos,
> >>>>>
> >>>>> There're no such commitment. I wanted to stay out because of it was
> too
> >>>>> noisy. but i can always be involved if i want.
> >>>>>
> >>>>> You're not trying to interrupt PPMC reviewing contribution, right?
> >>>>>
> >>>>> Thanks,
> >>>>> moon
> >>>>>
> >>>>> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <
> amos.elberg@gmail.com
> >>>
> >>>>> wrote:
> >>>>>
> >>>>>> Moon - you committed to stay out of these issues. If you're going to
> >> be
> >>>>>> involved at all, you should start by honoring the commitments you
> made
> >>>> in
> >>>>>> the past.
> >>>>>>
> >>>>>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org>
> wrote:
> >>>>>>>
> >>>>>>> Github user Leemoonsoo commented on the pull request:
> >>
> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
> >>>>>>>
> >>>>>>> @echarles Can there be one integration test such as
> >>
> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
> >>>>>> ?
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> ---
> >>>>>>> If your project is set up for it, you can reply to this email and
> >> have
> >>>>>> your
> >>>>>>> reply appear on GitHub as well. If your project does not have this
> >>>>>> feature
> >>>>>>> enabled and wishes so, or if the feature is enabled but not
> working,
> >>>>>> please
> >>>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
> >>>>>> ticket
> >>>>>>> with INFRA.
> >>>>>>> ---
> >>
>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by "Amos B. Elberg" <am...@gmail.com>.
Moon - No-one in the community supported your refusal to fix CI. No-one supported your license theory, but you refused to abandon it until two mentors told you you were wrong. No-one supported your demand that 208 not be merged without 702.
208 has waiting action on your part or your employees -- with all tasks that were my responsibility complete -- since September. So don't point the finger-this is your train wreck and yours alone.
Your approach has been to create obstacles; when the community goes against you, you promise to act; but then you do nothing; and when time passes and I complain that nothing has happened, you create another obstacle and complain that I said something mean to you.
That is not the Apache way. It also not honest.
> On Mar 17, 2016, at 4:51 PM, moon soo Lee <mo...@apache.org> wrote:
>
> Amos,
>
> You seems always end up with personal attack and accuse someone when you
> don't have reasonable answer. Your strategy is recognized well enough.
>
> But, please understand that your strategy will never work in this
> community. Moreover your strategy is very much against the 'Apache way'.
>
> So, how about you try 'Apache way' this time?
> That's the best way to get involved in this community and fastest way to
> get what you want. Also it is more comfortable way which good for health of
> everyone subscribing this mailing list :-)
>
> Everyone in this community will support you if you decided to change your
> strategy to 'Apache way'. Let me know if you need any help.
>
> Thanks,
> moon
>
> On Thu, Mar 17, 2016 at 12:42 PM Amos B. Elberg <am...@gmail.com>
> wrote:
>
>> Moon, youve been impeding 208 since Felix asked you to. Your sudden
>> recent interest in 702 is just more of the same.
>>
>> Your conduct has been obstructive and dishonest, and you've been thwarting
>> the will of the community for months.
>>
>>> On Mar 17, 2016, at 3:35 PM, moon soo Lee <mo...@apache.org> wrote:
>>>
>>> Amos,
>>>
>>> I had volunteered help fixing CI of 208. Hope you're able to distinguish
>>> 'wiling to help' and 'committed to do something'.
>>>
>>> Please remember, everyone in this community are volunteers and no one
>>> paid/committed to work on 208.
>>>
>>> I think you have some misunderstanding of philosophy of Apache project.
>>> Please read following links carefully before you trying to prevent
>>> community member involving 702 any further.
>>>
>>> http://www.apache.org/foundation/how-it-works.html#philosophy
>>> http://www.apache.org/foundation/policies/conduct.html
>>>
>>> Hope those links helps change your point of view to Apache project,
>>> especially for concept of collaborative, open and respectful.
>>>
>>> Thanks,
>>> moon
>>>
>>> On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <am...@gmail.com>
>>> wrote:
>>>
>>>> Moon you committed in December to fix CI and merge 208. In February,
>>>> having broken your promise, you committed to stay out of it.
>>>>
>>>> PPMC review has been *complete* since Dexember.
>>>>
>>>> Your lack of integrity is truly astounding.
>>>>
>>>> If you will not honor your commitment to stay out voluntarily, then
>>>> perhaps we need to begin a community discussion about your level of
>>>> involvement.
>>>
>>>
>>>>> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
>>>>>
>>>>> Amos,
>>>>>
>>>>> There're no such commitment. I wanted to stay out because of it was too
>>>>> noisy. but i can always be involved if i want.
>>>>>
>>>>> You're not trying to interrupt PPMC reviewing contribution, right?
>>>>>
>>>>> Thanks,
>>>>> moon
>>>>>
>>>>> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <amos.elberg@gmail.com
>>>
>>>>> wrote:
>>>>>
>>>>>> Moon - you committed to stay out of these issues. If you're going to
>> be
>>>>>> involved at all, you should start by honoring the commitments you made
>>>> in
>>>>>> the past.
>>>>>>
>>>>>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org> wrote:
>>>>>>>
>>>>>>> Github user Leemoonsoo commented on the pull request:
>> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
>>>>>>>
>>>>>>> @echarles Can there be one integration test such as
>> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
>>>>>> ?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---
>>>>>>> If your project is set up for it, you can reply to this email and
>> have
>>>>>> your
>>>>>>> reply appear on GitHub as well. If your project does not have this
>>>>>> feature
>>>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>>>> please
>>>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>>> ticket
>>>>>>> with INFRA.
>>>>>>> ---
>>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by moon soo Lee <mo...@apache.org>.
Amos,
You seems always end up with personal attack and accuse someone when you
don't have reasonable answer. Your strategy is recognized well enough.
But, please understand that your strategy will never work in this
community. Moreover your strategy is very much against the 'Apache way'.
So, how about you try 'Apache way' this time?
That's the best way to get involved in this community and fastest way to
get what you want. Also it is more comfortable way which good for health of
everyone subscribing this mailing list :-)
Everyone in this community will support you if you decided to change your
strategy to 'Apache way'. Let me know if you need any help.
Thanks,
moon
On Thu, Mar 17, 2016 at 12:42 PM Amos B. Elberg <am...@gmail.com>
wrote:
> Moon, youve been impeding 208 since Felix asked you to. Your sudden
> recent interest in 702 is just more of the same.
>
> Your conduct has been obstructive and dishonest, and you've been thwarting
> the will of the community for months.
>
> > On Mar 17, 2016, at 3:35 PM, moon soo Lee <mo...@apache.org> wrote:
> >
> > Amos,
> >
> > I had volunteered help fixing CI of 208. Hope you're able to distinguish
> > 'wiling to help' and 'committed to do something'.
> >
> > Please remember, everyone in this community are volunteers and no one
> > paid/committed to work on 208.
> >
> > I think you have some misunderstanding of philosophy of Apache project.
> > Please read following links carefully before you trying to prevent
> > community member involving 702 any further.
> >
> > http://www.apache.org/foundation/how-it-works.html#philosophy
> > http://www.apache.org/foundation/policies/conduct.html
> >
> > Hope those links helps change your point of view to Apache project,
> > especially for concept of collaborative, open and respectful.
> >
> > Thanks,
> > moon
> >
> > On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <am...@gmail.com>
> > wrote:
> >
> >> Moon you committed in December to fix CI and merge 208. In February,
> >> having broken your promise, you committed to stay out of it.
> >>
> >> PPMC review has been *complete* since Dexember.
> >>
> >> Your lack of integrity is truly astounding.
> >>
> >> If you will not honor your commitment to stay out voluntarily, then
> >> perhaps we need to begin a community discussion about your level of
> >> involvement.
> >
> >
> >>> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
> >>>
> >>> Amos,
> >>>
> >>> There're no such commitment. I wanted to stay out because of it was too
> >>> noisy. but i can always be involved if i want.
> >>>
> >>> You're not trying to interrupt PPMC reviewing contribution, right?
> >>>
> >>> Thanks,
> >>> moon
> >>>
> >>> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <amos.elberg@gmail.com
> >
> >>> wrote:
> >>>
> >>>> Moon - you committed to stay out of these issues. If you're going to
> be
> >>>> involved at all, you should start by honoring the commitments you made
> >> in
> >>>> the past.
> >>>>
> >>>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org> wrote:
> >>>>>
> >>>>> Github user Leemoonsoo commented on the pull request:
> >>
> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
> >>>>>
> >>>>> @echarles Can there be one integration test such as
> >>
> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
> >>>> ?
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> ---
> >>>>> If your project is set up for it, you can reply to this email and
> have
> >>>> your
> >>>>> reply appear on GitHub as well. If your project does not have this
> >>>> feature
> >>>>> enabled and wishes so, or if the feature is enabled but not working,
> >>>> please
> >>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
> >>>> ticket
> >>>>> with INFRA.
> >>>>> ---
> >>
>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by "Amos B. Elberg" <am...@gmail.com>.
Moon, youve been impeding 208 since Felix asked you to. Your sudden recent interest in 702 is just more of the same.
Your conduct has been obstructive and dishonest, and you've been thwarting the will of the community for months.
> On Mar 17, 2016, at 3:35 PM, moon soo Lee <mo...@apache.org> wrote:
>
> Amos,
>
> I had volunteered help fixing CI of 208. Hope you're able to distinguish
> 'wiling to help' and 'committed to do something'.
>
> Please remember, everyone in this community are volunteers and no one
> paid/committed to work on 208.
>
> I think you have some misunderstanding of philosophy of Apache project.
> Please read following links carefully before you trying to prevent
> community member involving 702 any further.
>
> http://www.apache.org/foundation/how-it-works.html#philosophy
> http://www.apache.org/foundation/policies/conduct.html
>
> Hope those links helps change your point of view to Apache project,
> especially for concept of collaborative, open and respectful.
>
> Thanks,
> moon
>
> On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <am...@gmail.com>
> wrote:
>
>> Moon you committed in December to fix CI and merge 208. In February,
>> having broken your promise, you committed to stay out of it.
>>
>> PPMC review has been *complete* since Dexember.
>>
>> Your lack of integrity is truly astounding.
>>
>> If you will not honor your commitment to stay out voluntarily, then
>> perhaps we need to begin a community discussion about your level of
>> involvement.
>
>
>>> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
>>>
>>> Amos,
>>>
>>> There're no such commitment. I wanted to stay out because of it was too
>>> noisy. but i can always be involved if i want.
>>>
>>> You're not trying to interrupt PPMC reviewing contribution, right?
>>>
>>> Thanks,
>>> moon
>>>
>>> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <am...@gmail.com>
>>> wrote:
>>>
>>>> Moon - you committed to stay out of these issues. If you're going to be
>>>> involved at all, you should start by honoring the commitments you made
>> in
>>>> the past.
>>>>
>>>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org> wrote:
>>>>>
>>>>> Github user Leemoonsoo commented on the pull request:
>> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
>>>>>
>>>>> @echarles Can there be one integration test such as
>> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
>>>> ?
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ---
>>>>> If your project is set up for it, you can reply to this email and have
>>>> your
>>>>> reply appear on GitHub as well. If your project does not have this
>>>> feature
>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>> please
>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>> ticket
>>>>> with INFRA.
>>>>> ---
>>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by moon soo Lee <mo...@apache.org>.
Amos,
I had volunteered help fixing CI of 208. Hope you're able to distinguish
'wiling to help' and 'committed to do something'.
Please remember, everyone in this community are volunteers and no one
paid/committed to work on 208.
I think you have some misunderstanding of philosophy of Apache project.
Please read following links carefully before you trying to prevent
community member involving 702 any further.
http://www.apache.org/foundation/how-it-works.html#philosophy
http://www.apache.org/foundation/policies/conduct.html
Hope those links helps change your point of view to Apache project,
especially for concept of collaborative, open and respectful.
Thanks,
moon
On Thu, Mar 17, 2016 at 10:07 AM Amos B. Elberg <am...@gmail.com>
wrote:
> Moon you committed in December to fix CI and merge 208. In February,
> having broken your promise, you committed to stay out of it.
>
> PPMC review has been *complete* since Dexember.
>
> Your lack of integrity is truly astounding.
>
> If you will not honor your commitment to stay out voluntarily, then
> perhaps we need to begin a community discussion about your level of
> involvement.
> > On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
> >
> > Amos,
> >
> > There're no such commitment. I wanted to stay out because of it was too
> > noisy. but i can always be involved if i want.
> >
> > You're not trying to interrupt PPMC reviewing contribution, right?
> >
> > Thanks,
> > moon
> >
> > On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <am...@gmail.com>
> > wrote:
> >
> >> Moon - you committed to stay out of these issues. If you're going to be
> >> involved at all, you should start by honoring the commitments you made
> in
> >> the past.
> >>
> >>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org> wrote:
> >>>
> >>> Github user Leemoonsoo commented on the pull request:
> >>
> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
> >>>
> >>> @echarles Can there be one integration test such as
> >>
> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
> >> ?
> >>>
> >>>
> >>>
> >>>
> >>> ---
> >>> If your project is set up for it, you can reply to this email and have
> >> your
> >>> reply appear on GitHub as well. If your project does not have this
> >> feature
> >>> enabled and wishes so, or if the feature is enabled but not working,
> >> please
> >>> contact infrastructure at infrastructure@apache.org or file a JIRA
> >> ticket
> >>> with INFRA.
> >>> ---
> >>
>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by "Amos B. Elberg" <am...@gmail.com>.
Moon you committed in December to fix CI and merge 208. In February, having broken your promise, you committed to stay out of it.
PPMC review has been *complete* since Dexember.
Your lack of integrity is truly astounding.
If you will not honor your commitment to stay out voluntarily, then perhaps we need to begin a community discussion about your level of involvement.
> On Mar 17, 2016, at 2:48 AM, moon soo Lee <mo...@apache.org> wrote:
>
> Amos,
>
> There're no such commitment. I wanted to stay out because of it was too
> noisy. but i can always be involved if i want.
>
> You're not trying to interrupt PPMC reviewing contribution, right?
>
> Thanks,
> moon
>
> On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <am...@gmail.com>
> wrote:
>
>> Moon - you committed to stay out of these issues. If you're going to be
>> involved at all, you should start by honoring the commitments you made in
>> the past.
>>
>>> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org> wrote:
>>>
>>> Github user Leemoonsoo commented on the pull request:
>> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
>>>
>>> @echarles Can there be one integration test such as
>> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
>> ?
>>>
>>>
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and have
>> your
>>> reply appear on GitHub as well. If your project does not have this
>> feature
>>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>> ticket
>>> with INFRA.
>>> ---
>>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by moon soo Lee <mo...@apache.org>.
Amos,
There're no such commitment. I wanted to stay out because of it was too
noisy. but i can always be involved if i want.
You're not trying to interrupt PPMC reviewing contribution, right?
Thanks,
moon
On Wed, Mar 16, 2016 at 10:58 PM Amos B. Elberg <am...@gmail.com>
wrote:
> Moon - you committed to stay out of these issues. If you're going to be
> involved at all, you should start by honoring the commitments you made in
> the past.
>
> > On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org> wrote:
> >
> > Github user Leemoonsoo commented on the pull request:
> >
> >
> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
> >
> > @echarles Can there be one integration test such as
> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87
> ?
> >
> >
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by "Amos B. Elberg" <am...@gmail.com>.
Moon - you committed to stay out of these issues. If you're going to be involved at all, you should start by honoring the commitments you made in the past.
> On Mar 17, 2016, at 1:45 AM, Leemoonsoo <gi...@git.apache.org> wrote:
>
> Github user Leemoonsoo commented on the pull request:
>
> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
>
> @echarles Can there be one integration test such as https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87 ?
>
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-197717065
@echarles Can there be one integration test such as https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java#L87 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202180743
@Leemoonsoo and @echarles does this still make use of `-Drscala.version=1.0.6` in the build settings?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182836577
Last commit made the build successful for 4 the 5 profiles.
The failing one is https://s3.amazonaws.com/archive.travis-ci.org/jobs/108515221/log.txt which claims `BUILD SUCCESSFULL` at the bottom of the page, and after `The command "./testing/startSparkCluster.sh $SPARK_VER $HADOOP_VER" failed and exited with 127 during `. I guess this is not the committed code but rather travis stability giving this.
I have also opened https://issues.apache.org/jira/browse/ZEPPELIN-668 to get feedback on properties passing on paragraph run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by justsomeone1001 <gi...@git.apache.org>.
Github user justsomeone1001 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181147188
I guess this isn't part of the 72-hour moratorium...
@Leemoonsoo
**Rscala** Actually its not just that rscala *can* be downloaded at build time. It *will* be downloaded whenever the user updates their R package library. R data scientists users do quite regularly because the functionality is built into R. There is no way to prevent an updated rscala from being used in place of the rscala included with this code. (The issue is the R-side of the rscala library more than the java side, but that's beside the point.)
This has already created breakages: The author of rscala recently fixed a bug that affected Windows users. The new version broke Eric's implementation, which had to be refactored.
**Licenses** Regarding licenses --you are correct that rscala is available under BSD. I convinced the author to switch from GPL to BSD so it could be used in PR 208.
**Tests** You are astute to require unit tests. The reason this code is passing CI is that it isn't being tested *at all.* Neither R, nor the classes here, are ever executed.
Related to that: There's no code here to handle changes in the SparkInterpreter class, which has caused severe breakages in the spark-interpreter/R integration in the past. There's also no code in here to handle the common Zeppelin/Spark misconfigurations that are 99% of the user issues that arise when you add R to zeppelin; or to handle spark-related issues at all.
One reason for this is, surely, because Eric only added the integration a few weeks ago, after I pointed-out on the mailing list that the functionality was absent. Since Eric based his code on mine (which he is absolutely entitled to do), I'm pretty sure it will start to have the same issues if it ever develops a user base.
**Other** There are a slew of other issues here related to integration with the rest of Zeppelin, presentation of R in a manner that R-using data scientists will be familiar with, and allowing the full R functionality.
As just one example: it doesn't support R base-plotting, and I'm pretty sure it won't support interactive visualizations either.
I am not going to list all of those issues here now, when we're trying to resolve the issue of PR 208 -- which *does* handle all of them, and quite a few more. This is because I worked through them over the last six months in responding to requests and issues from users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181565303
2 failures on last build:
spark-1.3: ZeppelinIT.testSparkInterpreterDependencyLoading:229->AbstractZeppelinIT.waitForParagraph:66->AbstractZeppelinIT.pollingWait:92 » Timeout
spark-1.5 ZeppelinIT.testAngularDisplay:151 » NoSuchElement Unable to locate element: {"...
The good news is that the SparkR related build and test are ok for all profiles.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202179470
thank you for the collaboration @Leemoonsoo and @echarles . I will review and test the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-198455912
@echarles
Can you explain the addition of the `spark.home` and `spark.master` to the interpreter properties?
SPARK_HOME is set in the zeppelin config, and `master` is already part of the spark interpreter.
Also, try to add a new parameter to the spark interpreter via the web interface, it doesn't save (not sure if that is related to this PR specifically).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202187464
I think -Drscala.version is no longer necessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by btiernay <gi...@git.apache.org>.
Github user btiernay commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-187719246
@echarles This is great! Thanks for all your hard work. Very much appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-184609241
Last commit makes the build fail for profiles 1.6 (one at zeppelin-display, the other after having built all modules saying after `No output has been received in the last 10 minutes` - nothing related to the PR).
The other profiles are green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by "Amos B. Elberg" <am...@gmail.com>.
There is a community consensus against this PR, which has not been around in its current form for a fraction of the time that would be necessary to evaluate it.
> On Mar 30, 2016, at 10:42 AM, Leemoonsoo <gi...@git.apache.org> wrote:
>
> Github user Leemoonsoo commented on the pull request:
>
> https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203465720
>
> Appreciate @echarles for the R interpreter implementation and very open communication.
> And thanks @jeffsteinmetz for providing great review and verification.
>
> I have tested and confirming
> it works with default configuration (without SPARK_HOME defined),
> it works with SPARK_HOME defined,
> it works when binary distribution is generated with -Pbuild-distr flag.
>
> Looks good to me.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203465720
Appreciate @echarles for the R interpreter implementation and very open communication.
And thanks @jeffsteinmetz for providing great review and verification.
I have tested and confirming
it works with default configuration (without SPARK_HOME defined),
it works with SPARK_HOME defined,
it works when binary distribution is generated with -Pbuild-distr flag.
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181140583
Thanks for the contribution.
I think `spark/lib/rscala_2.10-1.0.6.jar` shouldn't be included in the source tree. Can this be downloaded on build time?
And `rscala_2.10-1.0.6.jar` looks like available on BSD license according to [here](https://cran.r-project.org/web/packages/rscala/index.html). Then, you'll need add license of the library into `zeppelin-distribution/src/bin_license/LICENSE`, and add [LICENSE](https://cran.r-project.org/web/packages/rscala/LICENSE) file under `zeppelin-distribution/src/bin_license/licenses` directory.
Most interpreters include at least one unittest or integration test. So I suggest have an test.
I think R interpreter related source file need to be excluded for profile spark-1.3, spark-1.2, spark-1.1, so CI doesn't fail for those profile. I think maven capable of doing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202179148
> It is not at all a surprise that you would propose to merge 702---a few hours after I asked for community involvement on another PR, where you objected.
False.
No one objected community involvement on PR https://github.com/apache/incubator-zeppelin/pull/789. In fact, I suggested you create discussion thread. And you seems you did. great job :smiley:
> At the moment, this PR has zero adoption. You made a major change in its architecture a day ago that no-one has had a chance to try out.
Adoption is not a requirement of code contribution. Most code contribution merges with 0 adoption.
> And it has zero tests --- because the CI issue still isn't solved, they've been replaced by tests that don't cover the PRs functionality and don't even test if it can connect to R or Spark.
This PR includes an integration test which verifies Zeppelin - RInterpreter - R - Spark cluster connection.
While CI is not green, i hope @echarles can trigger it again and see if it's passing.
> This is absolutely the opposite of the consensus the community has repeatedly reached about the R issue.
> Will you be abiding by the community's consensus or do we really need to start a seventh discussion about this on the mailing list?
I think this PR is not against community consensus. Please check this thread http://apache-zeppelin-incubating-dev-mailing-list.75694.x6.nabble.com/R-interpreter-in-Zeppelin-further-steps-tp6967.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-195196436
A few tests results:
this shouldn't return an error
```
%r
foo <- 1
```
expected
`> foo <- 1`
also
```
%r
thisIsAnError
# should return an error in output (returns no error information)
# > Error in eval(expr, envir, enclos) : object 'thisIsAnError' not found
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182639390
Those graphs in your repo are sexy too !
To be honest, I'm comparing them to the current graph options that exist in standard Zeppelin (I'm not talking about custom code to have custom graphs) and those showed by R interpreter are nice.
But I'm not qualified to judge about the quality of the R interpreter or whatsoever
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by elbamos <gi...@git.apache.org>.
Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-187786770
@echarles Its one thing for you to wait for me to identify the missing functionality in your PR for you to implement it. *Making up* that features are missing from mine, is another story.
If anyone, e.g., @btiernay has any serious question about whether this support is currently in 208, and has been in 208 all along, I'm happy to show them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-204289348
@echarles rebase with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202590457
This Virtual Machine PR https://github.com/apache/incubator-zeppelin/pull/751 has also been updated to support R and all libraries required for the examples found in the R tutorial notebook:
VM ready to merge if nothing else changes in PR 702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193883993
I guess knitr uses evaluate under the hood (https://cran.rstudio.com/web/packages/evaluate/index.html mentions it as reverse import and https://cran.rstudio.com/web/packages/knitr/index.html lists it in its imports).
I usually only installs knitr with `install.packages('knitr', repos = 'http://cran.us.r-project.org')` and all transitive dependencies of scope c("Depends", "Imports", "LinkingTo") (see https://stat.ethz.ch/R-manual/R-devel/library/utils/html/install.packages.html) are also installed.
So no need to install `evaluate` explicitly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193958943
I like that `print` handles the Zeppelin display system.
Curious if you have an idea regarding how to use print if we did want to view raw HTML or Javascript in the output, perhaps for debugging (not push it through the zeppelin display)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202964376
@Leemoonsoo : Do you know why `%r` is not showing up in the interpreter heading?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-200906016
@Leemoonsoo I have a list of comments and actions (mainly coming from @jeffsteinmetz) I had planned to work out this weekend. You PR comes to the point. I scrolled through.
- Good idea to reuse the rscala from the spark dist.
- I would prefer keeping the SparkRInterpreterTest with it PowerMock (to mock static) which does not need any R on the host and add indeed as you did an integration test which needs R on the host.
- I see you changed something for the SPARK_HOME which didn't work as @jeffsteinmetz pointer - will look this we.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-187781300
@elbamos just pulled the 208 patch, built and tested with "%r print("%html <h1>hello</h1>")". Got
```
"[1] "%html <h1>hello</h1>"
```
printed as result, which is not what the Display system is intented to show. It should show:
```
# Hello
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-205703035
Looks great to me. Let's merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by btiernay <gi...@git.apache.org>.
Github user btiernay commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-184983264
Curious if this PR supports form variables in R paragraphs. I tried with no luck. Would be a nice addition if not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-200852943
@echarles Hi I have made [Pullrequest to this branch](https://github.com/datalayer/zeppelin-datalayer/pull/7), please take a look and comment. Which removes rscala dependency and includes an integration test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193904967
I think we are in alignment, the VM script installs knitr, devtools, googleVis, rCharts.
I can add `mplot`
What does mplot give us? Is it required for your samples above?
I didn't include mplot and things seemed to work in your sample R notebook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by elbamos <gi...@git.apache.org>.
Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-187764059
@btiernay support for that has been in 208 all along...
> On Feb 23, 2016, at 9:27 AM, Bob Tiernay <no...@github.com> wrote:
>
> @echarles This is great! Thanks for all your hard work. Very much appreciated!
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181568340
@echarles @justsomeone1001 This PR supports ggplot2 and displaying R dataframe in native zeppelin widget
## ggplot2
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/plot.png)
## dataframe in native zeppelin widget
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/plot-interactive.png)
The best would be to start a thread on the Zeppelin development list to talk about further development and requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203283238
@jeffsteinmetz thx, just pushed a change to show the unlist example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193880300
does it require the `evaluate` R package?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-194359853
Throwing some idea out there - you may have other ideas.
It's nice how the interpreter does its best to guess that HTML or Javascript should be rendered.
For explicit rendering, what about
`z.R.[some explicit command]` like:
```
%r
a <- "<h1>Hello</h1>"
print(a)
z.R.show(a)
z.R.show(a, "html")
z.R.show(a, "angular")
z.R.console(a)
b <- "name\tsize\nfoo\t1\n"
# show the built in Zeppelin table display with table, graphs, etc
z.R.show(b, "table")
# current implementation still applies (maybe?)
print("%html <h1>Hello</h1>")
# console debugging ignores zeppelin display rules
z.R.console("%html <h1>Hello</h1>")
mtcars
```
Outputs:
`[1] <h1>Hello</h1>`
**Hello**
**Hello**
**Hello**
`<h1>Hello</h1>`
<table>
<tr><td>name</td><td>size</td></tr>
<tr><td>foo</td><td>1</td></tr>
</table>
**Hello**
`%html <h1>Hello</h1>`
```
mpg cyl disp hp drat wt qsec vs am gear carb
Mazda RX4 21.0 6 160.0 110 3.90 2.620 16.46 0 1 4 4
Mazda RX4 Wag 21.0 6 160.0 110 3.90 2.875 17.02 0 1 4 4
Datsun 710 22.8 4 108.0 93 3.85 2.320 18.61 1 1 4 1
Hornet 4 Drive 21.4 6 258.0 110 3.08 3.215 19.44 1 0 3 1
Hornet Sportabout 18.7 8 360.0 175 3.15 3.440 17.02 0 0 3 2
Valiant 18.1 6 225.0 105 2.76 3.460 20.22 1 0 3 1
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by justsomeone1001 <gi...@git.apache.org>.
Github user justsomeone1001 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181571398
@echarles You could simply have answered him "no, this PR doesn't support R visualizations."
I am disinclined to start a thread. I feel like by pointing out the features that your implementation is missing but are present in mine, I'm just helping you compete.
There isn't any benefit to the project from doing that, since what you've built is a subset of what's already in PR 208 and the revision on git.
As you know, there's a moratorium on discussions about PR 208, which is what you based this one on. I, for one, am happy for the break. Perhaps you could consider respecting the moratorium for a few days?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-205118755
Back to green.
Good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-183846468
Build is now green.
I am reorganizing my repos, and because github does not offer a way to change the repo/branch on a exisiting PR, I will close this one and reopen another one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193914591
Same answer for `mplot` as for `IRkernel/repr` or `Base64enc`.
We have to install and try (If you don't have time, I take note of them and will try later).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-201124666
@Leemoonsoo
https://github.com/datalayer/zeppelin-datalayer/pull/7 does appear to have cleaned up the interpreter attribute duplication of spark.master and spark.home.
I can test this again as @echarles merges
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193888764
Thank you, that makes sense, since knitr installs this, I will pull `evaluate` out of the VM script and retest end to end.
next question:
is the `IRkernel/repr` R package required (specifically so that plotting will work within this R interpreter?
is `Base64enc` required (specifically so that plotting will work within this R interpreter)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203122549
@jeffsteinmetz @echarles Created patch https://github.com/datalayer/zeppelin-datalayer/pull/8 for problem `%r` not showing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-187717158
@btiernay Just pushed the HTML, TABLE and IMG display support (the dynamic form is not yet fully operational).
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/r-display.png)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203256131
Just tested, works great. `%r` shows up in the header now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202583079
Should `%r` be added to the interpreter headers?
See the following attachments:
<img width="407" alt="mozilla_firefox" src="https://cloud.githubusercontent.com/assets/5488059/14090453/44342a1e-f4ef-11e5-8e63-c30011c0a9c9.png">
<img width="486" alt="mozilla_firefox_and_data_board_-_agile_board_-_jira" src="https://cloud.githubusercontent.com/assets/5488059/14090454/44801b72-f4ef-11e5-82a0-9f46cd3ef923.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-204327315
Thx @prabhjyotsingh for the hint. I have merged and there is no more conflict.
Travis failed for 1.1.1 profile (issue while downloading a jar), otherwise the other profiles are green. How can I retrigger the build without pushing nor closing/opening?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203046005
@jeffsteinmetz Let me take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203267658
@echarles I updated the R notebook tutorial with a minor improvement in this patch:
https://github.com/datalayer/zeppelin-datalayer/pull/9
I noticed passing variables between scala and R is working quite well.
I previously thought there was an issue passing a scala Array to R, but it was because the Array was being treated as a multi-dimensional list in R.
I updated the R tutorial notebook with a small addition of `unlist` to flatten the array to show the variable as a single list.
for example:
```
%spark
val a: Array[Double] = Array[Double](30.0, 20.0)
z.put("a", a)
%r
aa <- unlist(z.get("a"))
print(aa)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by justsomeone1001 <gi...@git.apache.org>.
Github user justsomeone1001 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181463479
@echarles It doesn't support base plotting. Do you have an example of code to show that it supports *interactive* visualizations? I believer it does not.
Regarding @hsaputra 's comment -- your comment on 208 was that you didn't think R supported needed to have functionality that is in 208 but is not in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-205477989
@asfgit or @bzz How do you feel about merging this?
I see it's been 5 days since lazy consensus.
The recent changes have been to keep up with Master merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203538247
Looks great.
I just fired up a spark cluster on EC2 using the spark Amazon ec2 scripts.
Pointed zeppelin to the cluster master running 3 nodes.
Built the zeppelin distribution with
`mvn clean package -Pspark-1.6 -Ppyspark -Phadoop-2.4 -Psparkr -DskipTests -Pbuild-distr`
Shipped the distribution .tar.gz to the clusters master, unzipped, then
```
# change port to 8090 since spark UI uses 8080
# the ec2 script installs spark in /root/spark
touch conf/zeppelin-env.sh
echo "export ZEPPELIN_PORT=8090" >> conf/zeppelin-env.sh
echo "export SPARK_HOME=/root/spark" >> conf/zeppelin-env.sh
bin/zeppelin-daemon.sh start
```
Worked as expected.
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182177214
Moratorium on discussion about PR 208 is over (a day ago), and it was for only me and Amos.
Zeppelin community never blocks discussion without good reason.
So anyone feel free to comment in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202013345
I have merged datalayer#7.
(a) Issues with `spark.home` not being taken into account is fixed.
(b) Support of additional viz libs mentioned by @jeffsteinmetz is a work in progress (e.g. mplot starts a web server to render the page, which is not what we expect).
(c) Support of syntax like `z.R.show(a, "angular")` or `z.R.console(a)` as proposed by @jeffsteinmetz is not implemented
(d) build failures is not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by btiernay <gi...@git.apache.org>.
Github user btiernay commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-185168739
http://zeppelin-project.org/docs/dynamicform.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182617569
Travis fails with
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.471 sec <<< FAILURE! - in org.apache.zeppelin.spark.SparkRInterpreterTest
testSuccess(org.apache.zeppelin.spark.SparkRInterpreterTest) Time elapsed: 0.496 sec <<< ERROR!
java.lang.ExceptionInInitializerError: null
at java.lang.UNIXProcess.forkAndExec(Native Method)
at java.lang.UNIXProcess.<init>(UNIXProcess.java:186)
at java.lang.ProcessImpl.start(ProcessImpl.java:130)
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1028)
at scala.sys.process.ProcessBuilderImpl$Simple.run(ProcessBuilderImpl.scala:68)
at org.ddahl.rscala.callback.RClient$.apply(RClient.scala:689)
at org.ddahl.rscala.callback.RClient$.apply(RClient.scala:672)
at org.apache.zeppelin.spark.ZeppelinR$.<init>(ZeppelinR.scala:40)
at org.apache.zeppelin.spark.ZeppelinR$.<clinit>(ZeppelinR.scala)
at org.apache.zeppelin.spark.ZeppelinR.css(ZeppelinR.scala)
at org.apache.zeppelin.spark.SparkRInterpreter.format(SparkRInterpreter.java:179)
at org.apache.zeppelin.spark.SparkRInterpreter.interpret(SparkRInterpreter.java:134)
at org.apache.zeppelin.spark.SparkRInterpreterTest.testSuccess(SparkRInterpreterTest.java:83)
```
Strangely, it was able to pass at least one time 2 days ago.
I will double check on a platform that does not have R and mock more if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-185127651
@btiernay can you give more details on `form variables` (I have never tried this...) - maybe some code snippets?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182615851
Last commit brings the ability to define the ggplot2 image size as asked on https://github.com/datalayer/zeppelin-R/issues/2
I have also added more samples on interactive visualization.
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/ggplot2.png)
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/rcharts.png)
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/rcharts-map.png)
[](https://raw.githubusercontent.com/datalayer/zeppelin-R/rscala/_Rimg/googlevis.png)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-180962488
CLI fails for profiles 1.3, 1.2 and 1.1 with `object r is not a member of package org.apache.spark.api` which is normal as SparkR was introduced in 1.4.
Profiles 1.4, 1.5 and 1.6 are green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by justsomeone1001 <gi...@git.apache.org>.
Github user justsomeone1001 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-182646344
@doanduyhai If you pull the one from my repo, it includes a demo notebook with a whole slew of them. The purpose of it is to give reviewers something so they understand the functionality. Some of the charts will look familiar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202583441
This still shows `Error` (paragraph header upper right), but doesn't really break anything per se:
```
%r
foo <-1
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-203680677
Merge into master if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by elbamos <gi...@git.apache.org>.
Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202170557
It is not at all a surprise that you would propose to merge 702---a few hours after I asked for community involvement on another PR, where you objected.
This is absolutely the opposite of the consensus the community has repeatedly reached about the R issue.
At the moment, this PR has zero adoption. You made a major change in its architecture a day ago that no-one has had a chance to try out.
And it has zero tests --- because the CI issue still isn't solved, they've been replaced by tests that don't cover the PRs functionality and don't even test if it can connect to R or Spark.
Will you be abiding by the community's consensus or do we really need to start a seventh discussion about this on the mailing list?
> On Mar 27, 2016, at 7:23 PM, Lee moon soo <no...@github.com> wrote:
>
> @echarles Thanks for taking a look datalayer#7.
> I have tested latest commit and it works well for me. Also i have verified RInterpreter working with binary package generated by -Pbuild-distr flag.
>
> Wait for @jeffsteinmetz provides additional review.
>
> Meanwhile, how about taking care of (b) and (c) in separate PR ?
> While basic R interpreter functionality is working and tests are ready, i think we can merge it and improvements like (b), (c) as well as implementing getProgress(), and cancel() can be done in separate PR. So more people can get involved.
>
> What do you think?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-193857443
Looks good, everything has worked as expected for me.
@echarles is `r-cran-rserve` needed on ubuntu?
I was able to get by with just
`apt-get install r-base`
plus a few other packages listed as suggested
This doesn't appear to be a core requirement.
I am running it through this VM
https://github.com/apache/incubator-zeppelin/pull/751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-183846662
mmh, seems lke github now handles renaming in a nice way - no need to close....
Looking forward any comment on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: R and SparkR Support [WIP]
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-200917099
@echarles Thanks for taking a look!
> Good idea to reuse the rscala from the spark dist.
Little bit more precisely, https://github.com/datalayer/zeppelin-datalayer/pull/7 does not reuse rscala from the spark dist. ZeppelinR.java completely replaces rscala library.
What https://github.com/datalayer/zeppelin-datalayer/pull/7 reuse from spark dist is SparkR package. To support run r interpreter without spark-distribution installed on the system.
> I would prefer keeping the SparkRInterpreterTest with it PowerMock (to mock static) which does not need any R on the host and add indeed as you did an integration test which needs R on the host.
Sure, please bring SparkRInterpreterTest back if you prefer.
> I see you changed something for the SPARK_HOME which didn't work as @jeffsteinmetz pointer - will look this we.
I think https://github.com/datalayer/zeppelin-datalayer/pull/7 addresses all @jeffsteinmetz 's comment. isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---