You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/28 21:26:16 UTC
[PR] chore(frontend): fix NG8113/NG8107 template diagnostics [texera]
Yicong-Huang opened a new pull request, #5985:
URL: https://github.com/apache/texera/pull/5985
### What changes were proposed in this PR?
Fix the two remaining Angular extended-diagnostic warnings surfaced by the frontend build:
- **NG8113** — `CardItemComponent` listed `NzWaveDirective` in its standalone `imports` array but never used it in the template. Removed the unused directive import (same class of cleanup as #5975).
- **NG8107** — `computing-unit-selection.component.html` used `pve.name?.trim()`, but `PveDraft.name` is typed as a non-nullable `string`, so the optional-chaining `?.` is redundant. Changed to `pve.name.trim()`.
No behavior change.
### Any related issues, documentation, discussions?
Closes #5984
### How was this PR tested?
Static change only. `PveDraft.name` is `name: string` (non-nullable), so dropping `?.` is type-safe; `NzWaveDirective`'s selector is not referenced in the card-item template. Covered by existing build/CI.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): fix NG8113/NG8107 template diagnostics [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5985:
URL: https://github.com/apache/texera/pull/5985#issuecomment-4827457574
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5985?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.23%. Comparing base ([`0e0ec11`](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b634bec`](https://app.codecov.io/gh/apache/texera/commit/b634bec59668849978455ac7a67594d98bfc4ddb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/5985?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...wer-button/computing-unit-selection.component.html](https://app.codecov.io/gh/apache/texera/pull/5985?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fworkspace%2Fcomponent%2Fpower-button%2Fcomputing-unit-selection.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC93b3Jrc3BhY2UvY29tcG9uZW50L3Bvd2VyLWJ1dHRvbi9jb21wdXRpbmctdW5pdC1zZWxlY3Rpb24uY29tcG9uZW50Lmh0bWw=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/5985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5985 +/- ##
============================================
- Coverage 56.23% 56.23% -0.01%
Complexity 2987 2987
============================================
Files 1120 1120
Lines 43167 43167
Branches 4658 4657 -1
============================================
- Hits 24274 24273 -1
Misses 17472 17472
- Partials 1421 1422 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.77% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.56% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.02% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.27% <0.00%> (ø)` | | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5985?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): fix NG8113/NG8107 template diagnostics [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5985:
URL: https://github.com/apache/texera/pull/5985#issuecomment-4827443090
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@xuang7`, `@SarahAsad23`
You can notify them by mentioning `@xuang7`, `@SarahAsad23` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): fix NG8113/NG8107 template diagnostics, add test, promote to errors [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5985:
URL: https://github.com/apache/texera/pull/5985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org