You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/25 13:55:39 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #8702: Fix PrometheusMetricsTest on source tarball
eolivelli opened a new pull request #8702:
URL: https://github.com/apache/pulsar/pull/8702
When you run the tests from the sources in the source release tarball there is no git reference and we are publishing on the metrics a placeholder.
`pulsar_version_info{cluster="test",version="2.7.0",commit="${git.commit.id}"} `
The fix is to detect this fact an publish only an empty string.
The change affects PulsarVersion, that in turn is used in Prometheus metrics endpoint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8702: PrometheusMetrics on binaries built from the source tarball
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8702:
URL: https://github.com/apache/pulsar/pull/8702#issuecomment-733720655
@codelipenghui this is the fix, please consider cherry picking it to 2.7 branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8702: PrometheusMetrics on binaries built from the source tarball
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8702:
URL: https://github.com/apache/pulsar/pull/8702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org