You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Bernd Eckenfels <ec...@zusammenkunft.net> on 2014/12/08 21:52:45 UTC
[vfs] checkstyle cleanup planned
Hello,
I plan to commit changes to a lot of resources to remove some of the
checkstyle and other bugcheck reports in preparation of 2.1. Currently
I hav touched the following files.
If you plan to commit anything here, you might want to do it now or
speak with me, so we can reduce conflicts/merging.
It is mostly linelength, whitespace, javadoc and identifier-order
related.
M core\src\main\java\org\apache\commons\vfs2\FileContentInfo.java
M
core\src\main\java\org\apache\commons\vfs2\FileContentInfoFactory.java
M core\src\main\java\org\apache\commons\vfs2\FileObject.java
M
core\src\main\java\org\apache\commons\vfs2\FileSystemConfigBuilder.java
M
core\src\main\java\org\apache\commons\vfs2\FileSystemOptions.java
M
core\src\main\java\org\apache\commons\vfs2\auth\StaticUserAuthenticator.java
M
core\src\main\java\org\apache\commons\vfs2\impl\DecoratedFileObject.java
M
core\src\main\java\org\apache\commons\vfs2\impl\DefaultFileSystemManager.java
M
core\src\main\java\org\apache\commons\vfs2\impl\VFSClassLoader.java
M
core\src\main\java\org\apache\commons\vfs2\provider\AbstractRandomAccessContent.java
M
core\src\main\java\org\apache\commons\vfs2\provider\bzip2\Bzip2FileSystem.java
M
core\src\main\java\org\apache\commons\vfs2\provider\compressed\CompressedFileFileObject.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftp\FTPClientWrapper.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftp\FtpClientFactory.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftp\FtpFileSystemConfigBuilder.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsClientFactory.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsDataChannelProtectionLevel.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsFileSystem.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsFileSystemConfigBuilder.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsMode.java
M
core\src\main\java\org\apache\commons\vfs2\provider\gzip\GzipFileProvider.java
M
core\src\main\java\org\apache\commons\vfs2\provider\gzip\GzipFileSystem.java
M
core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileAttributes.java
M
core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileContentInfoFactory.java
M
core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileProvider.java
M
core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileSystem.java
M
core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileSystemConfigBuilder.java
M
core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsRandomAccessContent.java
M
core\src\main\java\org\apache\commons\vfs2\provider\http\HttpClientFactory.java
M
core\src\main\java\org\apache\commons\vfs2\provider\http\HttpFileObject.java
M
core\src\main\java\org\apache\commons\vfs2\provider\http\HttpFileSystemConfigBuilder.java
M
core\src\main\java\org\apache\commons\vfs2\provider\local\GenericFileNameParser.java
M
core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFile.java
M
core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFileName.java
M
core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFileRandomAccessContent.java
M
core\src\main\java\org\apache\commons\vfs2\provider\local\WindowsFileNameParser.java
M
core\src\main\java\org\apache\commons\vfs2\provider\ram\RamFileSystemConfigBuilder.java
M
core\src\main\java\org\apache\commons\vfs2\provider\sftp\IdentityInfo.java
M
core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpClientFactory.java
M
core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpFileSystem.java
M
core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpFileSystemConfigBuilder.java
M
core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpStreamProxy.java
M
core\src\main\java\org\apache\commons\vfs2\provider\url\UrlFileObject.java
M
core\src\main\java\org\apache\commons\vfs2\provider\webdav\WebdavFileProvider.java
M
core\src\main\java\org\apache\commons\vfs2\util\PosixPermissions.java
Gruss
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [vfs] checkstyle cleanup planned
Posted by Bernd Eckenfels <ec...@zusammenkunft.net>.
Am Mon, 8 Dec 2014 21:52:45 +0100
schrieb Bernd Eckenfels <ec...@zusammenkunft.net>:
> I plan to commit changes to a lot of resources to remove some of the
> checkstyle and other bugcheck reports in preparation of 2.1.
I have commited this, there are some checkstyle warnings left. Some
Javadoc (I plan to address next). Some magic numbers and casting: I
will not address as I dont like the proposed style.
If somebody wants to merge sandbox, they should do the same cleanup in
sandbox, where the report has still some of those warnings.
Gruss
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [vfs] checkstyle cleanup planned
Posted by Gary Gregory <ga...@gmail.com>.
Go for it.
Gary
On Mon, Dec 8, 2014 at 3:52 PM, Bernd Eckenfels <ec...@zusammenkunft.net>
wrote:
> Hello,
>
> I plan to commit changes to a lot of resources to remove some of the
> checkstyle and other bugcheck reports in preparation of 2.1. Currently
> I hav touched the following files.
>
> If you plan to commit anything here, you might want to do it now or
> speak with me, so we can reduce conflicts/merging.
>
> It is mostly linelength, whitespace, javadoc and identifier-order
> related.
>
> M core\src\main\java\org\apache\commons\vfs2\FileContentInfo.java
> M
> core\src\main\java\org\apache\commons\vfs2\FileContentInfoFactory.java
> M core\src\main\java\org\apache\commons\vfs2\FileObject.java
> M
> core\src\main\java\org\apache\commons\vfs2\FileSystemConfigBuilder.java
> M
> core\src\main\java\org\apache\commons\vfs2\FileSystemOptions.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\auth\StaticUserAuthenticator.java
> M
> core\src\main\java\org\apache\commons\vfs2\impl\DecoratedFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\impl\DefaultFileSystemManager.java
> M
> core\src\main\java\org\apache\commons\vfs2\impl\VFSClassLoader.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\AbstractRandomAccessContent.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\bzip2\Bzip2FileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\compressed\CompressedFileFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftp\FTPClientWrapper.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftp\FtpClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftp\FtpFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsDataChannelProtectionLevel.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsFileSystemConfigBuilder.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsMode.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\gzip\GzipFileProvider.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\gzip\GzipFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileAttributes.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileContentInfoFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileProvider.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsRandomAccessContent.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\http\HttpClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\http\HttpFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\http\HttpFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\GenericFileNameParser.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFile.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFileName.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFileRandomAccessContent.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\WindowsFileNameParser.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ram\RamFileSystemConfigBuilder.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\IdentityInfo.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpStreamProxy.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\url\UrlFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\webdav\WebdavFileProvider.java
> M
> core\src\main\java\org\apache\commons\vfs2\util\PosixPermissions.java
>
> Gruss
> Bernd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [vfs] checkstyle cleanup planned
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Dec 8, 2014 at 4:32 PM, Bernd Eckenfels <ec...@zusammenkunft.net>
wrote:
> Am Mon, 8 Dec 2014 16:26:55 -0500
> schrieb Gary Gregory <ga...@gmail.com>:
>
> > I also think we should change the { } style to keeping { at the end
> > of a line instead of on a line by itself. This would probably cause a
> > lot of changes which some folks would not like I am guessing.
>
> I actually prefer the extra-line style as it is also my company style.
> But I dont mind either way (but any change should be after the release)
>
ah, ok, interesting. Right, release out first!
Gary
>
> Gruss
> Bernd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [vfs] checkstyle cleanup planned
Posted by Bernd Eckenfels <ec...@zusammenkunft.net>.
Am Mon, 8 Dec 2014 16:26:55 -0500
schrieb Gary Gregory <ga...@gmail.com>:
> I also think we should change the { } style to keeping { at the end
> of a line instead of on a line by itself. This would probably cause a
> lot of changes which some folks would not like I am guessing.
I actually prefer the extra-line style as it is also my company style.
But I dont mind either way (but any change should be after the release)
Gruss
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [vfs] checkstyle cleanup planned
Posted by Gary Gregory <ga...@gmail.com>.
I also think we should change the { } style to keeping { at the end of a
line instead of on a line by itself. This would probably cause a lot of
changes which some folks would not like I am guessing.
G
On Mon, Dec 8, 2014 at 3:52 PM, Bernd Eckenfels <ec...@zusammenkunft.net>
wrote:
> Hello,
>
> I plan to commit changes to a lot of resources to remove some of the
> checkstyle and other bugcheck reports in preparation of 2.1. Currently
> I hav touched the following files.
>
> If you plan to commit anything here, you might want to do it now or
> speak with me, so we can reduce conflicts/merging.
>
> It is mostly linelength, whitespace, javadoc and identifier-order
> related.
>
> M core\src\main\java\org\apache\commons\vfs2\FileContentInfo.java
> M
> core\src\main\java\org\apache\commons\vfs2\FileContentInfoFactory.java
> M core\src\main\java\org\apache\commons\vfs2\FileObject.java
> M
> core\src\main\java\org\apache\commons\vfs2\FileSystemConfigBuilder.java
> M
> core\src\main\java\org\apache\commons\vfs2\FileSystemOptions.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\auth\StaticUserAuthenticator.java
> M
> core\src\main\java\org\apache\commons\vfs2\impl\DecoratedFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\impl\DefaultFileSystemManager.java
> M
> core\src\main\java\org\apache\commons\vfs2\impl\VFSClassLoader.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\AbstractRandomAccessContent.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\bzip2\Bzip2FileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\compressed\CompressedFileFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftp\FTPClientWrapper.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftp\FtpClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftp\FtpFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsDataChannelProtectionLevel.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsFileSystemConfigBuilder.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\ftps\FtpsMode.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\gzip\GzipFileProvider.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\gzip\GzipFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileAttributes.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileContentInfoFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileProvider.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\hdfs\HdfsRandomAccessContent.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\http\HttpClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\http\HttpFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\http\HttpFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\GenericFileNameParser.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFile.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFileName.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\LocalFileRandomAccessContent.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\local\WindowsFileNameParser.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\ram\RamFileSystemConfigBuilder.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\IdentityInfo.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpClientFactory.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpFileSystem.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpFileSystemConfigBuilder.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\sftp\SftpStreamProxy.java
> M
> core\src\main\java\org\apache\commons\vfs2\provider\url\UrlFileObject.java
> M
>
> core\src\main\java\org\apache\commons\vfs2\provider\webdav\WebdavFileProvider.java
> M
> core\src\main\java\org\apache\commons\vfs2\util\PosixPermissions.java
>
> Gruss
> Bernd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory