[GitHub] [kyuubi] ASiegeLion commented on a diff in pull request #5211: [KYUUBI #5210]Cancel operation will cause the log file node to leak

["ASiegeLion (via GitHub)" <gi...@apache.org>]

ASiegeLion commented on code in PR #5211:
URL: https://github.com/apache/kyuubi/pull/5211#discussion_r1310056360


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperation.scala:
##########
@@ -158,6 +151,13 @@ abstract class KyuubiOperation(session: Session) extends AbstractOperation(sessi
         }
       }
     }
+    try {
+      // For launch engine operation, we use OperationLog to pass engine submit log but
+      // at that time we do not have remoteOpHandle
+      getOperationLog.foreach(_.close())

Review Comment:
   Close the log stream gracefully, then delete the log file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org