You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/26 00:17:26 UTC
[GitHub] [airflow] xinbinhuang opened a new pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructionsg
xinbinhuang opened a new pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructionsg
URL: https://github.com/apache/airflow/pull/6902
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x]
- Update pip install with the same extra as using conda, or it will cause error when do `airflow db init` because some example dags need to import postgres and gcp .
- Update xmllint package for both ubuntu (verified) and mac (I googled the package name but cannot verify without a Mac; need someone else to verify it :) )
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361842689
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
@xinbinhuang -> yes. I think it makes sense. I think also we should solve it so that the error message is not shown. I even created a JIRA issue for it https://issues.apache.org/jira/browse/AIRFLOW-6265
I assumed you close it because you open another request :)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361782671
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
The reason I added `postgres` and `gcp` specifically is because when we first do `airflow db init` it will try to import the example dags (load_examples=yes). Though it can still init the database, the error message can be confusing to first-time contributors. Maybe I should add a note here instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361782671
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
The reason I added `postgres` and `gcp` specifically is because when we first do `airflow db init` it will try to import the example dags (load_examples=yes). Though it can still init the database, the error message can be confusing to first-time contributors. Maybe I should add a note here instead? what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on issue #6902: [AIRFLOW-XXXX] Fix
development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#issuecomment-569172501
@potiuk Small doc update on this. PTAL when you have time. Merry X'Mas!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361782671
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
The reason I added `postgres` and `gcp` specifically is because when we first do `airflow db init` it will try to import the example dags (load_examples=yes). Though it can still init the database, the error message can be confusing to first-time contributors.
Maybe we should add a note here instead? what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361842689
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
@xinbinhuang -> yes. I think it makes sense. I think also we should solve it so that the error message is not shown. I even created a JIRA issue for it recently https://issues.apache.org/jira/browse/AIRFLOW-6265
I assumed you close it because you open another request :)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361877374
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
Yeah, I made a mistake by force pushing an empty commit to my branch, and it causes this PR to be closed automatically. I could not find a way to reopen this so I create a new one. Hope it did not cause too many problems :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang closed pull request #6902: [AIRFLOW-XXXX] Fix
development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
xinbinhuang closed pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361877374
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
Yeah, I made a mistake by force pushing an empty commit to my branch, and it causes this PR to be closed automatically. I could not find a way to reopen this so I create a new one. Hope it did not cause too many problems
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6902:
[AIRFLOW-XXXX] Fix development packages installtion instructions
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
URL: https://github.com/apache/airflow/pull/6902#discussion_r361610376
##########
File path: LOCAL_VIRTUALENV.rst
##########
@@ -106,7 +106,7 @@ To create and initialize the local virtualenv:
2. Install Python PIP requirements:
- ``pip install -e ".[devel]"``
+ ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
Review comment:
```suggestion
``pip install -U -e ".[devel,<OTHER EXTRAS>]"`` for example: ``pip install -U -e ".[devel,gcp,postgres,ssh]"``
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services