You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/13 15:50:12 UTC
[GitHub] [airflow] ashb commented on a change in pull request #5664:
[AIRFLOW-5140] fix all missing type annotation errors from dmypy
ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy
URL: https://github.com/apache/airflow/pull/5664#discussion_r313475114
##########
File path: airflow/settings.py
##########
@@ -63,13 +67,13 @@
LOG_FORMAT = conf.get('core', 'log_format')
SIMPLE_LOG_FORMAT = conf.get('core', 'simple_log_format')
-SQL_ALCHEMY_CONN = None
-DAGS_FOLDER = None
-PLUGINS_FOLDER = None
-LOGGING_CLASS_PATH = None
+SQL_ALCHEMY_CONN = None # type: Optional[str]
+DAGS_FOLDER = None # type: Optional[str]
+PLUGINS_FOLDER = None # type: Optional[str]
Review comment:
Do these need to be `Optional[]` -- by the after `import airflow` is done these will _always_ be set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services