You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by li...@apache.org on 2022/05/05 05:09:51 UTC

[rocketmq-apis] branch v2 updated: Remove NackMessage (#28)

This is an automated email from the ASF dual-hosted git repository.

lizhanhui pushed a commit to branch v2
in repository https://gitbox.apache.org/repos/asf/rocketmq-apis.git


The following commit(s) were added to refs/heads/v2 by this push:
     new 0720580  Remove NackMessage (#28)
0720580 is described below

commit 0720580368b11f9818f90e45c8f1fc4079e207ae
Author: Zhouxiang Zhan <zh...@alibaba-inc.com>
AuthorDate: Thu May 5 13:09:47 2022 +0800

    Remove NackMessage (#28)
---
 apache/rocketmq/v2/service.proto | 22 ++--------------------
 1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/apache/rocketmq/v2/service.proto b/apache/rocketmq/v2/service.proto
index c6717ec..86c9f69 100644
--- a/apache/rocketmq/v2/service.proto
+++ b/apache/rocketmq/v2/service.proto
@@ -125,16 +125,6 @@ message AckMessageResponse {
   repeated AckMessageResultEntry entries = 2;
 }
 
-message NackMessageRequest {
-  Resource group = 1;
-  Resource topic = 2;
-  string receipt_handle = 3;
-  string message_id = 4;
-  int32 delivery_attempt = 5;
-}
-
-message NackMessageResponse { Status status = 1; }
-
 message ForwardMessageToDeadLetterQueueRequest {
   Resource group = 1;
   Resource topic = 2;
@@ -364,8 +354,8 @@ service MessagingService {
   }
 
   // Receives messages from the server in batch manner, returns a set of
-  // messages if success. The received messages should be acked or nacked after
-  // processed.
+  // messages if success. The received messages should be acked or redelivered
+  // after processed.
   //
   // If the pending concurrent receive requests exceed the quota of the given
   // consumer group, returns `UNAVAILABLE`. If the upstream store server hangs,
@@ -389,14 +379,6 @@ service MessagingService {
   // `INVALID_ARGUMENT`.
   rpc AckMessage(AckMessageRequest) returns (AckMessageResponse) {}
 
-  // Signals that the message has not been successfully processed. The message
-  // server should resend the message follow the retry policy defined at
-  // server-side.
-  //
-  // If the corresponding topic or consumer group doesn't exist, returns
-  // `NOT_FOUND`.
-  rpc NackMessage(NackMessageRequest) returns (NackMessageResponse) {}
-
   // Forwards one message to dead letter queue if the max delivery attempts is
   // exceeded by this message at client-side, return `OK` if success.
   rpc ForwardMessageToDeadLetterQueue(ForwardMessageToDeadLetterQueueRequest)