You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/12 09:29:59 UTC
[GitHub] [tvm] alexqdh opened a new pull request, #10974: fix typo in tutorial doc
alexqdh opened a new pull request, #10974:
URL: https://github.com/apache/tvm/pull/10974
fix typo in tutorial doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero merged pull request #10974: Fix typo in tutorial doc
Posted by GitBox <gi...@apache.org>.
gromero merged PR #10974:
URL: https://github.com/apache/tvm/pull/10974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on a diff in pull request #10974: fix typo in tutorial doc
Posted by GitBox <gi...@apache.org>.
gromero commented on code in PR #10974:
URL: https://github.com/apache/tvm/pull/10974#discussion_r849995159
##########
gallery/tutorial/tvmc_python.py:
##########
@@ -111,7 +111,7 @@
# result = tvmc.run(package, device="cpu") #Step 3: Run
#
# And you can print the results:
-# ``print(results)``
+# ``print(result)``
Review Comment:
Should we also fix `my_model` in line 71? Like:
s/`my_model`/`'my_model.onnx'`/ ?
Also, since you'll need to re-trigger the CI, would you mind to:
in lines 240 and 245 add a space after second comma, i.e. s/`"llvm",tuning_records`/`"llvm", tuning_records`/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alexqdh commented on a diff in pull request #10974: Fix typo in tutorial doc
Posted by GitBox <gi...@apache.org>.
alexqdh commented on code in PR #10974:
URL: https://github.com/apache/tvm/pull/10974#discussion_r850947932
##########
gallery/tutorial/tvmc_python.py:
##########
@@ -111,7 +111,7 @@
# result = tvmc.run(package, device="cpu") #Step 3: Run
#
# And you can print the results:
-# ``print(results)``
+# ``print(result)``
Review Comment:
OK, I have re-triggered the CI and fix typos mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10974: fix typo in tutorial doc
Posted by GitBox <gi...@apache.org>.
gromero commented on PR #10974:
URL: https://github.com/apache/tvm/pull/10974#issuecomment-1099610907
@alexqdh Yeah the CI error is now fixed by @areusch (https://github.com/apache/tvm/pull/11007#event-6437149199) So please, just re-trigger. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10974: Fix typo in tutorial doc
Posted by GitBox <gi...@apache.org>.
gromero commented on PR #10974:
URL: https://github.com/apache/tvm/pull/10974#issuecomment-1101407331
@alexqdh Thank you. Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org