You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by tv...@apache.org on 2022/08/20 08:28:27 UTC
[buildstream] branch tristan/workspace-info-log created (now 09dbaca9d)
This is an automated email from the ASF dual-hosted git repository.
tvb pushed a change to branch tristan/workspace-info-log
in repository https://gitbox.apache.org/repos/asf/buildstream.git
at 09dbaca9d _stream.py: Cleanup workspace open INFO log
This branch includes the following new commits:
new 09dbaca9d _stream.py: Cleanup workspace open INFO log
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[buildstream] 01/01: _stream.py: Cleanup workspace open INFO log
Posted by tv...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tvb pushed a commit to branch tristan/workspace-info-log
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 09dbaca9da8cc7233cb5b44041c63aeec7c5457e
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Sat Aug 20 17:15:45 2022 +0900
_stream.py: Cleanup workspace open INFO log
Here we were initially printing that we're opening a workspace and then
printing that we opened it, the initial log line *can* be helpful to provide
context in case an error occurs, but let's change that to a STATUS message,
only the latter message is informative.
---
src/buildstream/_stream.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/buildstream/_stream.py b/src/buildstream/_stream.py
index 5469b860f..efad29313 100644
--- a/src/buildstream/_stream.py
+++ b/src/buildstream/_stream.py
@@ -1062,7 +1062,7 @@ class Stream:
# Now it does the bits that can not be made atomic.
targetGenerator = zip(elements, expanded_directories)
for target, directory in targetGenerator:
- self._context.messenger.info("Creating workspace for element {}".format(target.name))
+ self._context.messenger.status("Creating workspace for element {}".format(target.name))
workspace = workspaces.get_workspace(target._get_full_name())
if workspace and not no_checkout:
@@ -1083,7 +1083,7 @@ class Stream:
) from e
workspaces.create_workspace(target, directory, checkout=not no_checkout)
- self._context.messenger.info("Created a workspace for element: {}".format(target._get_full_name()))
+ self._context.messenger.info("Created a workspace for element {}".format(target._get_full_name()))
# workspace_close
#