You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/03 07:38:49 UTC
[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1161: HDDS-3917. Add recon to no_proxy of docker-config for acceptance test
GlenGeng opened a new pull request #1161:
URL: https://github.com/apache/hadoop-ozone/pull/1161
## What changes were proposed in this pull request?
For internal acceptance test, which have configured proxy for http, test cases for recon will be affected.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3917
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
CI
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1161: HDDS-3917. Add recon to no_proxy of docker-config for acceptance test
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1161:
URL: https://github.com/apache/hadoop-ozone/pull/1161#issuecomment-653431457
@elek Thanks for pointing this out !
It looks like for now all `docker-config` share the same `no_proxy` config. Changing them all can avoid the case that in future someone add `recon` to an existing docker test but forget change the `docker-config`, since this is a easily overlooked issue. I can revert the changed `docker-config` which does not consist of a `recon` component. Both are fine to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1161: HDDS-3917. Add recon to no_proxy of docker-config for acceptance test
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1161:
URL: https://github.com/apache/hadoop-ozone/pull/1161#issuecomment-653463674
> Changing them all can avoid the case that in future someone add recon to an existing docker test but forget change the docker-config, since this is a easily overlooked issue
Yes, I can accept this argument. Especially as the problem can be detected only in an internal environment with http proxies. Easy to forget the update.
> Both are fine to me.
Me, too. Let me merge this in this form. It's more verbose, but as you wrote, it can provide additional safety....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1161: HDDS-3917. Add recon to no_proxy of docker-config for acceptance test
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1161:
URL: https://github.com/apache/hadoop-ozone/pull/1161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org