You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/21 08:31:46 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #21682: Refactor single table DistSQL syntax #21672
jiangML opened a new pull request, #21682:
URL: https://github.com/apache/shardingsphere/pull/21682
Fixes #21672.
Changes proposed in this pull request:
- CREATE DEFAULT SINGLE TABLE RULE RESOURCE = xx -> SET DEFAULT SINGLE TABLE STORAGE UNIT = xx
- ALTER DEFAULT SINGLE TABLE RULE RESOURCE -> REMOVE IT
- DROP DEFAULT SINGLE TABLE RULE -> SET DEFAULT SINGLE TABLE STORAGE UNIT = RANDOM (RANDOM is keyword)
- SHOW SINGLE TABLE RULES -> SHOW DEFAULT SINGLE TABLE STORAGE UNIT
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #21682: Change SINGLE TABLE RULE & RESOURCE to STORAGE UNIT DistSQL syntax #21671 #21672
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #21682:
URL: https://github.com/apache/shardingsphere/pull/21682#issuecomment-1287837681
@jiangML
Please update docs in [usage](https://github.com/apache/shardingsphere/tree/master/docs/document/content/user-manual/shardingsphere-proxy/distsql/usage) later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21682: Refactor single table DistSQL syntax #21672
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21682:
URL: https://github.com/apache/shardingsphere/pull/21682#issuecomment-1287760814
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21682?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21682](https://codecov.io/gh/apache/shardingsphere/pull/21682?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a57df2f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/520cc64cc8c2e880e911df9694b169227695c384?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (520cc64) will **decrease** coverage by `0.07%`.
> The diff coverage is `67.64%`.
```diff
@@ Coverage Diff @@
## master #21682 +/- ##
============================================
- Coverage 61.09% 61.02% -0.08%
+ Complexity 2511 2505 -6
============================================
Files 4111 4111
Lines 57350 57375 +25
Branches 9688 9696 +8
============================================
- Hits 35039 35013 -26
- Misses 19403 19455 +52
+ Partials 2908 2907 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../statement/rql/show/ShowStorageUnitsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9ycWwvc2hvdy9TaG93U3RvcmFnZVVuaXRzU3RhdGVtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...istsql/rdl/resource/AddResourceBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmRsL3Jlc291cmNlL0FkZFJlc291cmNlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `83.33% <ø> (ø)` | |
| [...tsql/rdl/resource/AlterResourceBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmRsL3Jlc291cmNlL0FsdGVyUmVzb3VyY2VCYWNrZW5kSGFuZGxlci5qYXZh) | `81.25% <ø> (ø)` | |
| [...stsql/rdl/resource/DropResourceBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmRsL3Jlc291cmNlL0Ryb3BSZXNvdXJjZUJhY2tlbmRIYW5kbGVyLmphdmE=) | `94.44% <ø> (ø)` | |
| [...istsql/rdl/alter/AlterResourceStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmRsL2FsdGVyL0FsdGVyUmVzb3VyY2VTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `73.33% <ø> (ø)` | |
| [...distsql/rdl/create/AddResourceStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmRsL2NyZWF0ZS9BZGRSZXNvdXJjZVN0YXRlbWVudEFzc2VydC5qYXZh) | `73.33% <ø> (ø)` | |
| [...l/CreateDefaultSingleTableRuleStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmRsL2NyZWF0ZS9pbXBsL0NyZWF0ZURlZmF1bHRTaW5nbGVUYWJsZVJ1bGVTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `66.66% <ø> (ø)` | |
| [.../distsql/rdl/drop/DropResourceStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmRsL2Ryb3AvRHJvcFJlc291cmNlU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `66.66% <ø> (ø)` | |
| [...eterized/jaxb/cases/domain/SQLParserTestCases.java](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2pheGIvY2FzZXMvZG9tYWluL1NRTFBhcnNlclRlc3RDYXNlcy5qYXZh) | `99.31% <ø> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/21682/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #21682: Change SINGLE TABLE RULE & RESOURCE to STORAGE UNIT DistSQL syntax #21671 #21672
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #21682:
URL: https://github.com/apache/shardingsphere/pull/21682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org