You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/06/24 01:03:01 UTC

[Apache Bloodhound] #110: Use product prefix in ticket queries

#110: Use product prefix in ticket queries
-----------------------------------------------+--------------------
 Reporter:  olemis                             |      Owner:  nobody
     Type:  enhancement                        |     Status:  new
 Priority:  major                              |  Milestone:
Component:  multiproduct                       |    Version:
 Keywords:  ticket query product custom field  |
-----------------------------------------------+--------------------
 At present product names are used by query module in order to match
 tickets . IMO this is not a good practice considering the fact that [#108
 name might change but prefix should be immutable] . As a consequence e.g.
 saved queries might need to be update if product name is changed. IMO a
 better solution involves using product prefix (e.g.
 `status=!closed&product=bh` ) . Nonetheless it'd be nice to keep
 displaying product name in select controls in web UI .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  gjm
      Type:  enhancement   |     Status:  accepted
  Priority:  major         |  Milestone:  Release 3
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------

Comment (by gjm):

 r1404956 fixes the queries

 r1404957 changes the resource method on products to refer to the prefix
 field instead of the name to fix the product activity timeline

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  nobody
      Type:  enhancement   |     Status:  new
  Priority:  major         |  Milestone:  Release 2
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------
Changes (by gjm):

 * milestone:   => Release 2


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  gjm
      Type:  enhancement   |     Status:  closed
  Priority:  major         |  Milestone:  Release 3
 Component:  multiproduct  |    Version:
Resolution:  fixed         |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------
Changes (by gjm):

 * status:  accepted => closed
 * resolution:   => fixed


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Olemis Lang <ol...@gmail.com>.
On 11/2/12, Peter Koželj <pe...@digiverse.si> wrote:
> On Fri, Nov 2, 2012 at 1:02 PM, Apache Bloodhound <
> bloodhound-dev@incubator.apache.org> wrote:
>
[...]
>
>>  r1404931 adds the possibility of trac referring to a field other than
>> the
>>  resource.name
>>
>>  r1404932 changes the field that tickets use to refer to products from
>> name
>>  to prefix - this includes a database migration for any tickets that are
>>  already using products
>>
>
> I wanted to discuss model changes together with multiproduct features
> and enhancements:
> If we are putting the product prefix in search and/or url, we would need to
> make sure reports and url for a ticket do not break if ticket is moved to
> another product. This can no longer be solved by a simple many-to-one
> relationship.
>

At least at the moment it seems there's no need to do so ... afaics .
Ticket ID is still the primary key . Even if multiproduct is installed
/ enabled ticket will still be identified by the same ID .

Many-to-one relationship should not matter (too much) as it's external
. AFAICS only a single redirect from
http://server.com/path/to/bloodhound/ticket/123 onto
http://server.com/path/to/bloodhound/product/product1/ticket/123 might
be useful (but definitely not required) . This should be implemented
using request filters or similar mechanisms .

IMO there's no big deal to worry about this particular subject
;)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Peter Koželj <pe...@digiverse.si>.
On Fri, Nov 2, 2012 at 1:02 PM, Apache Bloodhound <
bloodhound-dev@incubator.apache.org> wrote:

> #110: Use product prefix in ticket queries
> ---------------------------+-----------------------------------------------
>   Reporter:  olemis        |      Owner:  gjm
>       Type:  enhancement   |     Status:  closed
>   Priority:  major         |  Milestone:  Release 3
>  Component:  multiproduct  |    Version:
> Resolution:  fixed         |   Keywords:  ticket query product custom field
> ---------------------------+-----------------------------------------------
> Changes (by gjm):
>
>  * status:  assigned => closed
>  * resolution:   => fixed
>
>
> Comment:
>
>  r1404931 adds the possibility of trac referring to a field other than the
>  resource.name
>
>  r1404932 changes the field that tickets use to refer to products from name
>  to prefix - this includes a database migration for any tickets that are
>  already using products
>

I wanted to discuss model changes together with multiproduct features
and enhancements:
If we are putting the product prefix in search and/or url, we would need to
make sure reports and url for a ticket do not break if ticket is moved to
another product. This can no longer be solved by a simple many-to-one
relationship.


> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:4>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Gary Martin <ga...@wandisco.com>.
This implements the patches described in the Datamodel and data consistency
thread so that tickets are now using the product prefix instead of the
product name. The only significant change from that was the addition of a
database upgrade to correct existing tickets.

On 2 November 2012 12:02, Apache Bloodhound <
bloodhound-dev@incubator.apache.org> wrote:

> #110: Use product prefix in ticket queries
> ---------------------------+-----------------------------------------------
>   Reporter:  olemis        |      Owner:  gjm
>       Type:  enhancement   |     Status:  closed
>   Priority:  major         |  Milestone:  Release 3
>  Component:  multiproduct  |    Version:
> Resolution:  fixed         |   Keywords:  ticket query product custom field
> ---------------------------+-----------------------------------------------
> Changes (by gjm):
>
>  * status:  assigned => closed
>  * resolution:   => fixed
>
>
> Comment:
>
>  r1404931 adds the possibility of trac referring to a field other than the
>  resource.name
>
>  r1404932 changes the field that tickets use to refer to products from name
>  to prefix - this includes a database migration for any tickets that are
>  already using products
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:4>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  gjm
      Type:  enhancement   |     Status:  closed
  Priority:  major         |  Milestone:  Release 3
 Component:  multiproduct  |    Version:
Resolution:  fixed         |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------
Changes (by gjm):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 r1404931 adds the possibility of trac referring to a field other than the
 resource.name

 r1404932 changes the field that tickets use to refer to products from name
 to prefix - this includes a database migration for any tickets that are
 already using products

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  gjm
      Type:  enhancement   |     Status:  accepted
  Priority:  major         |  Milestone:  Release 3
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------
Changes (by gjm):

 * status:  new => accepted


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  olemis
      Type:  enhancement   |     Status:  accepted
  Priority:  blocker       |  Milestone:  Release 2
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------
Changes (by olemis):

 * status:  new => accepted
 * owner:  nobody => olemis
 * priority:  major => blocker


Old description:

> At present product names are used by query module in order to match
> tickets . IMO this is not a good practice considering the fact that [#108
> name might change but prefix should be immutable] . As a consequence e.g.
> saved queries might need to be update if product name is changed. IMO a
> better solution involves using product prefix (e.g.
> `status=!closed&product=bh` ) . Nonetheless it'd be nice to keep
> displaying product name in select controls in web UI .

New description:

 At present product names are used by query module in order to match
 tickets . IMO this is not a good practice considering the fact that
 [ticket:108 name might change but prefix should be immutable] . As a
 consequence e.g. saved queries might need to be update if product name is
 changed. IMO a better solution involves using product prefix (e.g.
 `status=!closed&product=bh` ) . Nonetheless it'd be nice to keep
 displaying product name in select controls in web UI .

--

Comment:

 Accepting this ticket due to the fact that this needs to be finished in
 order to filter products timeline in the way specified in #94 .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  gjm
      Type:  enhancement   |     Status:  new
  Priority:  major         |  Milestone:  Release 3
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------
Changes (by gjm):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Missed a few small details around the product pages as the widgets are
 using the wrong queries and the timeline is empty.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Olemis Lang <ol...@gmail.com>.
I think this task may be postponed and rescheduled to be released in the future.

What do you think ?

On 7/30/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #110: Use product prefix in ticket queries
> ---------------------------+-----------------------------------------------
>   Reporter:  olemis        |      Owner:  gjm
>       Type:  enhancement   |     Status:  assigned
>   Priority:  major         |  Milestone:  Release 2
>  Component:  multiproduct  |    Version:
> Resolution:                |   Keywords:  ticket query product custom field
> ---------------------------+-----------------------------------------------
> Changes (by olemis):
>
>  * status:  accepted => assigned
>  * priority:  blocker => major
>  * owner:  olemis => gjm
>
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:3>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>


-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #110: Use product prefix in ticket queries

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#110: Use product prefix in ticket queries
---------------------------+-----------------------------------------------
  Reporter:  olemis        |      Owner:  gjm
      Type:  enhancement   |     Status:  assigned
  Priority:  major         |  Milestone:  Release 2
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  ticket query product custom field
---------------------------+-----------------------------------------------
Changes (by olemis):

 * status:  accepted => assigned
 * priority:  blocker => major
 * owner:  olemis => gjm


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/110#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker