You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/13 05:06:28 UTC
[GitHub] [incubator-apisix] juzhiyuan opened a new issue #1244: bug: plugin
basic-auth needs required field
juzhiyuan opened a new issue #1244: bug: plugin basic-auth needs required field
URL: https://github.com/apache/incubator-apisix/issues/1244
### Issue description
Plugin `basic-auth` doesn't have `required` field currently.
### Environment
* apisix version (cmd: `apisix version`):
* OS:
### Minimal test code / Steps to reproduce the issue
None
### What's the actual result? (including assertion message & call stack if applicable)
No `required` field.
### What's the expected result?
It should have at least one required field such as username or password in my opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1244: bug: plugin
basic-auth needs required field
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1244: bug: plugin basic-auth needs required field
URL: https://github.com/apache/incubator-apisix/issues/1244#issuecomment-598574032
For all of the authorization plugin:
When it was used with `consumer`, it is necessary to provide specific authentication information.
When it was used with `route / service`, we don't need any parameters, just enable or disable this plugin.
So I think the current way is right.
How about this `schema` definition? Is it better?
```lua
oneof = {
-- no parameter
required = {},
-- two parameters
required = {"username", "passwd"}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis closed issue #1244: bug: plugin
basic-auth needs required field
Posted by GitBox <gi...@apache.org>.
membphis closed issue #1244: bug: plugin basic-auth needs required field
URL: https://github.com/apache/incubator-apisix/issues/1244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services