You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/28 08:32:54 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5874: input/button: Remove the mulitple poll support

xiaoxiang781216 commented on pull request #5874:
URL: https://github.com/apache/incubator-nuttx/pull/5874#issuecomment-1080353361


   > I have a general question. `NPOLLWAITERS` seems to be a more generic approach all over the code and buttons seems to be a partial case. Maybe it is more reasonable to set `INPUT_BUTTONS_NPOLLWAITERS` default value to `1` instead of removing it completely?
   
   The problem is that the notification is unreliable. Since we just have one bo_pending per file handle and btn_read will clear bo_pending, the second instance may lose the event.
   
   > Or you are going to iterate the code and apply similar change to other files?
   
   touch and keyboard just support one poller per file handler, I will provide patch for ajoystack and djoystack.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org