You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "samarth-ksolves (via GitHub)" <gi...@apache.org> on 2025/12/09 07:53:19 UTC
[PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
samarth-ksolves opened a new pull request, #21112:
URL: https://github.com/apache/kafka/pull/21112
In this PR, we corrected the argument order in assertEquals within the
connect package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21112:
URL: https://github.com/apache/kafka/pull/21112#issuecomment-4748535576
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21112:
URL: https://github.com/apache/kafka/pull/21112#issuecomment-5754967313
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21112:
URL: https://github.com/apache/kafka/pull/21112#issuecomment-3663490976
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21112:
URL: https://github.com/apache/kafka/pull/21112#issuecomment-5724805622
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21112:
URL: https://github.com/apache/kafka/pull/21112#issuecomment-4087642934
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #21112:
URL: https://github.com/apache/kafka/pull/21112#discussion_r4350764781
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrorHandlingIntegrationTest.java:
##########
@@ -156,8 +156,8 @@ public void testSkipRetryAndDLQWithHeaders() throws Exception {
String k = new String(rec.key());
String v = new String(rec.value());
log.debug("Consumed record (key='{}', value='{}') from topic {}", k, v, rec.topic());
- assertEquals(k, "key-" + i, "Unexpected key");
- assertEquals(v, "value-" + i, "Unexpected value");
+ assertEquals("key-" + i, k, "Unexpected key");
+ assertEquals("value-" + i, v,"Unexpected value");
Review Comment:
This is failing checkstyle, we need a space after the comma. Same issue below
##########
connect/api/src/test/java/org/apache/kafka/connect/data/DateTest.java:
##########
@@ -70,8 +70,8 @@ public void testFromLogicalInvalidHasTimeComponents() {
@Test
public void testToLogical() {
- assertEquals(EPOCH.getTime(), Date.toLogical(Date.SCHEMA, 0));
- assertEquals(EPOCH_PLUS_TEN_THOUSAND_DAYS.getTime(), Date.toLogical(Date.SCHEMA, 10000));
+ assertEquals(Date.toLogical(Date.SCHEMA, 0), EPOCH.getTime());
Review Comment:
I think the order of the assertions in connect/api is correct. can you revert the changes in these files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21112:
URL: https://github.com/apache/kafka/pull/21112#issuecomment-4072225763
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21112:
URL: https://github.com/apache/kafka/pull/21112#issuecomment-4726284396
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org