[GitHub] [arrow] rok edited a comment on pull request #10598: ARROW-13054: [C++] Add TemporalOptions

[GitBox <gi...@apache.org>]

rok edited a comment on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868398341


   Hey @thisisnic! Thanks for the input :).
   
   > * `fiscal_start` - this is an argument to `quarter` which indicates the starting month of a fiscal year - I think this would be useful to implement
   
   Is this just an arbitrary month user sets or is there a standard?
   
   > * `with_year` - an argument to `quarter` which defines whether the returned value is just the quarter or the quarter _and_ the year - I don't think we need this as it makes the outputs ambiguous and can be achieved at the R layer
   > * `label` - an argument to `month` and `wday` (aka `day_of_week` in Arrow) which defines whether the returned value is an integer or character representation of the month - as discussed on https://issues.apache.org/jira/browse/ARROW-13133, this can be achieved via a separate `strftime` kernel
   > * `abbr` - works with `label` and determines whether the label is abbreviated - I think this belongs to the `strftime` kernel
   > * `locale` - locale to use for month/week day names if `label` is set to `TRUE`- I think this belongs to the `strftime` kernel
   
   I was wondering about locale as well. Would it be a good idea to be able to set an arbitrary locale in some cases? [Pandas appears not to offer this option](https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.dayofweek.html). It would be useful for strftime but could cause misinterpretations for say day_of_week.
   
   Added [strftime jira](https://issues.apache.org/jira/browse/ARROW-13174).
    
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org