You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by zh...@apache.org on 2026/09/08 01:03:24 UTC
(maka) branch main updated: test(desktop): wait for narrative fixture workbar (#4970)
This is an automated email from the ASF dual-hosted git repository.
me2seeks pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/maka.git
The following commit(s) were added to refs/heads/main by this push:
new dd4479c664 test(desktop): wait for narrative fixture workbar (#4970)
dd4479c664 is described below
commit dd4479c66480f4c828469c82c85ab2843896c45d
Author: Xiao Liu <li...@qq.com>
AuthorDate: Tue Sep 8 09:03:20 2026 +0800
test(desktop): wait for narrative fixture workbar (#4970)
The narrative fixture exposed its transcript before its deferred workbar setup had selected Review. A test could open Trace in that gap and then lose selection when fixture setup completed. Wait for the seeded Git changes region before handing the page to tests.
Fixes #4968
Generated-by: OpenAI Codex
---
apps/desktop/e2e/fixtures.ts | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/apps/desktop/e2e/fixtures.ts b/apps/desktop/e2e/fixtures.ts
index ef3cf0dce8..82f06d0436 100644
--- a/apps/desktop/e2e/fixtures.ts
+++ b/apps/desktop/e2e/fixtures.ts
@@ -684,13 +684,24 @@ export const test = base.extend<E2eTestFixtures>({
// beside it. Shown because the accessibility journey follows real native
// focus order through the transcript into the composer controls.
accessibilityNarrativeWindow: async ({}, use) => {
- await withE2eWindow({
- seed: false,
- readinessSelector: '[data-turn-id]',
- e2eFixtureScenario: 'turn-narrative',
- locale: 'zh-CN',
- showWindow: true,
- }, use);
+ await withE2eWindow(
+ {
+ seed: false,
+ readinessSelector: '[data-turn-id]',
+ e2eFixtureScenario: 'turn-narrative',
+ locale: 'zh-CN',
+ showWindow: true,
+ },
+ async (page) => {
+ // `[data-turn-id]` can render before the deferred fixture application
+ // finishes opening its seeded Review face. Handing the page to a test
+ // at that point lets a test-opened face lose to the later fixture
+ // action. The visible seeded panel is the convergence point for both
+ // the transcript and the fixture-owned workbar state.
+ await expect(page.getByRole('region', { name: 'Git 变更' })).toBeVisible();
+ await use(page);
+ },
+ );
},
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org