You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2015/02/26 14:34:34 UTC
Re: svn commit: r1662434 - in
/sling/trunk/bundles/extensions/models/impl: pom.xml
src/main/java/org/apache/sling/models/impl/sightly/
src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
Hi Konrad,
On Thu, 2015-02-26 at 12:27 +0000, kwin@apache.org wrote:
> Modified: sling/trunk/bundles/extensions/models/impl/pom.xml
> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/models/impl/pom.xml?rev=1662434&r1=1662433&r2=1662434&view=diff
> ==============================================================================
> --- sling/trunk/bundles/extensions/models/impl/pom.xml (original)
> +++ sling/trunk/bundles/extensions/models/impl/pom.xml Thu Feb 26 12:27:25 2015
> @@ -146,5 +146,19 @@
> <scope>provided</scope>
> <optional>true</optional>
> </dependency>
> + <dependency>
> + <groupId>org.apache.sling</groupId>
> + <artifactId>org.apache.sling.scripting.sightly</artifactId>
> + <version>1.0.0-SNAPSHOT</version>
> + <scope>provided</scope>
> + <optional>true</optional>
> + </dependency>
> + <dependency>
> + <groupId>org.apache.sling</groupId>
> + <artifactId>org.apache.sling.commons.classloader</artifactId>
> + <version>1.3.0</version>
> + <scope>provided</scope>
> + <optional>true</optional>
> + </dependency>
> </dependencies>
> </project>
(snip)
This breaks the main build, since it can't find a sightly SNAPSHOT in
its reactor or on a repo. We could do a quick fix and deploy a sightly
SNAPSHOT but the question is whether this is the right thing to do.
Since models is in bundles/extensions ( i.e. in the main build ) and
sightly in contrib I would argue that it's not right to place such
dependencies, and I would rather see an addon in contrib which provides
this functionality.
WDYT?
Cheers,
Robert
Re: Fwd: svn commit: r1662434 - in
/sling/trunk/bundles/extensions/models/impl: pom.xml
src/main/java/org/apache/sling/models/impl/sightly/
src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2015-02-26 at 17:52 +0100, Konrad Windszus wrote:
> Unfortunately the build still fails (https://builds.apache.org/job/sling-trunk-1.6/3114/console):
>
> …
> [INFO] ------------------------------------------------------------------------
> [INFO] Building Apache Sling Models Implementation 1.1.1-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> Downloading:
> http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/org.apache.sling.scripting.sightly-1.0.0-SNAPSHOT.pom
> [WARNING] The POM for org.apache.sling:org.apache.sling.scripting.sightly:jar:1.0.0-SNAPSHOT is missing, no dependency information available
>
> Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/org.apache.sling.scripting.sightly-1.0.0-SNAPSHOT.jar
> …
>
> Any idea why this still happens?
> I uploaded the Sightly Snapshots and they seem to be there now (http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/).
> The only problem I see is that they are requested through this URL: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/org.apache.sling.scripting.sightly-1.0.0-SNAPSHOT.pom, but they are uploaded with the unique versions timestamp. Usually Nexus takes care of that and also the maven-metadata.xml at https://repository.apache.org/content/groups/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/maven-metadata.xml looks correct to me.
I for one have no idea why this happens. Maybe some sort of failing
stale check? Anyway, I see that sling-trunk-1.7 worked after the change.
Robert
> Konrad
>
>
> > Begin forwarded message:
> >
> > Reply-To: dev@sling.apache.org
> > Subject: Re: svn commit: r1662434 - in /sling/trunk/bundles/extensions/models/impl: pom.xml src/main/java/org/apache/sling/models/impl/sightly/ src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
> > From: Konrad Windszus <ko...@gmx.de>
> > Date: 26 Feb 2015 14:59:38 CET
> > To: dev@sling.apache.org
> >
> > I just deployed Sightly SNAPSHOTs to the Apache Snapshots repository. The next build should not longer fail due to this.
> > Regarding moving the Sling Models UseProvider to its own bundle I would like to hear other opinions on that. For me that one class does not necessarily call for a dedicated bundle.
> > Is it in general not allowed to have dependencies from the main build towards the contrib section?
> > Are there any plans on moving Sightly to the main build?
> > Thanks for your input on that,
> > Konrad
> >
> >> On 26 Feb 2015, at 14:37, Konrad Windszus <ko...@gmx.de> wrote:
> >>
> >> Hi Robert,
> >> yes, I just noticed that.
> >> Since this is an optional dependency I would rather argue that this should be fine.
> >> Can you for now push the sightly SNAPSHOT release since I am having difficulties to build that due to issue with the Company Maven repo?
> >> Once we do have a Sightly release that should no longer be a problem.
> >> Konrad
> >>
> >>
> >>
> >>
> >>> On 26 Feb 2015, at 14:34, Robert Munteanu <ro...@apache.org> wrote:
> >>>
> >>> Hi Konrad,
> >>>
> >>> On Thu, 2015-02-26 at 12:27 +0000, kwin@apache.org wrote:
> >>>> Modified: sling/trunk/bundles/extensions/models/impl/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/models/impl/pom.xml?rev=1662434&r1=1662433&r2=1662434&view=diff
> >>>> ==============================================================================
> >>>> --- sling/trunk/bundles/extensions/models/impl/pom.xml (original)
> >>>> +++ sling/trunk/bundles/extensions/models/impl/pom.xml Thu Feb 26 12:27:25 2015
> >>>> @@ -146,5 +146,19 @@
> >>>> <scope>provided</scope>
> >>>> <optional>true</optional>
> >>>> </dependency>
> >>>> + <dependency>
> >>>> + <groupId>org.apache.sling</groupId>
> >>>> + <artifactId>org.apache.sling.scripting.sightly</artifactId>
> >>>> + <version>1.0.0-SNAPSHOT</version>
> >>>> + <scope>provided</scope>
> >>>> + <optional>true</optional>
> >>>> + </dependency>
> >>>> + <dependency>
> >>>> + <groupId>org.apache.sling</groupId>
> >>>> + <artifactId>org.apache.sling.commons.classloader</artifactId>
> >>>> + <version>1.3.0</version>
> >>>> + <scope>provided</scope>
> >>>> + <optional>true</optional>
> >>>> + </dependency>
> >>>> </dependencies>
> >>>> </project>
> >>>
> >>> (snip)
> >>>
> >>> This breaks the main build, since it can't find a sightly SNAPSHOT in
> >>> its reactor or on a repo. We could do a quick fix and deploy a sightly
> >>> SNAPSHOT but the question is whether this is the right thing to do.
> >>>
> >>> Since models is in bundles/extensions ( i.e. in the main build ) and
> >>> sightly in contrib I would argue that it's not right to place such
> >>> dependencies, and I would rather see an addon in contrib which provides
> >>> this functionality.
> >>>
> >>> WDYT?
> >>>
> >>> Cheers,
> >>>
> >>> Robert
> >>>
> >>>
> >>
> >
>
Fwd: svn commit: r1662434 - in /sling/trunk/bundles/extensions/models/impl: pom.xml src/main/java/org/apache/sling/models/impl/sightly/ src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
Posted by Konrad Windszus <ko...@gmx.de>.
Unfortunately the build still fails (https://builds.apache.org/job/sling-trunk-1.6/3114/console):
…
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Sling Models Implementation 1.1.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading:
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/org.apache.sling.scripting.sightly-1.0.0-SNAPSHOT.pom
[WARNING] The POM for org.apache.sling:org.apache.sling.scripting.sightly:jar:1.0.0-SNAPSHOT is missing, no dependency information available
Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/org.apache.sling.scripting.sightly-1.0.0-SNAPSHOT.jar
…
Any idea why this still happens?
I uploaded the Sightly Snapshots and they seem to be there now (http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/).
The only problem I see is that they are requested through this URL: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/org.apache.sling.scripting.sightly-1.0.0-SNAPSHOT.pom, but they are uploaded with the unique versions timestamp. Usually Nexus takes care of that and also the maven-metadata.xml at https://repository.apache.org/content/groups/snapshots/org/apache/sling/org.apache.sling.scripting.sightly/1.0.0-SNAPSHOT/maven-metadata.xml looks correct to me.
Konrad
> Begin forwarded message:
>
> Reply-To: dev@sling.apache.org
> Subject: Re: svn commit: r1662434 - in /sling/trunk/bundles/extensions/models/impl: pom.xml src/main/java/org/apache/sling/models/impl/sightly/ src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
> From: Konrad Windszus <ko...@gmx.de>
> Date: 26 Feb 2015 14:59:38 CET
> To: dev@sling.apache.org
>
> I just deployed Sightly SNAPSHOTs to the Apache Snapshots repository. The next build should not longer fail due to this.
> Regarding moving the Sling Models UseProvider to its own bundle I would like to hear other opinions on that. For me that one class does not necessarily call for a dedicated bundle.
> Is it in general not allowed to have dependencies from the main build towards the contrib section?
> Are there any plans on moving Sightly to the main build?
> Thanks for your input on that,
> Konrad
>
>> On 26 Feb 2015, at 14:37, Konrad Windszus <ko...@gmx.de> wrote:
>>
>> Hi Robert,
>> yes, I just noticed that.
>> Since this is an optional dependency I would rather argue that this should be fine.
>> Can you for now push the sightly SNAPSHOT release since I am having difficulties to build that due to issue with the Company Maven repo?
>> Once we do have a Sightly release that should no longer be a problem.
>> Konrad
>>
>>
>>
>>
>>> On 26 Feb 2015, at 14:34, Robert Munteanu <ro...@apache.org> wrote:
>>>
>>> Hi Konrad,
>>>
>>> On Thu, 2015-02-26 at 12:27 +0000, kwin@apache.org wrote:
>>>> Modified: sling/trunk/bundles/extensions/models/impl/pom.xml
>>>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/models/impl/pom.xml?rev=1662434&r1=1662433&r2=1662434&view=diff
>>>> ==============================================================================
>>>> --- sling/trunk/bundles/extensions/models/impl/pom.xml (original)
>>>> +++ sling/trunk/bundles/extensions/models/impl/pom.xml Thu Feb 26 12:27:25 2015
>>>> @@ -146,5 +146,19 @@
>>>> <scope>provided</scope>
>>>> <optional>true</optional>
>>>> </dependency>
>>>> + <dependency>
>>>> + <groupId>org.apache.sling</groupId>
>>>> + <artifactId>org.apache.sling.scripting.sightly</artifactId>
>>>> + <version>1.0.0-SNAPSHOT</version>
>>>> + <scope>provided</scope>
>>>> + <optional>true</optional>
>>>> + </dependency>
>>>> + <dependency>
>>>> + <groupId>org.apache.sling</groupId>
>>>> + <artifactId>org.apache.sling.commons.classloader</artifactId>
>>>> + <version>1.3.0</version>
>>>> + <scope>provided</scope>
>>>> + <optional>true</optional>
>>>> + </dependency>
>>>> </dependencies>
>>>> </project>
>>>
>>> (snip)
>>>
>>> This breaks the main build, since it can't find a sightly SNAPSHOT in
>>> its reactor or on a repo. We could do a quick fix and deploy a sightly
>>> SNAPSHOT but the question is whether this is the right thing to do.
>>>
>>> Since models is in bundles/extensions ( i.e. in the main build ) and
>>> sightly in contrib I would argue that it's not right to place such
>>> dependencies, and I would rather see an addon in contrib which provides
>>> this functionality.
>>>
>>> WDYT?
>>>
>>> Cheers,
>>>
>>> Robert
>>>
>>>
>>
>
Re: svn commit: r1662434 - in
/sling/trunk/bundles/extensions/models/impl: pom.xml
src/main/java/org/apache/sling/models/impl/sightly/
src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2015-02-26 at 14:59 +0100, Konrad Windszus wrote:
> Regarding moving the Sling Models UseProvider to its own bundle I would like to hear other opinions on that. For me that one class does not necessarily call for a dedicated bundle.
Size is not IMO such a strong argument - some of the scripting bundles
are really small, e.g. Groovy has 3 classes and JRuby has 2 but we don't
collapse them into a scripting.misc bundles.
Also I think optional dependencies should be avoided if possible, as
they point out that better modularisation is needed.
> Is it in general not allowed to have dependencies from the main build towards the contrib section?
IMO main vs contrib is based on the expectations of contribution levels
and frequency of releases. I see main/contrib/samples as layers, with
depedencies going main <- contrib <- samples ( and main <- samples, of
course ).
Looking forward to others jumping in, most of these are just my personal
opinions/inferences :-)
Cheers,
Robert
> Thanks for your input on that,
> Konrad
>
> > On 26 Feb 2015, at 14:37, Konrad Windszus <ko...@gmx.de> wrote:
> >
> > Hi Robert,
> > yes, I just noticed that.
> > Since this is an optional dependency I would rather argue that this should be fine.
> > Can you for now push the sightly SNAPSHOT release since I am having difficulties to build that due to issue with the Company Maven repo?
> > Once we do have a Sightly release that should no longer be a problem.
> > Konrad
> >
> >
> >
> >
> >> On 26 Feb 2015, at 14:34, Robert Munteanu <ro...@apache.org> wrote:
> >>
> >> Hi Konrad,
> >>
> >> On Thu, 2015-02-26 at 12:27 +0000, kwin@apache.org wrote:
> >>> Modified: sling/trunk/bundles/extensions/models/impl/pom.xml
> >>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/models/impl/pom.xml?rev=1662434&r1=1662433&r2=1662434&view=diff
> >>> ==============================================================================
> >>> --- sling/trunk/bundles/extensions/models/impl/pom.xml (original)
> >>> +++ sling/trunk/bundles/extensions/models/impl/pom.xml Thu Feb 26 12:27:25 2015
> >>> @@ -146,5 +146,19 @@
> >>> <scope>provided</scope>
> >>> <optional>true</optional>
> >>> </dependency>
> >>> + <dependency>
> >>> + <groupId>org.apache.sling</groupId>
> >>> + <artifactId>org.apache.sling.scripting.sightly</artifactId>
> >>> + <version>1.0.0-SNAPSHOT</version>
> >>> + <scope>provided</scope>
> >>> + <optional>true</optional>
> >>> + </dependency>
> >>> + <dependency>
> >>> + <groupId>org.apache.sling</groupId>
> >>> + <artifactId>org.apache.sling.commons.classloader</artifactId>
> >>> + <version>1.3.0</version>
> >>> + <scope>provided</scope>
> >>> + <optional>true</optional>
> >>> + </dependency>
> >>> </dependencies>
> >>> </project>
> >>
> >> (snip)
> >>
> >> This breaks the main build, since it can't find a sightly SNAPSHOT in
> >> its reactor or on a repo. We could do a quick fix and deploy a sightly
> >> SNAPSHOT but the question is whether this is the right thing to do.
> >>
> >> Since models is in bundles/extensions ( i.e. in the main build ) and
> >> sightly in contrib I would argue that it's not right to place such
> >> dependencies, and I would rather see an addon in contrib which provides
> >> this functionality.
> >>
> >> WDYT?
> >>
> >> Cheers,
> >>
> >> Robert
> >>
> >>
> >
>
Re: svn commit: r1662434 - in /sling/trunk/bundles/extensions/models/impl: pom.xml src/main/java/org/apache/sling/models/impl/sightly/ src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
Posted by Konrad Windszus <ko...@gmx.de>.
I just deployed Sightly SNAPSHOTs to the Apache Snapshots repository. The next build should not longer fail due to this.
Regarding moving the Sling Models UseProvider to its own bundle I would like to hear other opinions on that. For me that one class does not necessarily call for a dedicated bundle.
Is it in general not allowed to have dependencies from the main build towards the contrib section?
Are there any plans on moving Sightly to the main build?
Thanks for your input on that,
Konrad
> On 26 Feb 2015, at 14:37, Konrad Windszus <ko...@gmx.de> wrote:
>
> Hi Robert,
> yes, I just noticed that.
> Since this is an optional dependency I would rather argue that this should be fine.
> Can you for now push the sightly SNAPSHOT release since I am having difficulties to build that due to issue with the Company Maven repo?
> Once we do have a Sightly release that should no longer be a problem.
> Konrad
>
>
>
>
>> On 26 Feb 2015, at 14:34, Robert Munteanu <ro...@apache.org> wrote:
>>
>> Hi Konrad,
>>
>> On Thu, 2015-02-26 at 12:27 +0000, kwin@apache.org wrote:
>>> Modified: sling/trunk/bundles/extensions/models/impl/pom.xml
>>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/models/impl/pom.xml?rev=1662434&r1=1662433&r2=1662434&view=diff
>>> ==============================================================================
>>> --- sling/trunk/bundles/extensions/models/impl/pom.xml (original)
>>> +++ sling/trunk/bundles/extensions/models/impl/pom.xml Thu Feb 26 12:27:25 2015
>>> @@ -146,5 +146,19 @@
>>> <scope>provided</scope>
>>> <optional>true</optional>
>>> </dependency>
>>> + <dependency>
>>> + <groupId>org.apache.sling</groupId>
>>> + <artifactId>org.apache.sling.scripting.sightly</artifactId>
>>> + <version>1.0.0-SNAPSHOT</version>
>>> + <scope>provided</scope>
>>> + <optional>true</optional>
>>> + </dependency>
>>> + <dependency>
>>> + <groupId>org.apache.sling</groupId>
>>> + <artifactId>org.apache.sling.commons.classloader</artifactId>
>>> + <version>1.3.0</version>
>>> + <scope>provided</scope>
>>> + <optional>true</optional>
>>> + </dependency>
>>> </dependencies>
>>> </project>
>>
>> (snip)
>>
>> This breaks the main build, since it can't find a sightly SNAPSHOT in
>> its reactor or on a repo. We could do a quick fix and deploy a sightly
>> SNAPSHOT but the question is whether this is the right thing to do.
>>
>> Since models is in bundles/extensions ( i.e. in the main build ) and
>> sightly in contrib I would argue that it's not right to place such
>> dependencies, and I would rather see an addon in contrib which provides
>> this functionality.
>>
>> WDYT?
>>
>> Cheers,
>>
>> Robert
>>
>>
>
Re: svn commit: r1662434 - in /sling/trunk/bundles/extensions/models/impl: pom.xml src/main/java/org/apache/sling/models/impl/sightly/ src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java
Posted by Konrad Windszus <ko...@gmx.de>.
Hi Robert,
yes, I just noticed that.
Since this is an optional dependency I would rather argue that this should be fine.
Can you for now push the sightly SNAPSHOT release since I am having difficulties to build that due to issue with the Company Maven repo?
Once we do have a Sightly release that should no longer be a problem.
Konrad
> On 26 Feb 2015, at 14:34, Robert Munteanu <ro...@apache.org> wrote:
>
> Hi Konrad,
>
> On Thu, 2015-02-26 at 12:27 +0000, kwin@apache.org wrote:
>> Modified: sling/trunk/bundles/extensions/models/impl/pom.xml
>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/models/impl/pom.xml?rev=1662434&r1=1662433&r2=1662434&view=diff
>> ==============================================================================
>> --- sling/trunk/bundles/extensions/models/impl/pom.xml (original)
>> +++ sling/trunk/bundles/extensions/models/impl/pom.xml Thu Feb 26 12:27:25 2015
>> @@ -146,5 +146,19 @@
>> <scope>provided</scope>
>> <optional>true</optional>
>> </dependency>
>> + <dependency>
>> + <groupId>org.apache.sling</groupId>
>> + <artifactId>org.apache.sling.scripting.sightly</artifactId>
>> + <version>1.0.0-SNAPSHOT</version>
>> + <scope>provided</scope>
>> + <optional>true</optional>
>> + </dependency>
>> + <dependency>
>> + <groupId>org.apache.sling</groupId>
>> + <artifactId>org.apache.sling.commons.classloader</artifactId>
>> + <version>1.3.0</version>
>> + <scope>provided</scope>
>> + <optional>true</optional>
>> + </dependency>
>> </dependencies>
>> </project>
>
> (snip)
>
> This breaks the main build, since it can't find a sightly SNAPSHOT in
> its reactor or on a repo. We could do a quick fix and deploy a sightly
> SNAPSHOT but the question is whether this is the right thing to do.
>
> Since models is in bundles/extensions ( i.e. in the main build ) and
> sightly in contrib I would argue that it's not right to place such
> dependencies, and I would rather see an addon in contrib which provides
> this functionality.
>
> WDYT?
>
> Cheers,
>
> Robert
>
>