You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Stefan Egli (JIRA)" <ji...@apache.org> on 2019/01/07 14:34:00 UTC
[jira] [Commented] (SLING-5884) Deprecate JobManager methods which
allow to manage the queue
[ https://issues.apache.org/jira/browse/SLING-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735886#comment-16735886 ]
Stefan Egli commented on SLING-5884:
------------------------------------
h2. Variant B: allow opting out of job query support
Added an alternative solution ([here|https://github.com/stefan-egli/sling-org-apache-sling-event-api/tree/jobQueriesOptOut]) which, instead of deprecating job queries, introduces a config option (visualized via a new method {{QueueConfiguration.jobQueriesEnabled()}}).
The advantage of this variant is that nothing is deprecated, no _need_ for change, however users/admins of a system can choose to disable job queries on particular queues - thereby allowing the system to do optimizations as it doesn't have to support job queries.
Note that this will require a change in the implementation too (and the suggestion so far done is only in the API) - something which can be done once we agree upon which way (A or B) we go
> Deprecate JobManager methods which allow to manage the queue
> ------------------------------------------------------------
>
> Key: SLING-5884
> URL: https://issues.apache.org/jira/browse/SLING-5884
> Project: Sling
> Issue Type: Task
> Components: Extensions
> Affects Versions: Event 4.0.2
> Reporter: Timothee Maret
> Assignee: Stefan Egli
> Priority: Major
> Fix For: Event API 1.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{JobManager}} contains methods which allow to manage the entries in the queue. Those methods such as {{o.a.s.e.j.JobManager#findJobs}} impose a heavy burden on the repository and can cause major runtime issues such as running the instance OOM.
> This issue tracks deprecating those API signatures.
> See also http://sling.markmail.org/message/k3hjqcvnnabsb47j
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)