You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/02 15:03:28 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3831: serial: Remove the unnecessary critical section in uart_pollnotify
xiaoxiang781216 opened a new pull request #3831:
URL: https://github.com/apache/incubator-nuttx/pull/3831
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #3831: serial: Remove the unnecessary critical section in uart_pollnotify
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #3831:
URL: https://github.com/apache/incubator-nuttx/pull/3831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3831: serial: Remove the unnecessary critical section in uart_pollnotify
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3831:
URL: https://github.com/apache/incubator-nuttx/pull/3831#issuecomment-853185521
Was not the the CS was for making atomic the check and the cation, not safety call to nxsem_get_value? A waiter introduced after the check will be blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #3831: serial: Remove the unnecessary critical section in uart_pollnotify
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #3831:
URL: https://github.com/apache/incubator-nuttx/pull/3831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3831: serial: Remove the unnecessary critical section in uart_pollnotify
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3831:
URL: https://github.com/apache/incubator-nuttx/pull/3831#issuecomment-853223767
> Was not the the CS was for making atomic the check and the cation, not safety call to nxsem_get_value? A waiter introduced after the check will be blocked.
If nobody wait on the sem, nxsem_get_value will return 0 and then nxsem_post will be trigger since the check "semcount < 1" return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org