You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2026/01/27 00:31:44 UTC
[PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow without `cpp_test.sh` [arrow]
alinaliBQ opened a new pull request, #49005:
URL: https://github.com/apache/arrow/pull/49005
### Rationale for this change
#49004
If running tests in CI without the cpp_test.sh script is a no-go, please let me know and I will close the PR.
### What changes are included in this PR?
- Run ODBC test executables `arrow-odbc-spi-impl-test.exe` and `arrow-flight-sql-odbc-test.exe` in the ODBC job of C++ Extra CI.
### Are these changes tested?
Yes, in CI
### Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using `cpp_test.sh` [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49005:
URL: https://github.com/apache/arrow/pull/49005#issuecomment-3849572277
@lidavidm @kou This PR is ready for review. Please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow without `cpp_test.sh` [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #49005:
URL: https://github.com/apache/arrow/pull/49005#discussion_r2736228767
##########
.github/workflows/cpp_extra.yml:
##########
@@ -434,10 +434,17 @@ jobs:
shell: cmd
run: |
call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll
- # GH-48270 TODO: Resolve segementation fault during Arrow library unload
- # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI
+ # GH-48270 TODO: Resolve segementation fault during Arrow library unload, segementation fault is caught with `ci/scripts/cpp_test.sh`
Review Comment:
```suggestion
# GH-48270 TODO: Resolve segmentation fault during Arrow library unload, segmentation fault is caught with `ci/scripts/cpp_test.sh`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using `cpp_test.sh` [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #49005:
URL: https://github.com/apache/arrow/pull/49005#discussion_r2771366112
##########
.github/workflows/cpp_extra.yml:
##########
@@ -353,6 +353,9 @@ jobs:
ARROW_BUILD_TESTS: ON
ARROW_BUILD_TYPE: release
ARROW_DEPENDENCY_SOURCE: VCPKG
+ # Turn Arrow CSV off to disable `find_package(Arrow)` check on MSVC CI.
+ # GH-49050 TODO: enable `find_package(Arrow)` check on MSVC CI.
+ ARROW_CSV: OFF
Review Comment:
Good catch, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow without `cpp_test.sh` [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49005:
URL: https://github.com/apache/arrow/pull/49005#issuecomment-3813114700
> If I understand correctly this test segfaults if not run in isolation and run as part of `ci/scripts/cpp_test.sh`? I am not an expert here but if my understanding is correct I think we should rather investigate why it segfaults instead of hiding it.
In mid-November 2025, ODBC tests on Windows failed with a segmentation fault, which can only detected via exit code checks (as done by `cpp_test.sh`) or running `$LASTEXITCODE` command on PowerShell on the local Windows. When I raised the PR, I didn't realize that the workflow CI would have failed if the ODBC test executable had segmentation fault, since the CI checks for exit code as well. 😅
Thanks to your comment reminder Raul, now I realize the ODBC tests are no longer having with segmentation fault on MSVC Windows. I think the underlying issue was resolved by recent updates in the Arrow libraries used by ODBC.
I've remove the TODO comment for segmentation fault. I have pushed a commit test `cpp_test.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow without `cpp_test.sh` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49005:
URL: https://github.com/apache/arrow/pull/49005#issuecomment-3802458545
:warning: GitHub issue #49004 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow without `cpp_test.sh` [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #49005:
URL: https://github.com/apache/arrow/pull/49005#discussion_r2733518290
##########
.github/workflows/cpp_extra.yml:
##########
@@ -434,10 +434,17 @@ jobs:
shell: cmd
run: |
call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll
- # GH-48270 TODO: Resolve segementation fault during Arrow library unload
- # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI
+ # GH-48270 TODO: Resolve segementation fault during Arrow library unload, segementation fault is caught with `ci/scripts/cpp_test.sh`
+ # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI and run tests with `ci/scripts/cpp_test.sh` instead
# GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved.
-
+ - name: Run ODBC Unit Tests
+ shell: cmd
+ run: |
+ build\cpp\%ARROW_BUILD_TYPE%\arrow-odbc-spi-impl-test.exe
+ - name: Run ODBC Driver Tests
+ shell: cmd
+ run: |
+ build\cpp\%ARROW_BUILD_TYPE%\arrow-flight-sql-odbc-test.exe
Review Comment:
@lidavidm @kou Please have a look at this small PR. I don't see other `.exe` tests being run without a script in the Arrow repo, so I am not sure this approach is accepted. If it is a no-go, I can close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using `cpp_test.sh` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49005:
URL: https://github.com/apache/arrow/pull/49005#discussion_r2766648404
##########
.github/workflows/cpp_extra.yml:
##########
@@ -353,6 +353,9 @@ jobs:
ARROW_BUILD_TESTS: ON
ARROW_BUILD_TYPE: release
ARROW_DEPENDENCY_SOURCE: VCPKG
+ # Turn Arrow CSV off to disable `find_package(Arrow)` check on MSVC CI.
+ # GH-49050 TODO: enable `find_package(Arrow)` check on MSVC CI.
+ ARROW_CSV: OFF
Review Comment:
Could you keep this list in alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using `cpp_test.sh` [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #49005:
URL: https://github.com/apache/arrow/pull/49005#discussion_r2738272066
##########
.github/workflows/cpp_extra.yml:
##########
@@ -353,6 +353,9 @@ jobs:
ARROW_BUILD_TESTS: ON
ARROW_BUILD_TYPE: release
ARROW_DEPENDENCY_SOURCE: VCPKG
+ # Turn Arrow CSV off to disable `find_package(Arrow)` check on MSVC CI.
+ # GH-49050 TODO: enable `find_package(Arrow)` check on MSVC CI.
+ ARROW_CSV: OFF
Review Comment:
Found segmentation fault at `find_package(Arrow)` example in `cpp_test.sh` that doesn't seem to be ODBC-related. Raised https://github.com/apache/arrow/issues/49050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using `cpp_test.sh` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49005:
URL: https://github.com/apache/arrow/pull/49005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org