You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/11/14 21:45:17 UTC
Review Request 53743: CI Failure:
GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53743/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
Bugs: GEODE-2073
https://issues.apache.org/jira/browse/GEODE-2073
Repository: geode
Description
-------
I modified the test to wait longer and not require that the "next neighbor" be an exact member but merely a different one than the initial "next neigbor".
Also, the diagnostic test in the exception thrown by this method was including the JoinLeave membership view but that is null in these tests. Instead it needs to show the HealthMonitor's membership view. I added a method to GMSHealthMonitor to allow access to its view.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java b04c6a1d4ddd5fe258a8148e7b5154d258a9abdb
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java 547a2003d91d2eb46f214622eef1bd229546010d
Diff: https://reviews.apache.org/r/53743/diff/
Testing
-------
Thousands of runs of the test, which only takes 1 second to execute. I also ran the whole set of tests in this class over 200 times.
Thanks,
Bruce Schuchardt
Re: Review Request 53743: CI Failure:
GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53743/#review156086
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Nov. 14, 2016, 9:45 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53743/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2016, 9:45 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-2073
> https://issues.apache.org/jira/browse/GEODE-2073
>
>
> Repository: geode
>
>
> Description
> -------
>
> I modified the test to wait longer and not require that the "next neighbor" be an exact member but merely a different one than the initial "next neigbor".
>
> Also, the diagnostic test in the exception thrown by this method was including the JoinLeave membership view but that is null in these tests. Instead it needs to show the HealthMonitor's membership view. I added a method to GMSHealthMonitor to allow access to its view.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java b04c6a1d4ddd5fe258a8148e7b5154d258a9abdb
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java 547a2003d91d2eb46f214622eef1bd229546010d
>
> Diff: https://reviews.apache.org/r/53743/diff/
>
>
> Testing
> -------
>
> Thousands of runs of the test, which only takes 1 second to execute. I also ran the whole set of tests in this class over 200 times.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>