You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2023/01/18 22:47:00 UTC
[jira] [Commented] (SOLR-16628) Occasional resource leak around XmlConfigFile parsing
[ https://issues.apache.org/jira/browse/SOLR-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678415#comment-17678415 ]
David Smiley commented on SOLR-16628:
-------------------------------------
Wow; I didn't expect such a quick turn-around on my finding! :) I look forward to seeing if this fixes what I saw. It'll take a bit... I need to see if I can run the full test suite in a normal way (not via smoketester.py) and then apply this patch to see if it goes away.
> Occasional resource leak around XmlConfigFile parsing
> ------------------------------------------------------
>
> Key: SOLR-16628
> URL: https://issues.apache.org/jira/browse/SOLR-16628
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 8.9
> Reporter: Michael Gibney
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, xml config file parsing can in exceptional circumstances lead to resource leaks (InputStream not being closed). This has occasionally [shown up in tests|https://issues.apache.org/jira/browse/SOLR-16336?focusedCommentId=17678323#comment-17678323] and presumably could also manifest in the wild.
> I suspect (but am not certain) that these changes may have been introduced in version 8.9 by SOLR-15337 (closing of byte streams in xml parsing is unusual iiuc in that according to spec, closing is handled internal to the parser, so it's easy to rely on that behavior and things will usually be ok. But we should take extra steps to ensure the InputStreams are always closed).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org