You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/09/21 19:21:16 UTC
[GitHub] [submarine] lowc1012 opened a new pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
lowc1012 opened a new pull request #407:
URL: https://github.com/apache/submarine/pull/407
### What is this PR for?
Update the apache/notebook:jupyter-notebook docker image
1. Preinstall notebook & apache-submarine in jupyter notebook when container is running
2. Install the custom kernel for jupyter notebook
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
[SUBMARINE-617](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-617)
### How should this be tested?
[Travis CI](https://travis-ci.org/github/lowc1012/submarine/builds/729093692)
### Screenshots (if appropriate)


<img width="1212" alt="img3" src="https://user-images.githubusercontent.com/52355146/93810914-e8817380-fc81-11ea-9791-4588e5edc069.png">
<img width="608" alt="img4" src="https://user-images.githubusercontent.com/52355146/93810953-f931e980-fc81-11ea-8c74-2dcc382b891b.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-698723115
Could you also set the environment used by Jupyter Notebook in https://github.com/apache/submarine/blob/master/docs/database/submarine-data.sql?
So we don't need to manually create this environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #407:
URL: https://github.com/apache/submarine/pull/407#discussion_r494730997
##########
File path: dev-support/docker-images/jupyter/start-notebook.sh
##########
@@ -42,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
fi
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}" 46,48 Bot
Review comment:
`46,48 Bot ` at the end of the line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-698761096
@pingsutw Thanks for your review! I pushed a fixed-commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-697345495
In the first commit, apache-submarine package will be installed whenever creating notebook server. It spend a lot of time. I suggest that apache-submarine package should be installed before notebook container was running, and spend a lot of time pulling image when creating notebook server first time inevitably.
c.c. @jiwq @pingsutw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-698723115
Could you also set the environment used by Jupyter Notebook in https://github.com/apache/submarine/blob/master/docs/database/submarine-data.sql?
So we don't need to manually create this environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-698231917
@jiwq @pingsutw
I set two environment variables (SUBMARINE_SERVER_DNS_NAME and SUBMARINE_SERVER_PORT) in notebook container. Notebook can connect to submarine-server with Submarine SDK without entering the URL.
Please review this PR again. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #407:
URL: https://github.com/apache/submarine/pull/407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-698231917
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #407:
URL: https://github.com/apache/submarine/pull/407#discussion_r492462730
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -50,22 +44,33 @@ RUN echo "$LOG_TAG Set locale" && \
echo "LANG=en_US.UTF-8" > /etc/locale.conf && \
locale-gen en_US.UTF-8
-ENV LANG=en_US.UTF-8 \
- LC_ALL=en_US.UTF-8
+ENV NB_USER=$NB_USER \
+ NB_UID=$NB_UID \
+ NB_PREFIX=$NB_PREFIX \
+ NB_PORT=$NB_PORT \
+ CONDA_DIR=/opt/conda \
+ LANG=en_US.UTF-8 \
+ LC_ALL=en_US.UTF-8 \
+ LANGUAGE=en_US.UTF-8
+ENV PATH=$CONDA_DIR/bin:$PATH \
+ HOME=/home/$NB_USER
Review comment:
```suggestion
LANGUAGE=en_US.UTF-8 \
PATH=$CONDA_DIR/bin:$PATH \
HOME=/home/$NB_USER
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #407:
URL: https://github.com/apache/submarine/pull/407#discussion_r494730997
##########
File path: dev-support/docker-images/jupyter/start-notebook.sh
##########
@@ -42,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
fi
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}" 46,48 Bot
Review comment:
46,48 Bot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #407:
URL: https://github.com/apache/submarine/pull/407#discussion_r494729952
##########
File path: dev-support/docker-images/jupyter/start-notebook.sh
##########
@@ -42,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
fi
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}" 46,48 Bot
Review comment:
What it is?
##########
File path: dev-support/docker-images/jupyter/start-notebook.sh
##########
@@ -42,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
fi
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}" 46,48 Bot
Review comment:
46,48 Bot
##########
File path: dev-support/docker-images/jupyter/start-notebook.sh
##########
@@ -42,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
fi
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}" 46,48 Bot
Review comment:
`46,48 Bot ` at the end of the line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-697112496
I' m working on that inject submarine server DNS into notebook to easy the internal communication and SDK initialization. Please do not commit it temporarily. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #407:
URL: https://github.com/apache/submarine/pull/407#issuecomment-697112496
I' m working on that inject submarine server DNS into notebook to easy the internal communication and SDK initialization. Please do not commit it temporarily. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #407:
URL: https://github.com/apache/submarine/pull/407#discussion_r492462730
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -50,22 +44,33 @@ RUN echo "$LOG_TAG Set locale" && \
echo "LANG=en_US.UTF-8" > /etc/locale.conf && \
locale-gen en_US.UTF-8
-ENV LANG=en_US.UTF-8 \
- LC_ALL=en_US.UTF-8
+ENV NB_USER=$NB_USER \
+ NB_UID=$NB_UID \
+ NB_PREFIX=$NB_PREFIX \
+ NB_PORT=$NB_PORT \
+ CONDA_DIR=/opt/conda \
+ LANG=en_US.UTF-8 \
+ LC_ALL=en_US.UTF-8 \
+ LANGUAGE=en_US.UTF-8
+ENV PATH=$CONDA_DIR/bin:$PATH \
+ HOME=/home/$NB_USER
Review comment:
```suggestion
LANGUAGE=en_US.UTF-8 \
PATH=$CONDA_DIR/bin:$PATH \
HOME=/home/$NB_USER
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #407: SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #407:
URL: https://github.com/apache/submarine/pull/407#discussion_r494729952
##########
File path: dev-support/docker-images/jupyter/start-notebook.sh
##########
@@ -42,4 +43,4 @@ if [[ -n "${NB_PREFIX}" ]]; then
NOTEBOOK_ARGS="--NotebookApp.base_url=${NB_PREFIX} ${NOTEBOOK_ARGS}"
fi
-/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}"
+/bin/bash -c "jupyter notebook ${NOTEBOOK_ARGS}" 46,48 Bot
Review comment:
What it is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org