You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/13 19:17:18 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #35886: [SPARK-38582][K8S] Add `KubernetesUtils.buildEnvVars(WithFieldRef)?` utility functions
dongjoon-hyun commented on code in PR #35886:
URL: https://github.com/apache/spark/pull/35886#discussion_r945181025
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala:
##########
@@ -84,25 +84,18 @@ private[spark] class DriverCommandFeatureStep(conf: KubernetesDriverConf)
"variables instead.")
}
- val pythonEnvs =
- Seq(
- conf.get(PYSPARK_PYTHON)
- .orElse(environmentVariables.get(ENV_PYSPARK_PYTHON)).map { value =>
- new EnvVarBuilder()
- .withName(ENV_PYSPARK_PYTHON)
- .withValue(value)
- .build()
- },
- conf.get(PYSPARK_DRIVER_PYTHON)
- .orElse(conf.get(PYSPARK_PYTHON))
- .orElse(environmentVariables.get(ENV_PYSPARK_DRIVER_PYTHON))
- .orElse(environmentVariables.get(ENV_PYSPARK_PYTHON)).map { value =>
- new EnvVarBuilder()
- .withName(ENV_PYSPARK_DRIVER_PYTHON)
- .withValue(value)
- .build()
- }
- ).flatten
+ val pythonEnvs = {
+ KubernetesUtils.buildEnvVars(
+ Map(
+ ENV_PYSPARK_PYTHON -> conf.get(PYSPARK_PYTHON)
+ .orElse(environmentVariables.get(ENV_PYSPARK_PYTHON))
+ .orNull,
+ ENV_PYSPARK_DRIVER_PYTHON -> conf.get(PYSPARK_DRIVER_PYTHON)
+ .orElse(conf.get(PYSPARK_PYTHON))
+ .orElse(environmentVariables.get(ENV_PYSPARK_DRIVER_PYTHON))
+ .orElse(environmentVariables.get(ENV_PYSPARK_PYTHON))
+ .orNull))
+ }
Review Comment:
Could you check what happens when both `PYSPARK_PYTHON` and `ENV_PYSPARK_PYTHON` is not defined? New logic looks not identical with the previous one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org