You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/12/15 21:32:08 UTC
[Impala-ASF-CR] IMPALA-10934 (Part 2): Enable table definition over a single file
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18033 )
Change subject: IMPALA-10934 (Part 2): Enable table definition over a single file
......................................................................
Patch Set 3:
(2 comments)
These are useful tests. I have a couple small comments, but I think we can go forward with this and part 1.
http://gerrit.cloudera.org:8080/#/c/18033/3/testdata/workloads/functional-query/queries/QueryTest/sfs.test
File testdata/workloads/functional-query/queries/QueryTest/sfs.test:
http://gerrit.cloudera.org:8080/#/c/18033/3/testdata/workloads/functional-query/queries/QueryTest/sfs.test@38
PS3, Line 38: ---- QUERY
: INSERT INTO TABLE test_tbl_01 VALUES ('x', 100);
: ---- CATCH
: row_regex: .*Unable to INSERT into target table .+ because .+ is not a supported filesystem.*
: ====
: ---- QUERY
: INSERT INTO TABLE test_tbl_02 VALUES ('x', 100);
: ---- CATCH
: row_regex: .*Unable to INSERT into target table .+ because .+ is not a supported filesystem.*
: ====
: ---- QUERY
: LOAD DATA INPATH 'hdfs://localhost:20500/test-warehouse/$DATABASE.db/sfs_d3.parq' INTO TABLE test_tbl_01
: ---- CATCH
: Unsupported SFS filesystem operation!
: ====
: ---- QUERY
: LOAD DATA INPATH 'hdfs://localhost:20500/test-warehouse/$DATABASE.db/sfs_d4.txt' INTO TABLE test_tbl_02
: ---- CATCH
: Unsupported SFS filesystem operation!
: ====
: ---- QUERY
: LOAD DATA INPATH 'sfs+hdfs://localhost:20500/test-warehouse/$DATABASE.db/sfs_d3.parq/#SINGLEFILE#' INTO TABLE test_tbl_01
: ---- CATCH
: row_regex: .*INPATH location .+ must point to one of the supported filesystem URI scheme.*
: ====
: ---- QUERY
: LOAD DATA INPATH 'sfs+hdfs://localhost:20500/test-warehouse/$DATABASE.db/sfs_d4.txt/#SINGLEFILE#' INTO TABLE test_tbl_02
: ---- CATCH
: row_regex: .*INPATH location .+ must point to one of the supported filesystem URI scheme.*
Let's add a case for TRUNCATE TABLE. I'm guessing it should fail and not delete the file?
https://impala.apache.org/docs/build/html/topics/impala_truncate_table.html
Let's also call COMPUTE STATS just to make sure it works.
http://gerrit.cloudera.org:8080/#/c/18033/3/testdata/workloads/functional-query/queries/QueryTest/sfs.test@157
PS3, Line 157: ---- QUERY
: DROP TABLE test_tbl_03;
: DROP TABLE test_tbl_04
It would be nice to have a test case that verifies that the files are still there. Maybe create another table that references the same location and select to show it is still there.
--
To view, visit http://gerrit.cloudera.org:8080/18033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f57f07a9f543c660b102ebf307a6cf590a6784
Gerrit-Change-Number: 18033
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ki...@rxd.hu>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 21:32:08 +0000
Gerrit-HasComments: Yes