[GitHub] [hudi] nsivabalan commented on a change in pull request #4762: [HUDI-3367] Adding support for custom scheduler configs with streaming sink

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #4762:
URL: https://github.com/apache/hudi/pull/4762#discussion_r809429275



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -117,6 +117,11 @@ object HoodieSparkSqlWriter {
     }
 
     val jsc = new JavaSparkContext(sparkContext)
+    if (asyncCompactionTriggerFn.isDefined) {
+      if (jsc.getConf.getOption(DataSourceWriteOptions.SPARK_SCHEDULER_ALLOCATION_FILE_KEY).isDefined) {
+        jsc.setLocalProperty("spark.scheduler.pool", DataSourceWriteOptions.SPARK_DATASOURCE_WRITER_POOL_NAME)

Review comment:
        I agree. but do you have a good suggestion as to where to move this? I could not find a right class to move this only. 
   Only option I can think of is to introduce a new class just to hold this 2 new variables. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org