You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/05 21:28:53 UTC
[GitHub] [airflow] kaxil opened a new pull request #13497: Fix failing backport packages test
kaxil opened a new pull request #13497:
URL: https://github.com/apache/airflow/pull/13497
In #13473 - I updated the deprecated packages but looks like it broke backport packages:
```
File "/usr/local/lib/python3.6/site-packages/airflow/providers/google/cloud/example_dags/example_tasks.py", line 32, in <module>
from airflow.models.baseoperator import chain
ImportError: cannot import name 'chain'
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13497:
URL: https://github.com/apache/airflow/pull/13497#discussion_r552208662
##########
File path: airflow/providers/google/cloud/example_dags/example_tasks.py
##########
@@ -47,6 +46,7 @@
CloudTasksTasksListOperator,
)
from airflow.utils.dates import days_ago
+from airflow.utils.helpers import chain
Review comment:
@turbaszek I am wondering if we can update this in `dev/provider_packages/refactor_provider_packages.py`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13497:
URL: https://github.com/apache/airflow/pull/13497#discussion_r552209042
##########
File path: airflow/providers/google/cloud/example_dags/example_tasks.py
##########
@@ -47,6 +46,7 @@
CloudTasksTasksListOperator,
)
from airflow.utils.dates import days_ago
+from airflow.utils.helpers import chain
Review comment:
But I see this:
https://github.com/apache/airflow/blob/0fd5807632468ebdf349d47372b5226bc8160d36/dev/provider_packages/refactor_provider_packages.py#L601-L602
So I am not sure if I am missing something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13497:
URL: https://github.com/apache/airflow/pull/13497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13497:
URL: https://github.com/apache/airflow/pull/13497#issuecomment-754960841
> `from airflow.models.baseoperator import chain` should continue to work for all of Airflow 2.0 now, otherwise this will be a breaking change when we release Airflow 2.1.
>
> Or am I misunderstanding this change?
Yeah both imports work on Master, In #13473 I changed the example DAG to use the non-deprecated import but the CI test we have for backport packages failed, coz the non-deprecated one is not present in 1.10.x and we don't refactor that import in bowler when we build Backport packages. So I just reverted that import in the example_dag.
Both imports still continue to work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13497:
URL: https://github.com/apache/airflow/pull/13497#issuecomment-754946697
`from airflow.models.baseoperator import chain` should continue to work for all of Airflow 2.0 now, otherwise this will be a breaking change when we release Airflow 2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #13497:
URL: https://github.com/apache/airflow/pull/13497#issuecomment-754946697
`from airflow.models.baseoperator import chain` should continue to work for all of Airflow 2.0 now, otherwise this will be a breaking change when we release Airflow 2.1.
Or am I misunderstanding this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13497:
URL: https://github.com/apache/airflow/pull/13497#discussion_r552211379
##########
File path: airflow/providers/google/cloud/example_dags/example_tasks.py
##########
@@ -47,6 +46,7 @@
CloudTasksTasksListOperator,
)
from airflow.utils.dates import days_ago
+from airflow.utils.helpers import chain
Review comment:
For now we can merge it as is to make Master green but I am curious if we can just modify that import using bowler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13497: Fix failing backport packages test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13497:
URL: https://github.com/apache/airflow/pull/13497#issuecomment-754914239
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org