[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6272: Set S3 Bucket ACL policy from config

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #6272:
URL: https://github.com/apache/incubator-pinot/pull/6272#discussion_r525578569



##########
File path: pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
##########
@@ -225,9 +225,15 @@ private boolean copyFile(URI srcUri, URI dstUri)
       }
 
       String dstPath = sanitizePath(dstUri.getPath());
-      CopyObjectRequest copyReq =
-          CopyObjectRequest.builder().copySource(encodedUrl).destinationBucket(dstUri.getHost()).destinationKey(dstPath)
-              .build();
+      CopyObjectRequest.Builder copyReqBuilder = CopyObjectRequest.builder().copySource(encodedUrl)
+          .destinationBucket(dstUri.getHost()).destinationKey(dstPath);
+      CopyObjectRequest copyReq;
+
+      if (!disableAcl) {

Review comment:
       if (!disableAcl) {
       copyReqBuilder.acl(ObjectCannedACL.BUCKET_OWNER_FULL_CONTROL);
   } 
   CopyObjectRequest copyReq = copyReqBuilder.build();




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org