[GitHub] glaksh100 commented on issue #7679: [FLINK-11501][Kafka Connector] Add ratelimiting to Kafka consumer

[GitBox <gi...@apache.org>]

glaksh100 commented on issue #7679: [FLINK-11501][Kafka Connector] Add ratelimiting to Kafka consumer
URL: https://github.com/apache/flink/pull/7679#issuecomment-463086493
 
 
   Thanks for taking a look @becketqin and @tweise. I think adding an interface that can extend to other connectors  and also not restricting consumers to use Guava's RateLimiter makes sense. Maybe something simple like below will work for the interface?
   
   ```
   public interface FlinkConnectorRateLimiter {
   	public void open(StreamingRuntimeContext runtimeContext);
   	public <T> T create(long rate);
   	public void setRate(long rate);
   	public void close();
   }
   ```
   And connector specific RateLimiters can be defined to implement this interface. 
   
   Also, point taken on keeping these discussions on the mailing list in the future. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services