You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jason Dillon <ja...@planet57.com> on 2007/03/20 23:58:25 UTC
Empty .java file: geronimo-axis2/src/test/java/org/apache/geronimo/axis2/testdata/HelloWorld.java
Why is this here?
--jason
Re: Empty .java file: geronimo-axis2/src/test/java/org/apache/geronimo/axis2/testdata/HelloWorld.java
Posted by Lasantha Ranaweera <la...@opensource.lk>.
Is there a method to stop creating this kind of empty files after
refactoring and submitting a patch ????
Thanks,
Lasantha
Lasantha Ranaweera wrote:
> Jason,
>
> Looks like I am the culprit here. I have factored some of these file
> before submmitting a patch which have created these empty files. If
> you can remove these files from the SVN that would be a great help.
>
> HelloWorld.java - src/test/java/org/apache/geronimo/axis2/testdata
> test_service_doc_lit.wsdl - src/test/resources
> test_service_loc_lit_request.xml - src/test/resources
>
> I am searching for why I have created this problem and hope not to do
> this kind of mistakes future.
>
> Thanks Again,
> Lasantha
>
> Jason Dillon wrote:
>> There are also some empty .xml files in the test/resources. If
>> someone can take a look and see if these empty files are needed by
>> the tests or not and report back so we can clean them up it would be
>> appreciated.
>>
>> --jason
>>
>>
>> On Mar 20, 2007, at 6:32 PM, Lin Sun wrote:
>>
>>> probably happened when someone tries to delete a file and submit a
>>> patch for it. In the patch, it will contain the every single line
>>> of the file with the - sign at the beginning left. Thus when the
>>> patch is applied, the file is empty!
>>>
>>> Lin
>>> Jason Dillon wrote:
>>>> Why is this here?
>>>> --jason
>>>
>>
>>
>>
>> --No virus found in this incoming message.
>> Checked by AVG Free Edition.
>> Version: 7.5.446 / Virus Database: 268.18.15/728 - Release Date:
>> 3/20/2007 8:07 AM
>>
>>
>
>
>
Re: Empty .java file: geronimo-axis2/src/test/java/org/apache/geronimo/axis2/testdata/HelloWorld.java
Posted by Jason Dillon <ja...@planet57.com>.
Aight, I've removed these... thanks for checking.
--jason
On Mar 20, 2007, at 7:33 PM, Lasantha Ranaweera wrote:
> Jason,
>
> Looks like I am the culprit here. I have factored some of these
> file before submmitting a patch which have created these empty
> files. If you can remove these files from the SVN that would be a
> great help.
>
> HelloWorld.java - src/test/java/org/apache/geronimo/axis2/testdata
> test_service_doc_lit.wsdl - src/test/resources
> test_service_loc_lit_request.xml - src/test/resources
>
> I am searching for why I have created this problem and hope not to
> do this kind of mistakes future.
>
> Thanks Again,
> Lasantha
>
> Jason Dillon wrote:
>> There are also some empty .xml files in the test/resources. If
>> someone can take a look and see if these empty files are needed by
>> the tests or not and report back so we can clean them up it would
>> be appreciated.
>>
>> --jason
>>
>>
>> On Mar 20, 2007, at 6:32 PM, Lin Sun wrote:
>>
>>> probably happened when someone tries to delete a file and submit
>>> a patch for it. In the patch, it will contain the every single
>>> line of the file with the - sign at the beginning left. Thus
>>> when the patch is applied, the file is empty!
>>>
>>> Lin
>>> Jason Dillon wrote:
>>>> Why is this here?
>>>> --jason
>>>
>>
>>
>>
>> --No virus found in this incoming message.
>> Checked by AVG Free Edition.
>> Version: 7.5.446 / Virus Database: 268.18.15/728 - Release Date:
>> 3/20/2007 8:07 AM
>>
>>
>
Re: Empty .java file: geronimo-axis2/src/test/java/org/apache/geronimo/axis2/testdata/HelloWorld.java
Posted by Lasantha Ranaweera <la...@opensource.lk>.
Jason,
Looks like I am the culprit here. I have factored some of these file
before submmitting a patch which have created these empty files. If you
can remove these files from the SVN that would be a great help.
HelloWorld.java - src/test/java/org/apache/geronimo/axis2/testdata
test_service_doc_lit.wsdl - src/test/resources
test_service_loc_lit_request.xml - src/test/resources
I am searching for why I have created this problem and hope not to do
this kind of mistakes future.
Thanks Again,
Lasantha
Jason Dillon wrote:
> There are also some empty .xml files in the test/resources. If
> someone can take a look and see if these empty files are needed by the
> tests or not and report back so we can clean them up it would be
> appreciated.
>
> --jason
>
>
> On Mar 20, 2007, at 6:32 PM, Lin Sun wrote:
>
>> probably happened when someone tries to delete a file and submit a
>> patch for it. In the patch, it will contain the every single line
>> of the file with the - sign at the beginning left. Thus when the
>> patch is applied, the file is empty!
>>
>> Lin
>> Jason Dillon wrote:
>>> Why is this here?
>>> --jason
>>
>
>
>
> --No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.446 / Virus Database: 268.18.15/728 - Release Date:
> 3/20/2007 8:07 AM
>
>
Re: Empty .java file: geronimo-axis2/src/test/java/org/apache/geronimo/axis2/testdata/HelloWorld.java
Posted by Lin Sun <li...@gmail.com>.
I don't think they are needed. They are introduced because of this JIRA
- http://issues.apache.org/jira/browse/GERONIMO-2979 and this is a
unique prob with patches unfortunately. maybe a svn bug so that it can
remove the empty files automatically during commit?
Lin
Jason Dillon wrote:
> There are also some empty .xml files in the test/resources. If someone
> can take a look and see if these empty files are needed by the tests or
> not and report back so we can clean them up it would be appreciated.
>
> --jason
>
>
> On Mar 20, 2007, at 6:32 PM, Lin Sun wrote:
>
>> probably happened when someone tries to delete a file and submit a
>> patch for it. In the patch, it will contain the every single line of
>> the file with the - sign at the beginning left. Thus when the patch
>> is applied, the file is empty!
>>
>> Lin
>> Jason Dillon wrote:
>>> Why is this here?
>>> --jason
>>
>
>
Re: Empty .java file: geronimo-axis2/src/test/java/org/apache/geronimo/axis2/testdata/HelloWorld.java
Posted by Jason Dillon <ja...@planet57.com>.
There are also some empty .xml files in the test/resources. If
someone can take a look and see if these empty files are needed by
the tests or not and report back so we can clean them up it would be
appreciated.
--jason
On Mar 20, 2007, at 6:32 PM, Lin Sun wrote:
> probably happened when someone tries to delete a file and submit a
> patch for it. In the patch, it will contain the every single line
> of the file with the - sign at the beginning left. Thus when the
> patch is applied, the file is empty!
>
> Lin
> Jason Dillon wrote:
>> Why is this here?
>> --jason
>
Re: Empty .java file: geronimo-axis2/src/test/java/org/apache/geronimo/axis2/testdata/HelloWorld.java
Posted by Lin Sun <li...@gmail.com>.
probably happened when someone tries to delete a file and submit a patch
for it. In the patch, it will contain the every single line of the
file with the - sign at the beginning left. Thus when the patch is
applied, the file is empty!
Lin
Jason Dillon wrote:
> Why is this here?
>
> --jason
>