You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Joseph Wu (JIRA)" <ji...@apache.org> on 2017/01/12 01:47:16 UTC
[jira] [Commented] (MESOS-5455) Transition away from temporary
build variables
[ https://issues.apache.org/jira/browse/MESOS-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819848#comment-15819848 ]
Joseph Wu commented on MESOS-5455:
----------------------------------
With this comment, only {{BUILD_FLAGS}} remains:
{code}
commit c7fc1377b33c4eb83a01167bdb53c102c06b9a99
Author: Alex Clemmer <cl...@gmail.com>
Date: Wed Jan 11 17:34:16 2017 -0800
CMake: Added correct values for some build flags.
Currently, the CMake build does not implement certain build flags
as the autotools solution does. For example, `BUILD_DATE` is hard coded,
and the `BUILD_USER` flags is always "frank". This commit will add
correct values for all such flags, with the exception of `BUILD_FLAGS`.
In addition, this commit will take this opportunity to clean up the
organization of the build flags. Currently, we call `add_definitions`
individually for each flag we wish to define. This commit will introduce
a new variable, `MESOS_CPPFLAGS`, which holds the build flags for the
project. We call `add_definitions` once, when `MESOS_CPPFLAGS` is
completely populated.
Review: https://reviews.apache.org/r/55040/
{code}
> Transition away from temporary build variables
> ----------------------------------------------
>
> Key: MESOS-5455
> URL: https://issues.apache.org/jira/browse/MESOS-5455
> Project: Mesos
> Issue Type: Bug
> Components: cmake
> Reporter: Alex Clemmer
> Assignee: Alex Clemmer
> Labels: mesosphere, microsoft
>
> Right now the CMake build system has a bunch of stub values for variables like `BUILD_DATE`.
> We should replace these with "real" values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)