[GitHub] [spark] viirya commented on a change in pull request #25133: [SPARK-28365][Python][TEST] Set default locale for StopWordsRemover tests to prevent invalid locale error during test

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #25133: [SPARK-28365][Python][TEST] Set default locale for StopWordsRemover tests to prevent invalid locale error during test
URL: https://github.com/apache/spark/pull/25133#discussion_r303237935
 
 

 ##########
 File path: python/pyspark/ml/feature.py
 ##########
 @@ -2612,6 +2612,8 @@ class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol, JavaMLReadabl
 
     .. note:: null values from input array are preserved unless adding null to stopWords explicitly.
 
+    >>> locale = spark._jvm.java.util.Locale
+    >>> locale.setDefault(locale.forLanguageTag("en-US")) # Set a default local
 
 Review comment:
   Hmm, yeah, I agree, thro I just wanted to make the test work at first. Suggested way changes current behavior, but seems to me more reasonable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org