You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/06/10 17:52:53 UTC

[GitHub] [nuttx] pkarashchenko opened a new pull request, #9510: libs/libc/string: fix various style issues in code

pkarashchenko opened a new pull request, #9510:
URL: https://github.com/apache/nuttx/pull/9510

   ## Summary
   1. Add missing `FAR` to pointers
   2. Fix style issues
   3. Update to use `'\0'` comparison
   
   ## Impact
   N/A
   
   ## Testing
   Pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9510: libs/libc/string: fix various style issues in code

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9510:
URL: https://github.com/apache/nuttx/pull/9510#discussion_r1225507670


##########
libs/libc/string/lib_memmem.c:
##########
@@ -42,6 +42,7 @@
  *
  ****************************************************************************/
 
+#undef memmem /* See mm/README.txt */

Review Comment:
   Should we update `mm/README.md` to mention string.h APIs as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9510: libs/libc/string: fix various style issues in code

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9510:
URL: https://github.com/apache/nuttx/pull/9510#discussion_r1225493156


##########
libs/libc/string/lib_memmem.c:
##########
@@ -42,6 +42,7 @@
  *
  ****************************************************************************/
 
+#undef memmem /* See mm/README.txt */

Review Comment:
   @xiaoxiang781216 in general I see the `#undef xxxx /* See mm/README.txt */` used in `string.h` APIs, but the content of `mm/README.txt` has description only for APIs from `stdlib.h`. I'm not sure if the same is applied to `string.h` APIs so maybe `libs/libc/string` should be cleaned up instead of adding undefs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9510: libs/libc/string: fix various style issues in code

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9510:
URL: https://github.com/apache/nuttx/pull/9510#discussion_r1225705521


##########
libs/libc/string/lib_memmem.c:
##########
@@ -42,6 +42,7 @@
  *
  ****************************************************************************/
 
+#undef memmem /* See mm/README.txt */

Review Comment:
   could be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9510: libs/libc/string: fix various style issues in code

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9510:
URL: https://github.com/apache/nuttx/pull/9510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9510: libs/libc/string: fix various style issues in code

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9510:
URL: https://github.com/apache/nuttx/pull/9510#discussion_r1225505626


##########
libs/libc/string/lib_memmem.c:
##########
@@ -42,6 +42,7 @@
  *
  ****************************************************************************/
 
+#undef memmem /* See mm/README.txt */

Review Comment:
   Yes, the undef is needed for string too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org